Commit Graph

516 Commits

Author SHA1 Message Date
Nora Trapp
29fb38c9ad New permission reminders 2020-06-08 15:28:25 -07:00
Matthew Chen
9e6e53723a Merge branch 'release/3.10.3' into release/3.11.0 2020-06-07 12:15:29 -03:00
Matthew Chen
ba801f05ce Label the "slow write transactions" logging with the source of the transaction. 2020-06-07 10:37:55 -03:00
Matthew Chen
91b82cf90f Hide group member count in group views. 2020-06-06 19:38:49 -03:00
Matthew Chen
d6455c5025 Remove old conversation settings views. 2020-06-06 18:03:45 -03:00
Matthew Chen
fd07cfe8a4 Remove old conversation settings views. 2020-06-06 16:16:29 -03:00
Nora Trapp
6504c1d113 Cleanup unused copy 2020-06-06 16:11:31 -03:00
Matthew Chen
40f8b15fde Merge remote-tracking branch 'private/release/3.9.1' 2020-06-01 12:44:58 -03:00
Matthew Chen
469b9767eb Fix add group member. 2020-06-01 02:12:02 -03:00
Nora Trapp
b104082f0d Merge branch 'release/3.9.0' 2020-05-22 14:12:54 -07:00
Matthew Chen
6b4f192b1b Remove usage of retainUntilComplete. 2020-05-22 09:51:12 -03:00
Matthew Chen
74c21054a6 Remove confirmation UI for saving changes to disappearing messages state. 2020-05-22 09:40:22 -03:00
Matthew Chen
6dc6c0d10d Refine "pending invites" behavior. 2020-05-22 09:40:22 -03:00
Matthew Chen
b84bd3c2a6 Refine "who can revoke invites" behavior. 2020-05-22 09:40:22 -03:00
Matthew Chen
bb7e3e44a6 Improve errors in recipient picker. 2020-05-22 09:40:22 -03:00
Matthew Chen
32e3ee920d Refine "who can revoke invites" behavior. 2020-05-22 09:40:22 -03:00
Matthew Chen
1bb7ad161d Add internal UI for manipulating groups v2 membership access. 2020-05-22 09:40:22 -03:00
Matthew Chen
50d0463948 Show UUID indicators in .qa builds. 2020-05-22 09:40:22 -03:00
Matthew Chen
9f8e32e070 Merge remote-tracking branch 'private/release/3.8.3' 2020-05-07 16:55:09 -03:00
Matthew Chen
b155c38fd5 Fix 'unsaved changes' copy in conversation settings view. 2020-05-07 11:18:51 -03:00
Matthew Chen
2b987f994a Merge remote-tracking branch 'private/release/3.8.1' 2020-05-01 12:40:28 -03:00
Matthew Chen
dadbba1d49 Add gv2 member status indicators. 2020-04-30 13:06:20 -03:00
Matthew Chen
46271e4247 Add gv2 member status indicators. 2020-04-30 13:06:20 -03:00
Matthew Chen
48d4501f96 Add gv2 member status indicators. 2020-04-30 13:06:20 -03:00
Matthew Chen
51292d4bdf Merge branch 'release/3.8.1' 2020-04-29 14:40:43 -03:00
Matthew Chen
d60af64d29 Suppress "group updated" info messages without user-facing changes. 2020-04-28 16:43:21 -03:00
Matthew Chen
2ce2504058 Merge remote-tracking branch 'private/release/3.8.0' 2020-04-28 16:01:52 -03:00
Matthew Chen
87e5690856 Save disappearing message changes in convo settings view. 2020-04-28 09:27:41 -03:00
Matthew Chen
c8a638d356 Merge remote-tracking branch 'private/release/3.8.0' 2020-04-23 12:59:57 -03:00
Matthew Chen
046b94318a Apply theme blue tint colors. 2020-04-23 10:59:12 -03:00
Matthew Chen
69085b8e15 More design changes. 2020-04-23 10:59:12 -03:00
Matthew Chen
babbe6cc2e Rework recipient picker structure. 2020-04-23 10:59:12 -03:00
Matthew Chen
9a6ab0f888 Revise how member counts are presented in new "create group" flow. 2020-04-22 15:21:34 -03:00
Matthew Chen
8f66b175c6 Tweak avatar sizes again. 2020-04-22 15:21:34 -03:00
Matthew Chen
7693545789 Improve handling of v1 groups in v2 groups UI. 2020-04-22 15:21:34 -03:00
Matthew Chen
ec7ef21bc7 Design changes for groups v2 UI. 2020-04-22 15:21:33 -03:00
Matthew Chen
0666e80551 Disable selection of "you" member in conversation settings. 2020-04-22 15:21:33 -03:00
Matthew Chen
c67cf3f025 Revise table section header and footer backgrounds. 2020-04-22 15:21:33 -03:00
Matthew Chen
c7942fb2db Revise table section header and footer backgrounds. 2020-04-22 15:21:33 -03:00
Matthew Chen
65d2b8da4b Revise group member labels. 2020-04-22 15:18:36 -03:00
Matthew Chen
b2e90bf164 Merge remote-tracking branch 'private/release/3.8.0' 2020-04-20 11:52:54 -03:00
Matthew Chen
92fbfa006a Only show "replacement admin" alert if you are the last admin. 2020-04-20 09:18:26 -03:00
Matthew Chen
d9fe245247 Fix group members view. 2020-04-20 09:18:26 -03:00
Matthew Chen
ab28e78355 Respond to CR. 2020-04-17 17:41:38 -03:00
Matthew Chen
67fcd10ba7 Design changes. 2020-04-17 17:33:27 -03:00
Matthew Chen
4e5b150f8b Design changes. 2020-04-17 17:33:27 -03:00
Matthew Chen
525ff43be6 Avoid "note to self" icon in group conversation settings. 2020-04-17 17:33:27 -03:00
Matthew Chen
6f62abeb3f Clean up lingering groups v2-related TODOs. 2020-04-16 16:10:09 -03:00
Matthew Chen
07b3f14f65 Respond to CR. 2020-04-16 16:04:11 -03:00
Matthew Chen
d4be765136 Revise dark theme. 2020-04-16 14:33:13 -03:00
Matthew Chen
ee401e4845 Revise dark theme. 2020-04-16 14:21:17 -03:00
Matthew Chen
3437510a4e Revise dark theme. 2020-04-16 13:25:11 -03:00
Matthew Chen
9c37d12266 Revise dark theme. 2020-04-16 12:34:09 -03:00
Matthew Chen
7c3433c6ba Revise dark theme. 2020-04-16 12:00:42 -03:00
Matthew Chen
b3fba8829c Revise dark theme. 2020-04-16 11:44:03 -03:00
Matthew Chen
3bbbb1aae0 Revise dark theme. 2020-04-16 11:32:35 -03:00
Matthew Chen
817780f201 Revise dark theme. 2020-04-16 11:25:32 -03:00
Matthew Chen
df8c7ee70d Update table cell layouts. 2020-04-16 09:07:04 -03:00
Matthew Chen
79780918a0 Update table cell layouts. 2020-04-16 09:07:04 -03:00
Matthew Chen
4cebf46de3 Update table cell layouts. 2020-04-16 09:07:04 -03:00
Matthew Chen
f912c1b490 Resize font sizes in table view cells. 2020-04-16 09:07:04 -03:00
Matthew Chen
59c227b50c Change section spacing in conversation settings view. 2020-04-16 09:07:04 -03:00
Matthew Chen
9fa036f3e6 Change background color of conversation settings view. 2020-04-16 09:07:04 -03:00
Matthew Chen
6e79c0232c Update "view all members" item appearance. 2020-04-16 09:07:04 -03:00
Matthew Chen
273998f1f4 Tweak circle icon layout. 2020-04-16 09:07:04 -03:00
Matthew Chen
df0e2c8588 Tweak nav bar in conversation settings view. 2020-04-16 09:07:04 -03:00
Matthew Chen
2db9e759b7 Always enable "pending members" item in conversation settings view. 2020-04-16 09:07:04 -03:00
Matthew Chen
1b25b81898 Fix "missing name" errors in group creation. 2020-04-16 09:07:04 -03:00
Matthew Chen
7b5e78c8e8 More design changes. 2020-04-16 09:07:04 -03:00
Matthew Chen
aa53773e84 Merge branch 'release/3.8.0' 2020-04-15 17:41:19 -03:00
Matthew Chen
a4d802a2a2 Avoid rate limits while doing profile fetches. 2020-04-15 17:03:33 -03:00
Matthew Chen
d57cb36ace Merge remote-tracking branch 'private/release/3.8.0' 2020-04-15 10:08:56 -03:00
Nora Trapp
a192973a1b Update PINs copy 2020-04-14 17:33:43 -03:00
Matthew Chen
70889edb62 Group v2 design refinements. 2020-04-14 10:24:43 -03:00
Matthew Chen
7579741ada Group v2 design refinements. 2020-04-14 10:24:43 -03:00
Matthew Chen
856fef7664 Aggressively enable groups v2 support in member picking views. 2020-04-13 17:24:59 -03:00
Matthew Chen
9d604fef45 Merge remote-tracking branch 'private/release/3.8.0' 2020-04-13 15:12:51 -03:00
Matthew Chen
3d68785f4a Add a indicator of profile key status in the conversation settings view header. 2020-04-13 10:31:36 -03:00
Matthew Chen
5e6566db3e Enforce max group member count. 2020-04-13 10:23:20 -03:00
Matthew Chen
b4aa6b5197 Enforce max group member count. 2020-04-13 10:23:20 -03:00
Matthew Chen
b799d1d311 Fix more build warnings. 2020-04-10 13:17:08 -03:00
Matthew Chen
7246c613d5 Fix more build warnings. 2020-04-10 13:17:08 -03:00
Nora Trapp
1ca670f52a Link to localized support articles 2020-04-09 16:41:28 -03:00
Matthew Chen
fe18cd1596 Fix build warnings around initializers. 2020-04-08 16:05:54 -03:00
Matthew Chen
b42f1968cc Fix build warnings around initializers. 2020-04-08 16:05:54 -03:00
Matthew Chen
4ea5edf968 Add "replace admin" flow. 2020-04-08 09:26:25 -03:00
Matthew Chen
ef53148b33 Add "replace admin" flow. 2020-04-08 09:26:25 -03:00
Matthew Chen
b5c069ed95 Clean up VC initializers. 2020-04-08 09:26:25 -03:00
Matthew Chen
af7eefc0fd Update copy for groups v2 attributes access. 2020-04-07 13:48:45 -03:00
Matthew Chen
0ebed2cb22 Update block/leave actions in new conversation settings view. 2020-04-07 13:32:55 -03:00
Matthew Chen
62ce60656a Always show DM controls in the conversation settings UI. 2020-04-07 13:32:13 -03:00
Matthew Chen
c7df10eb36 Apply CGSize(square:). 2020-04-06 11:34:21 -03:00
Matthew Chen
3352653b76 Update icon appearance in convo settings view's add members button. 2020-04-06 11:23:35 -03:00
Matthew Chen
8859870af1 Add UI for groups v2 invites. 2020-04-06 11:09:06 -03:00
Matthew Chen
44bb118183 Enable group member actions in conversation view. 2020-04-06 11:01:09 -03:00
Matthew Chen
d8a6334f5e Overhaul "create new group" and "add group member" views.
* Move "new group" button.
* Overhaul new group view header.
* Add 'new group confirm' view.
* Add the new "add group members" view.
2020-04-06 09:54:49 -03:00
Matthew Chen
973a7c52e6 Respond to CR. 2020-04-02 14:42:17 -03:00
Matthew Chen
ac581b4ef7 Refine conversation settings view. 2020-04-02 13:55:11 -03:00
Matthew Chen
6069373130 Add "edit group attributes access" alert. 2020-04-02 13:52:16 -03:00
Matthew Chen
b010395b3e Respond to CR. 2020-04-02 13:30:01 -03:00
Matthew Chen
aee8f18508 Rework conversation settings view.
Add group attributes view controller.
2020-04-02 13:18:55 -03:00
Matthew Chen
a545d08b24 Convert conversation settings view to Swift. 2020-04-02 13:11:53 -03:00
Matthew Chen
b0ce68c2d3 Convert conversation settings view to Swift. 2020-04-02 13:11:53 -03:00
Matthew Chen
25bdbf545f Convert conversation settings view to Swift. 2020-04-02 13:11:53 -03:00
Matthew Chen
94d4ff7dff Convert conversation settings view to Swift. 2020-04-02 13:11:53 -03:00
Nora Trapp
109a28f440 Add cancel button to add to contacts action sheet 2020-03-30 13:16:02 -07:00
Nora Trapp
57dcff6b60 Don't show the group management section if it's empty 2020-03-30 13:16:02 -07:00
Matthew Chen
e097239dcd Sketch out revised "new group" view. 2020-03-17 10:31:20 -03:00
Michael Kirk
f3420ea302 consolidate group settings permission checks 2020-03-09 14:05:50 -06:00
Matthew Chen
547f89e51e Merge tag '3.6.1.4' 2020-03-06 10:49:28 -03:00
Nora Trapp
4ad7479ff9 Use new accent blue color everywhere except launch screen related views 2020-03-04 10:00:55 -08:00
Matthew Chen
17356e079a Fix dm duration slider interaction. 2020-03-04 12:35:24 -03:00
Matthew Chen
100fcd2572 Merge tag '3.6.1.0' 2020-03-04 10:32:39 -03:00
Matthew Chen
a5d58e5a0e Improve logging around spurious timeouts. 2020-03-03 17:39:53 -03:00
Matthew Chen
08cf2fe8b2 Respond to CR. 2020-03-03 17:32:02 -03:00
Matthew Chen
a24115d391 Resolve groups v2-related TODOs. 2020-03-03 17:11:04 -03:00
Matthew Chen
dc509505f1 Fix 'share my profile' in conversation settings view. 2020-03-03 13:56:21 -03:00
Matthew Chen
5e8b4d2077 Clean up handling of networking errors. 2020-03-03 12:32:50 -03:00
Matthew Chen
f31b29c89d Reconcile message request changes from v3.5 with master. 2020-03-02 15:45:46 -03:00
Matthew Chen
20aeb8df44 Merge remote-tracking branch 'private/release/3.6.0' 2020-03-02 13:39:20 -03:00
Matthew Chen
ec5eb34669 Leverage v2 group model. 2020-02-28 16:26:55 -03:00
Matthew Chen
caa101beab Merge remote-tracking branch 'private/release/3.5.0' into release/3.6.0 2020-02-27 13:52:43 -03:00
Matthew Chen
f2240376c8 Rework groups v2 debug flags. 2020-02-26 23:23:40 -03:00
Matthew Chen
fd4780d82d Add timeouts to v2 group updates; surface network errors to user. 2020-02-26 16:56:37 -03:00
Nora Trapp
a360291deb Always quit the group when blocking a thread. 2020-02-25 12:47:03 -07:00
Matthew Chen
c572db4886 Add TSGroupModelBuilder. 2020-02-24 16:44:48 -03:00
Matthew Chen
17b9420c7f Clean up ahead of PR. 2020-02-21 13:12:40 -03:00
Matthew Chen
7dce8a3d2f Improve support for v2 groups in update group view. 2020-02-21 13:12:40 -03:00
Matthew Chen
e3fd515abe Add local prefix to a few more GroupManager methods. 2020-02-21 12:37:33 -03:00
Matthew Chen
9ce3a42f74 Rename GroupManager methods. 2020-02-21 12:31:45 -03:00
Matthew Chen
dec0176eb3 Overhaul message request view.
* Fix input toolbar visibility after accepting group v2 invite.
2020-02-21 10:55:40 -03:00
Michael Kirk
f198d9037d Merge tag '3.5.0.5' 2020-02-19 19:26:05 -07:00
Nora Trapp
aad98e866e Hide profile share status / button in conversation settings. 2020-02-17 16:11:05 -07:00
Michael Kirk
7eefc55975 disable key conversation settings while pending message request exists 2020-02-15 11:37:24 -07:00
Nora Trapp
e420b2194c If there's a pending message request and we send a message to a thread, share our profile 2020-02-15 11:37:24 -07:00
Matthew Chen
cf7681b346 Fix group v2 update edge cases around missing signatures and group access. 2020-02-13 10:19:11 -03:00
Matthew Chen
174ab60e66 Fix handling of access control in protos; improve debug descriptions; clean up. 2020-02-13 10:15:42 -03:00
Michael Kirk
4f5e52d578 remove conversation search feature flag 2020-02-12 15:19:55 -07:00
Nora Trapp
70d948843f Remote FF for message requests 2020-02-11 18:27:46 -08:00
Matthew Chen
d057936e28 Use TSGroupMemberRole in group membership. 2020-02-11 11:41:32 -03:00
Matthew Chen
a36bdab4c5 Overhaul group model, group membership. 2020-02-11 11:41:31 -03:00
Matthew Chen
c95f230e8d Profiles vs. Groups v2
* Update profile whitelist to reflect v2 group membership.
* Fill in missing profile keys from group change protos.
* Ensure local profile has commitment before doing any v2 group requests.
* Fix "ensure local profile key credential" bug.
* Fix profile key parsing from group v2 member protos.
* Fix edge case around members missing uuids in temporary update group view.
2020-02-06 11:50:15 -03:00
Matthew Chen
647fb3a33f Rework "leave group", consolidate group update logic. Add groups v2 indicator. 2020-02-06 11:11:22 -03:00
Matthew Chen
e4a81a7e25 Respond to CR. 2020-02-06 11:04:32 -03:00
Matthew Chen
fb2d4b1744 Use Groups v2 to coordinate disappearing message state. 2020-02-06 10:50:45 -03:00
Matthew Chen
17f32b1fbe Respond to CR. 2020-02-06 10:26:02 -03:00
Matthew Chen
149ead416c Clean up ahead of PR. 2020-02-06 10:26:02 -03:00
Matthew Chen
64f47e9d7a Sketch out handling of pending members. 2020-02-06 10:26:02 -03:00
Michael Kirk
83d26fe62e revamp group updates - show source, show changes, show icon 2020-01-30 20:10:55 -08:00
Michael Kirk
8a25781400 clarify delegate method 2020-01-30 20:10:55 -08:00
Matthew Chen
e328ccd0ef Apply v2 group changes to group model. 2020-01-27 11:47:44 -03:00
Matthew Chen
91d100c792 Rework group updates; rework "update group" view to use GroupManager.
* Introduce GroupMembership & GroupAccess.
* Pull out GroupsV2Test.
* Fix issues in groups v2 logic.
2020-01-27 11:18:21 -03:00
Michael Kirk
61ec8612ee revamp group updates - show source, show changes, show icon 2020-01-23 11:55:48 -07:00
Michael Kirk
0a2ec74e8d clarify delegate method 2020-01-23 11:55:48 -07:00
Michael Kirk
0dfccd2749 avoid compiler warning, mark protocol conformance 2020-01-17 16:09:33 -07:00
Matthew Chen
1ae6012ecb Create and fetch groups v2; group update roundtrip. 2020-01-17 17:29:00 -03:00
Matthew Chen
976fd5dfb8 Cache user profiles and signal accounts. 2020-01-16 16:52:25 -03:00
Matthew Chen
72f912dce3 Versioned profile changes, etc. 2020-01-08 13:54:54 -03:00
Matthew Chen
29150102cb Revert group and profile changes. 2019-12-11 20:41:54 -08:00
Nora Trapp
c667ef54f2 Merge branch 'release/3.0.4' 2019-12-05 16:45:59 -08:00
Nora Trapp
d2cb2b6637 Fix share sheet for iPad 2019-12-05 16:27:45 -08:00
Michael Kirk
17dd01c266 fix janky animation when table resizes due to pinning to keyboard 2019-12-05 14:05:33 -07:00
Matthew Chen
3d88f68cfb Rework new group new creation & group updates. 2019-12-04 15:40:54 -03:00
Matthew Chen
b38a64cce8 Revert "Revert "Merge branch 'charlesmchen/groupManager2'""
This reverts commit 7530dee591.
2019-11-12 09:02:52 -03:00
Matthew Chen
7530dee591 Revert "Merge branch 'charlesmchen/groupManager2'"
This reverts commit 26fd0d0812, reversing
changes made to c17865b750.
2019-11-11 20:01:45 -03:00
Matthew Chen
5e5aa2368b Apply group manager in tests. 2019-11-11 17:31:21 -03:00
Nora Trapp
9df379ab5c Dismiss -> Cancel 2019-11-08 19:09:54 -08:00
Matthew Chen
f97b33ffaa Add GroupManager. 2019-11-07 15:03:42 -03:00
Michael Kirk
61fb6e575e remove block from overwriting update, undeprecate upsert 2019-11-04 14:06:54 -08:00
Michael Kirk
7faf75c6d7 CR: add debug assert 2019-11-04 14:06:54 -08:00
Michael Kirk
0fca274e62 Sync Groups and Contacts 2019-11-04 14:06:54 -08:00
Nora Trapp
b6a8e5685f Restrict all paths to calling on linked devices. 2019-10-28 14:49:10 -07:00
Nora Trapp
d8aecdb1ed PR Feedback. 2019-10-28 14:44:24 -07:00
Nora Trapp
90139acf67 New member action sheet for groups 2019-10-28 14:44:24 -07:00
Nora Trapp
65d54e7282 UIAlertController -> ActionSheetController 2019-10-28 14:43:59 -07:00
Nora Trapp
c107125dcf Show contact views with a push 2019-10-23 13:47:21 -07:00
Nora Trapp
9024f2f244 Re-work all media view to support iPad 2019-10-17 12:30:37 -07:00
Nora Trapp
473b88b497 Don't require ConversationViewController to maintain first responder status. 2019-10-17 11:41:58 -07:00
Michael Kirk
586d32c0f1 consolidate add-to-contacts into a single cell behind action sheet 2019-10-10 13:20:17 -07:00
Michael Kirk
15c7d3ccc6 update icons for profile/contacts 2019-10-10 13:12:10 -07:00
Nora Trapp
18d345ec06 PR Feedback 2019-10-08 20:10:02 -07:00
Nora Trapp
b552059c2a Present various modals as form sheets. 2019-10-08 20:10:02 -07:00
Nora Trapp
baf8950efb Support all orientations on iPad 2019-10-03 11:55:03 -07:00
Matthew Chen
d8f99ab026 Merge remote-tracking branch 'private/release/2.44.0' 2019-09-27 17:10:34 -03:00
Matthew Chen
20683678b5 Store group avatars as data. 2019-09-27 16:25:53 -03:00
Michael Kirk
95f2d511e1 font updates 2019-09-26 12:20:42 -07:00
Michael Kirk
822d33f1d5 new icons: conversation settings 2019-09-25 14:49:26 -07:00
Michael Kirk
54812451f4 Update and apply palette. Consolidate dupes. 2019-09-24 15:12:51 -07:00
Michael Kirk
f63a64243a convert colors to Swift 2019-09-24 15:12:50 -07:00
Matthew Chen
6a529e792d Rework message configuration. Simplify change detection, ensure continuity for deleted threads. 2019-09-13 20:40:06 -03:00
Matthew Chen
3730b0419b Respond to CR. 2019-09-04 09:49:29 -03:00
Matthew Chen
bcd58bd538 Simplify disappearing messages configuration. 2019-09-04 09:43:59 -03:00
Nora Trapp
129535f2d7 Merge branch 'release/2.42.0' 2019-08-29 15:21:40 -07:00
Nora Trapp
b45516839f Restore old ~profile display 2019-08-29 10:18:12 -07:00
Matthew Chen
a5efaf8d16 Merge remote-tracking branch 'private/release/2.42.0' 2019-08-28 11:33:26 -03:00
Matthew Chen
cd88f4f012 Address sticky keyboards on iOS 12. 2019-08-27 14:50:29 -03:00
Michael Kirk
45c4066a80 Fix deadlock with thread.name
For contact threads, thread.name opened a sneaky transaction, which would
sometimes cause a deadlock.

This commit moves the name method to the contact manager and offers an explicit
transaction flavor. There is still a sneaky transaction flavor used in some
places where it's deemed dangerous to plumb through a transaction without
further scrutiny.
2019-08-23 18:45:23 -06:00
Nora Trapp
64a90575ef Label current group members in the edit group flow 2019-08-22 09:27:36 -07:00
Nora Trapp
07ed67f943 Cleanup some unused classes 2019-08-22 09:27:36 -07:00
Nora Trapp
2d566ae029 Allow adding usernames to existing groups. 2019-08-22 09:27:36 -07:00