* add deserialization test for MessageBodyRanges
* Add style ranges to MessageBodyText
* add deserialization tests and fix small other test
* add basic mention hydration tests
* Add RTL support for @mention hydration
* Add a test with accents for unicode shenanigans
* unique-ify TODOs
* Add emoji test and fix implementation to account for multi-point unicode that is captured in NSString.length but not String.count
* Add more TODOs for text formatting
* Collapse style ranges on init
* Handle mention overlaps on MessageBodyRanges init
* add tests, update existing tests, fix bugs
* Update v2 deserialization test; the meaning of Style raw values has changed
* comment nit
* Don't fail debug builds after locking the account and failing config lookup
* Show (no-op) notification when deregistered
* Show re-registration when tapping the push notification
* Remove asserts that can (and should) fail when deregistered
* run genstrings
* Mark previous call events read when a later call event is responded to
* Clear missed call notifications when a future call is actioned on any device
* Do two queries for TSCall updates
We ask users for contact and notification permissions during
registration.
If the user abandons registration after approving or denying these
requests, we don't need to show them the permissions screen again, as
it'll just show an "Allow Permissions" button that advances to the next
screen.
This also cleans up some of the methods. Not strictly related, but it
felt like a good time to rename some methods and clean up some logging
(especially because we're making changes here).
We've been presenting all safety number mismatches as "someone joined
the call you were already in", but sometimes they were in the call
first. In that case, we should use a different message.
While here, make these messages a little more concise so we can fit in
an explicit "Tap to view", to encourage people to come back to the app
and decide whether they want to stay in the call.
This adds a table of "cancelled group rings", to handle out-of-order
delivery between a cancellation and a ring. (This can happen when the
cancellation comes from a linked device rather than the original
ringer, though it's very unlikely.) Thirty-minute-old cancellations
are cleared lazily.
This also adds a new IncomingCallControls to replace the usual
CallControls in a GroupCallViewController.
And finally, there's a lot of code that was 1:1-call-specific that now
handles group calls as well, either by being more general or by
checking which kind of call we have.
Change license to AGPL
This commit:
- Updates the `LICENSE` file
- Start every file with something like:
// Copyright YEAR_FIRST_PUBLISHED Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
---
First, I removed existing license headers with this Ruby 3.1.2 script:
require 'set'
EXTENSIONS_TO_CHECK = Set['.h', '.hpp', '.cpp', '.m', '.mm', '.pch', '.swift']
same = 0
different = 0
all_files = `git ls-files`.lines.map { |line| line.strip }
all_files.each do |relative_path|
if relative_path == 'Pods'
next
end
unless EXTENSIONS_TO_CHECK.include? File.extname(relative_path)
next
end
path = File.expand_path(relative_path)
contents = File.read(path)
new_contents = contents.sub(/\/\/\n\/\/ Copyright .*\n\/\/\n\n/, '')
if contents == new_contents
same += 1
else
different += 1
end
File.write(path, new_contents)
end
puts "updated #{different} file(s), left #{same} untouched"
I'm sure this script could be improved, but it worked well enough.
Then, I created `Scripts/lint/lint-license-headers` and ran it to auto-
fix a lot of files. This changed the mode of some files, but I think
that's actually desirable. For example,
`SignalServiceKit/src/Util/AppContext.m` previously had a mode of
`0755/-rwxr-xr-x`, and it's now `0644/-rw-r--r--`.
Then I fixed some stragglers and updated the precommit script.
See [a similar change in the Desktop app][0].
[0]: 8bfaf598af
For certain kinds of notifications, we attach "intents" to let the
system know who's contacting us (for use in, say, share sheet
suggestions; controlled by Settings > Chats > Share Contacts with
iOS). Previously we only provided "rich" intents on iOS 15 and a
minimal implementation for iOS 13, but even if iOS 13 won't do as much
with the information we can be more consistent.