signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
6,612 Commits 1 Branch 2,246 Tags 1.8 GiB
c88ce07f66
Commit Graph

704 Commits

Author SHA1 Message Date
Michael Kirk
c88ce07f66 CR: Clean up comments, use property setter instead of ivar 
// FREEBIE
 2018-04-18 15:32:01 -04:00
Michael Kirk
eb140a6839 Timer info messages *before* the message which changed the timer 
// FREEBIE
 2018-04-18 15:32:01 -04:00
Michael Kirk
a9e7c5e879 Cleanup: simplify migration, remove unused code 
// FREEBIE
 2018-04-18 15:32:01 -04:00
Michael Kirk
754549adf1 Start timer for expiring message based on when read receipt was sent 
// FREEBIE
 2018-04-18 15:32:01 -04:00
Michael Kirk
dfb2a034af Use explicit transactions. 
- Start expiration within scope of existing transaction when we're
  already in a transaction

// FREEBIE
 2018-04-18 15:32:01 -04:00
Michael Kirk
b7625689cb Simplify reasoning around disappearing messages 
1. Max duration between runs is now a separate timer we set up once and
   don't touch, so we can separate any potential bugs in scheduling logic.
2. When we want to "run now" we just run now, rather than going through
   the scheduler.
3. Detect if messages aren't being deleted in a timely way.

// FREEBIE
 2018-04-18 15:32:01 -04:00
Michael Kirk
57ae2b173f Clarify existing functionality, but no change in behavior 
rename vars
use clearer date comparison method

// FREEBIE
 2018-04-18 15:32:01 -04:00
Matthew Chen
eb51ea42e3 Merge remote-tracking branch 'origin/hotfix/2.23.4' 2018-04-16 17:46:24 -04:00
Michael Kirk
66f028a3b3 Update nullability 
If object is nil, which it can be, Swift freaks out, since we'd promised
it would never be nil.

// FREEBIE
 2018-04-16 17:31:23 -04:00
Matthew Chen
85cb78ddfe Add mainWindow property to app context. 2018-04-16 17:31:00 -04:00
Matthew Chen
5ce39337ed Handle malformed protos. 2018-04-16 16:15:46 -04:00
Michael Kirk
c926ca10a5 Update nullability 
If object is nil, which it can be, Swift freaks out, since we'd promised
it would never be nil.

// FREEBIE
 2018-04-16 16:08:31 -04:00
Matthew Chen
9c93099515 Fix incomplete asserts. 2018-04-13 15:01:25 -04:00
Matthew Chen
6caa5b87b6 Add more asserts around thread in SAE. 2018-04-13 14:59:38 -04:00
Michael Kirk
e554884ab3 Use profile name in quoted messages, fix "multi account" label 
// FREEBIE
 2018-04-13 09:53:31 -04:00
Matthew Chen
829cfd0428 Reduce oversize text size. 2018-04-11 17:57:53 -04:00
Matthew Chen
45892e822b Move 'background' check in message processing logic off main thread. 2018-04-11 15:30:31 -04:00
Michael Kirk
b2b70258f2 Make our protos backwards compatible with Signal-Android 
Android doesn't have a flags field (yet?). We should make sure our
existing fields align with theirs.

// FREEBIE
 2018-04-11 15:16:23 -04:00
Michael Kirk
bd8e03fe8a Fix spurious "Group Updated" message 
Regression introduced in Message factory method refactor (not in the wild).

// FREEBIE
 2018-04-11 15:15:54 -04:00
Matthew Chen
d95f2bdc66 Respond to CR. 2018-04-11 14:45:27 -04:00
Matthew Chen
d561ba4c62 Reduce 0xdead10cc crashes. 2018-04-11 14:44:03 -04:00
Matthew Chen
db6f1326bb Fix previews of oversize text messages. 2018-04-11 13:51:12 -04:00
Matthew Chen
83a470d441 Fix previews of oversize text messages. 2018-04-11 13:51:12 -04:00
Matthew Chen
abba24988c Rework how dates are formatted in home view. 2018-04-11 09:34:37 -04:00
Michael Kirk
d94709e13f Show label when captioning limit has been reached. 
// FREEBIE
 2018-04-10 16:00:19 -04:00
Michael Kirk
6b6f4f9336 Limit caption length 
// FREEBIE
 2018-04-10 16:00:19 -04:00
Matthew Chen
c269add62f Respond to CR. 2018-04-10 15:58:08 -04:00
Matthew Chen
76995e4594 Enforce quoted reply edge cases. 2018-04-10 15:56:55 -04:00
Matthew Chen
6a07599e00 Respond to CR. 2018-04-10 15:54:46 -04:00
Matthew Chen
65015e686f Tap on quoted replies. 2018-04-10 15:54:46 -04:00
Michael Kirk
81b2b57703 CR: add comments, make atomic 
// FREEBIE
 2018-04-09 12:47:57 -04:00
Michael Kirk
88d6a83954 Add assertion canary so we know to re-test syncing once desktop 
supports sending quoted replies

// FREEBIE
 2018-04-09 12:47:57 -04:00
Michael Kirk
02efbd3069 Fix blip where thumbnail is initially missing from outgoing message 
// FREEBIE
 2018-04-09 12:47:57 -04:00
Michael Kirk
90486aa49c Inline method with one caller, fix formatting 
// FREEBIE
 2018-04-09 12:47:57 -04:00
Michael Kirk
8e4c6b8af6 Update protos for voice messages 
// FREEBIE
 2018-04-09 12:47:57 -04:00
Michael Kirk
941b7ec1bc clarify method signature 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
c56e8acc51 QuotedReplyModel from SSK->SignalMessaging 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
1d4c0624be Clarify variable names 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
a9459757f0 Lingering var renames QuotedReplyDraft -> QuotedReplyModel 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
f1714bf252 Handle synced quotes 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
622f6bdf21 OrphanDataCleaner vs. QuotedAttachment thumbnails 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
4399967e99 Comment cleanup, remove unnecessary includes 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
fa2e1ba89b Fetch thumbnail when not available locally 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
42f454b075 Generate thumbnail when quoted attachment is available locally 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
351f9ea263 Simplify attachment processor 
We've accepted all attachment types for a long while now.

// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
3252866727 remove unused params 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
cb5d3d4f85 Use QuotedReplyModel to access attachment data 
This view model loads the attachment when it's build.

// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
3334f2a063 tentative proto changes 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
51a4298c14 WIP: Send attachment info in protobuf (no thumbnails yet) 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
55c6d99d98 populate draft toolbar 
// FREEBIE
 2018-04-09 12:47:56 -04:00