Commit Graph

109 Commits

Author SHA1 Message Date
Michael Kirk
1544f8db46 Optionally show UD status in message details 2018-10-11 09:04:35 -06:00
Michael Kirk
221ce513f1 extract dependencies, no change in behavior 2018-10-11 09:02:49 -06:00
Michael Kirk
06eae47e09 ConversationViewItem -> protocol 2018-09-28 12:58:33 -06:00
Matthew Chen
ebae75af00 Revert 'new sort id'. 2018-09-27 19:40:51 -04:00
Michael Kirk
3240e0d9d0 Be explicit about receivedAt time
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.

In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
2018-09-26 09:52:34 -06:00
Michael Kirk
ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
2018-09-26 09:52:33 -06:00
Matthew Chen
cc117b385c Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:59 -04:00
Matthew Chen
3a12446be8 Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:41 -04:00
Matthew Chen
f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 2018-09-07 15:27:50 -04:00
Matthew Chen
8748dc9b2e Modify new thumbnail system to include video and GIF thumbnails. 2018-09-06 15:30:00 -04:00
Matthew Chen
498828f93c Rename AttachmentStream methods. 2018-09-06 15:30:00 -04:00
Matthew Chen
5b50e81b4f Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
Matthew Chen
7be8f30877 Apply -> Never. 2018-08-27 10:21:03 -04:00
Matthew Chen
cf6f3841a8 Apply new Swift logging. 2018-08-27 10:02:28 -04:00
Michael Kirk
82e559d11b Use swift macros for main thread assert 2018-08-23 10:29:49 -06:00
Matthew Chen
b75bc27d55 Respond to CR. 2018-08-22 16:37:01 -04:00
Matthew Chen
c6132249e6 Respond to CR. 2018-08-22 16:32:44 -04:00
Matthew Chen
4ea5d9b849 Theme review. 2018-08-16 17:30:07 -04:00
Matthew Chen
be7482eb60 Tap to copy sender timestamp to clipboard. 2018-08-16 16:36:01 -04:00
Matthew Chen
4e276b1095 Apply 'insets fix' correctly in message details view. 2018-08-15 15:44:13 -04:00
Matthew Chen
9fefce94a2 Refine theme. 2018-08-08 15:04:23 -04:00
Jesse Squires
6dc74ddcaf Fix some project warnings + other fixes
- Prefer checking `.isEmpty` rather than `.count == 0` for Swift collections (can be more optimal)
- Avoid comparing `BOOL` explicitly to `NO` (considered bad practice since `BOOL` is a `signed char`)
- Specify unused `SGX_FLAGS` as `__unused` to silence warnings
2018-07-31 09:48:58 -06:00
Michael Kirk
9df6b4bb78 Fix "contact cell too close to edge" in detail view (iOS9/iOS10)
Don't mix concepts of left/right with leading/trailing.
2018-07-16 10:20:05 -06:00
Matthew Chen
c460ff2945 Fix contact cell layout. 2018-07-05 17:36:53 -04:00
Michael Kirk
bd9696fede canary in case we change margins later 2018-07-03 10:16:41 -06:00
Michael Kirk
9108c89329 ContactView is now a stackView 2018-07-02 23:58:31 -06:00
Matthew Chen
1412998b4a Rework isRTL. 2018-07-02 15:27:24 -04:00
Michael Kirk
4f94d5c5a9 default value 2018-06-30 07:07:42 -06:00
Matthew Chen
cbc80abff1 Tweak color palette. 2018-06-28 13:18:35 -04:00
Matthew Chen
33b1628c26 Rename to ConversationStyle. 2018-06-26 10:20:26 -04:00
Matthew Chen
e3a13dfd9e Respond to CR. 2018-06-25 15:03:53 -04:00
Matthew Chen
a9b6fe5978 Respond to CR. 2018-06-25 15:00:45 -04:00
Matthew Chen
fdd6174871 Fix breakage from cell layout changes. 2018-06-25 14:41:14 -04:00
Matthew Chen
7847db7e1c Tweak text insets to reflect dynamic type. 2018-06-25 13:51:28 -04:00
Matthew Chen
d40f74dd0b Respond to CR. 2018-06-25 12:43:25 -04:00
Matthew Chen
196d82c17a Respond to CR. 2018-06-25 09:42:18 -04:00
Matthew Chen
ac6f78a5fc Tweak message cells. 2018-06-25 09:26:41 -04:00
Matthew Chen
2ecbf1bb65 Fix 'contact cell vs. message details layout' issue. 2018-06-21 17:16:50 -06:00
Matthew Chen
1a57fe631c Fix 'contact cell vs. message details layout' issue. 2018-06-21 17:16:50 -06:00
Matthew Chen
dd49c6225f Auto-size contact cells everywhere. 2018-06-15 10:01:16 -04:00
Matthew Chen
f63d25a172 Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen
28f7142a59 Auto-migration to Swift 4. 2018-05-30 15:05:02 -04:00
Michael Kirk
117d7319d2 Add contact modally and restore navbar style when dismssing contacts
// FREEBIE
2018-05-14 18:40:56 -04:00
Michael Kirk
704a6f55a0 Fix crash after canceling "Add New Contact"
Text of the exception is:
  "Impossible to set up layout with view hierarchy unprepared for constraint"

Since their container view is pinned to the top layout guide, this
should not change the layout.

// FREEBIE
2018-05-14 14:03:25 -04:00
Michael Kirk
609746abec clarify naming
// FREEBIE
2018-05-10 11:31:22 -04:00
Michael Kirk
42109593af Remove fromViewController state from ContactShareViewHelper
// FREEBIE
2018-05-09 10:21:00 -04:00
Michael Kirk
77bbbad70c Remove contactShare state from ContactShareViewHelper
// FREEBIE
2018-05-09 10:21:00 -04:00
Matthew Chen
c2adf624ea Respond to CR. 2018-05-08 17:22:34 -04:00
Matthew Chen
44ceee5849 Add contact share actions to conversation view and improve phone number parsing. 2018-05-08 17:22:34 -04:00
Michael Kirk
5ba5e98260 Show downloaded contact avatar in thread
// FREEBIE
2018-05-07 12:08:41 -04:00