Michelle Linington
7d256bbab6
Some last bits of PR feedback
2020-08-13 15:53:31 -07:00
Michelle Linington
5da0078bbe
Run precommit script
2020-08-13 15:08:12 -07:00
Michelle Linington
d76b9f9f9a
PR feedback
2020-08-13 15:08:12 -07:00
Michelle Linington
8e4fd443cc
Adopt new CDS errors in LegacyContactDiscoveryService
...
Also, made some changes for better error handling in
ContactDiscoveryTask clients
2020-08-13 15:08:12 -07:00
Michelle Linington
cd26048e43
Add tests for ContactDiscoveryTask.RateLimiter
2020-08-13 15:08:12 -07:00
Michelle Linington
3bc0fb03ba
Make ContactDiscoveryError an NSError subclass
...
Also, changes how ContactDiscoveryTask is used by callers. Now, callers
check the provided error's retry after to determine when to schedule the
next attempt.
(Except OWSMessageSender for now)
2020-08-13 15:08:05 -07:00
Michelle Linington
18ce525c2e
Add some tests to exercise date parsing
...
Date+SSKTest has a suite of tests that checks parsing of HTTP and
IOS8601 dates directly
NSURLSessionDataTask+OWS_HTTPTest validates that the Retry-After parsing
of NSHTTPURLResponse works as expected
Also, this change renames the NSURLSessionDataTask extension header to
something more generally appropriate
2020-08-13 14:40:22 -07:00
Michelle Linington
49f82ed6da
IOS-711: Re-expose existing rate-limit errors in modern CDS
...
This change adds retry-after header parsing.
ModernContactDiscoveryOperations will now parse any httpStatusCodes from
errors it hits and return build an appropriate ContactDiscoveryError in
response.
2020-08-13 14:40:16 -07:00
Nora Trapp
64178b6ea2
Allow receiving link previews from non-whitelisted domains
2020-08-13 13:40:24 -07:00
Matthew Chen
0a3410efb4
Add remote config flag for attachmentUploadV3.
2020-08-13 12:48:12 -03:00
Matthew Chen
e536d529d4
Feature flags for .qa.
2020-08-13 11:48:34 -03:00
Matthew Chen
f827128185
Feature flags for .beta.
2020-08-13 11:48:11 -03:00
Nora Trapp
cbaaf90fb2
Add mentions megaphone
2020-08-13 10:58:28 -03:00
Nora Trapp
5388aa01b8
Use common run loop mode for some timers
2020-08-13 10:45:32 -03:00
Matthew Chen
5aa490a1fb
Respond to CR.
2020-08-13 10:07:45 -03:00
Matthew Chen
5bad03f96d
Add test UI around skipping unregistered users in message sends.
2020-08-13 09:11:15 -03:00
Matthew Chen
7d4ef1f8fe
Ignore users recently marked as unregistered by CDS in message sends.
2020-08-13 09:06:04 -03:00
Matthew Chen
590c89eba5
Ignore users recently marked as unregistered by CDS in message sends.
2020-08-13 09:06:04 -03:00
Matthew Chen
ae0f5e4a9d
Add performance test around UnfairLock.
2020-08-13 08:59:56 -03:00
Matthew Chen
6897884f7c
Convert ContactsViewHelper to singleton.
2020-08-11 17:51:41 -03:00
Matthew Chen
a13f34f068
Rework Groups v2 & CDS feature flags.
2020-08-11 17:45:04 -03:00
Matthew Chen
641e2e5bc9
Enable gv2 support.
2020-08-11 17:45:04 -03:00
Matthew Chen
b6f07d471f
Rework Groups v2 & CDS feature flags.
2020-08-11 17:45:04 -03:00
Matthew Chen
fdd3c513ca
Rework Groups v2 & CDS feature flags.
2020-08-11 17:45:04 -03:00
Matthew Chen
e2c2f37e60
Respond to CR.
2020-08-11 17:25:47 -03:00
Matthew Chen
4fab1f7e09
Fix issue in address' Codable impl.
2020-08-11 16:44:32 -03:00
Matthew Chen
b85cc48017
Add unit test around address mapping changes.
2020-08-11 16:44:32 -03:00
Matthew Chen
9e62160abe
Fix perf problems around observation of addressing mapping changes.
2020-08-11 16:44:32 -03:00
Matthew Chen
88f17077f6
Update remote config custom flag name.
2020-08-11 13:56:16 -03:00
Michelle Linington
2773e28561
Run precommit linter
2020-08-10 18:47:58 -07:00
Michelle Linington
41e95f2447
Fixup from rebase
2020-08-10 18:47:58 -07:00
Michelle Linington
8372df787d
Migrate modernContactDiscovery from featureflag to remoteflag
...
This changes up some of the logic around how we determine whether or not
to enable modern contact discovery
2020-08-10 18:47:58 -07:00
Michelle Linington
8211c73459
IOS-716: Introduce remote feature flag for modern CDS
...
Adds a new RemoteConfig flag to enable modern contact discovery. The
rules are:
- FeatureFlags.modernContactDiscovery is a prerequisite
- RemoteConfig.modernContactDiscovery or
DebugFlags.forceModernContactDiscovery will enable modern CDS
2020-08-10 18:47:58 -07:00
Matthew Chen
eb6f43cf07
Rework maxGroupsV2MemberCount remote config flag.
2020-08-10 19:46:23 -03:00
Matthew Chen
4a1e6a07ea
Fix edge case in model read cache.
2020-08-10 17:33:33 -03:00
Matthew Chen
6c569b1cf2
Fix edge case in model read cache.
2020-08-10 17:28:42 -03:00
Matthew Chen
fbf18ae0dc
Refine UD edge case.
2020-08-10 17:25:58 -03:00
Matthew Chen
abc79b44e0
Avoid redundant writes.
2020-08-10 17:24:43 -03:00
Matthew Chen
0446dd5149
Improve UD manager perf.
2020-08-10 17:24:43 -03:00
Matthew Chen
ad6a46b3b3
Improve UD manager perf.
2020-08-10 17:24:43 -03:00
Matthew Chen
2b8ff7d8cb
Improve UD manager perf.
2020-08-10 17:24:43 -03:00
Matthew Chen
b4d5f29be1
Handle empty message bodies.
2020-08-10 11:48:23 -03:00
Matthew Chen
83e0f649ac
Respond to CR.
2020-08-10 11:47:37 -03:00
Matthew Chen
0808cbc3ce
Fix edge case around file cleanup.
2020-08-10 11:45:28 -03:00
Matthew Chen
1442e37363
Fix edge case around file cleanup.
2020-08-10 11:45:28 -03:00
Matthew Chen
4869517391
Respond to CR.
2020-08-10 11:42:53 -03:00
Matthew Chen
162eea5aa2
Tune frequency of UI database snapshot updates.
2020-08-10 11:38:36 -03:00
Matthew Chen
c4b16ebb1e
Add remove config flag for UUID-based safety numbers.
2020-08-07 17:53:38 -03:00
Matthew Chen
a6d832a5f5
Refine stale profile fetch.
2020-08-07 17:44:11 -03:00
Matthew Chen
9cdff9728d
Add Fair and Unfair atomics.
2020-08-07 17:42:05 -03:00