Commit Graph

8 Commits

Author SHA1 Message Date
Michelle Linington
c6004c9fc5 PR Feedback. Adopt similar behavior in AttachmentTextView 2020-12-10 14:23:30 -08:00
Michelle Linington
fea0215f05 IOS-838: ConversationInputTextView cursor adjustments don't behave properly
At the moment, when trying to drag the input/selection cursor(s) in
the ConverationInputTextView, as soon as you reach the top or bottom
edge of a draft with >4 lines, you'll immediately scroll to the very top
or the very bottom.

This is because we're currently overriding the default implementation of
setContentOffset:animated: to always perform the adjustment without
animation. We do this because we don't want the animated content offset
adjustment to interfere with the growing the bounds of the text view.
This can cause the text to overshoot the updated bounds pre-iOS 13.

But we only grow the text view in response to the text changing. So
instead of disabling all content offset animations, we can get away with
just disabling content offset animations while the text is changing.

So this commit:
- Sets a flag between -textViewShouldChange... and -textViewDidChange:
- On iOS 13 and later, we'll always respect the animate argument of
  setContentOffset:animated:
- Pre-iOS 13, we'll ignore the animate parameter if the flag is set
2020-12-10 14:23:30 -08:00
Nora Trapp
9e958ca972 PR Feedback 2020-09-23 15:04:48 -07:00
Fumiaki Yoshimatsu
7cae74e432 Increase the vertical insets of placeholders and text inputs to keep them vertically aligned when the system is set to use smaller font and it contains only a line of text. Fixes #4273 2020-09-23 14:54:23 -07:00
Nora Trapp
3ac8696da3 Delete mentions megaphone 2020-09-10 15:02:50 -07:00
Nora Trapp
cbaaf90fb2 Add mentions megaphone 2020-08-13 10:58:28 -03:00
Nora Trapp
9fc6c21374 Allow selection mentions using keyboard commands 2020-08-04 14:09:06 -07:00
Nora Trapp
ff17567a6b ConversationInputTextView subclasses MentionTextView 2020-07-27 14:30:52 -07:00