signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
10,407 Commits 1 Branch 2,246 Tags 1.8 GiB
7654d05417
Commit Graph

65 Commits

Author SHA1 Message Date
Michael Kirk
0ab326da92 Only show delete button on selected rail item 2019-01-09 12:27:15 -07:00
Matthew Chen
5e3de84fdc Add feature flag for image editor. 2019-01-07 08:48:18 -05:00
Matthew Chen
8aa68327e6 Add primitive color picker. 2019-01-03 18:03:47 -05:00
Matthew Chen
b24e8e4f81 Use autoreleasepool when rendering image editor output. 2019-01-03 18:01:45 -05:00
Matthew Chen
17c3ba0580 Image editor fixes. 2019-01-03 16:56:24 -05:00
Matthew Chen
03cbeb5fee Start working on crop. 2018-12-19 14:48:37 -05:00
Matthew Chen
9378ab2192 Add undo/redo buttons to image editor. 2018-12-19 14:45:20 -05:00
Matthew Chen
d1cf942f7e Respond to CR. 2018-12-18 10:53:41 -05:00
Matthew Chen
794241963e Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
da13dc1d2e Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
639dac4e26 Add stroke drawing to the image editor. 2018-12-18 10:53:41 -05:00
Matthew Chen
b0e0c6e8c2 Replace edited attachments when sending. 2018-12-18 10:53:41 -05:00
Matthew Chen
e2afe27f5e Add trivial test interaction to image editor. 2018-12-18 10:53:41 -05:00
Matthew Chen
0d81139be5 Debug scaffolding. 2018-12-18 10:53:41 -05:00
Matthew Chen
4752cb94f5 Add ImageEditorView. 2018-12-18 10:53:41 -05:00
Michael Kirk
858ba6ef37 fix missing video thumbnails in approval view 2018-12-10 10:05:28 -07:00
Michael Kirk
3e48ed105d keyboard is always dark in attachment approval 2018-12-10 10:04:01 -07:00
Michael Kirk
2f92995cd6 Add placeholder text to message input field 2018-12-10 10:04:01 -07:00
Michael Kirk
71ab5817eb fix captionview visibility 2018-11-28 21:23:31 -07:00
Michael Kirk
61758dcf05 Only show caption for multiple images 2018-11-27 15:39:45 -07:00
Michael Kirk
0ac8f13c0b remove redunant method, consolidate naming, adding array getter 2018-11-27 15:39:45 -07:00
Michael Kirk
6fdd5d1001 dont initializer pagerScrollView as sideEffect 2018-11-27 15:39:45 -07:00
Michael Kirk
9bcc6a6c57 show navbar for photo/album picker, not approval 2018-11-27 10:27:13 -07:00
Michael Kirk
26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 2018-11-26 14:11:13 -07:00
Michael Kirk
9317ee9c99 design comment 2018-11-26 12:57:50 -07:00
Michael Kirk
e3120a5b87 cleanup keyboard animation code 2018-11-26 12:52:05 -07:00
Michael Kirk
55807f9a4d iPhoneX compatible keyboard animations 2018-11-26 12:43:28 -07:00
Michael Kirk
279694e704 keyboard animation cleanup 2018-11-26 12:43:28 -07:00
Michael Kirk
0808458392 fix caption dismiss animation/placeholder for multiline message body 2018-11-26 12:43:28 -07:00
Michael Kirk
4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching 
firstResponder from CaptionView to AttachmentApprovalViewController.
 2018-11-26 12:43:28 -07:00
Michael Kirk
3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 2018-11-26 12:43:28 -07:00
Michael Kirk
b108f284bd WIP: hide caption keyboard 
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
 2018-11-26 12:43:28 -07:00
Michael Kirk
838012d1ec Caption length limit and label 2018-11-26 12:43:28 -07:00
Michael Kirk
e0f7513df0 white tint for attachment approval textview cursors 2018-11-26 12:43:28 -07:00
Michael Kirk
a946ec0056 new icon assets per design 2018-11-26 12:43:28 -07:00
Michael Kirk
8776dd1909 New "add caption" and "done" assets 2018-11-26 12:43:28 -07:00
Michael Kirk
feb5a0c444 fix initial CaptionView layout glitch 2018-11-26 12:43:28 -07:00
Michael Kirk
e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 2018-11-26 12:43:28 -07:00
Michael Kirk
33750baf67 finally got dismiss-before-swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
dd82803a10 second abandoned attempt to require dismiss before page 2018-11-26 12:43:28 -07:00
Michael Kirk
b98b3d1fdd WIP: require dismiss before swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
706dd3d0c1 initial layout of keyboard is correct across pages 2018-11-26 12:43:28 -07:00
Michael Kirk
280664c763 WIP: keyboard 2018-11-26 12:43:28 -07:00
Michael Kirk
eed2558050 Avoid glitch in keyboard dismiss. 
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
 2018-11-26 12:43:28 -07:00
Michael Kirk
8b5d1d9e69 Only add delete button once 2018-11-26 12:43:28 -07:00
Michael Kirk
28f8fc5911 per cr, avoid unnecessary 2018-11-26 12:37:58 -07:00
Michael Kirk
fcc4b516a5 fix typo in logging 2018-11-26 12:37:58 -07:00
Michael Kirk
4f0092615a Support captions *and* independent message body 2018-11-26 12:37:58 -07:00
Michael Kirk
cd88ef2bec CaptionView text field per page 2018-11-26 12:37:58 -07:00
Michael Kirk
79995cc52c rename captioning -> messageText 
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
 2018-11-26 12:37:58 -07:00