signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
28,563 Commits 1 Branch 2,246 Tags 1.8 GiB
70f4ab3fab
Commit Graph

70 Commits

Author SHA1 Message Date
Igor Solomennikov
70f4ab3fab [Media Editor] Do not wrap image editing tool VCs in a nav controller. 
Two VCs: photo editor and crop view don't need a UINavigationController
and are fine presented as is.

Also remove unused `completion` parameter.
 2022-07-07 15:38:25 -07:00
igor-signal
bf2ce630d9
Fix layout of mention picker in media editor's Review screen. 2022-07-07 11:42:05 -07:00
Igor Solomennikov
7f4a5f3f7b Merge branch igor/media-editor-updates. 2022-07-06 14:54:26 -07:00
Evan Hahn
d0c7de494a Computed accessors shold always be in the same order 
`get`, then `set`. This fixes violations of [SwiftLint's
`computed_accessors_order` rule][0].

A very mechanical change.

[0]: https://realm.github.io/SwiftLint/computed_accessors_order.html
 2022-06-24 09:35:07 -07:00
Evan Hahn
576d854c6f Remove unnecessary break statements 
This fixes all of our violations of [SwiftLint's
`unneeded_break_in_switch` rule][0].

[0]: https://realm.github.io/SwiftLint/unneeded_break_in_switch.html
 2022-06-24 09:32:34 -07:00
Sasha Weiss (Signal)
2f4ded9d03
Fix reentrant DB read on mentions processing 2022-06-20 13:21:22 -07:00
Nora Trapp
7bd167f815
Initial story sending support 
* Little fix for context menu

* Add 'My Stories' section to stories tab

* Add new story thread types

* Show stories in conversation picker

* Support for sending stories

* Update story list when sending stories

* Add basic 'My Stories' view controller

* Initial stories settings screens

* Consolidate TSPrivateStoryThread and TSMyStoryThread into one class

* Require an explicit read transaction to initialize an outgoing message

* Fix linting

* Allow enabling group story from internal settings

* Fix tests

* PR Feedback
 2022-06-10 22:28:03 -04:00
Max Radermacher
66a2638edd Don’t attach canceled link previews 2022-06-09 15:10:50 -07:00
Evan Hahn
c2e7f0ca93 Prefer implicit getters 
_I recommend reviewing this with whitespace changes disabled._

This fixes violations of [SwiftLint's `implicit_getter` rule][0] by
removing explicit getters when an implicit one would do.

[0]: https://realm.github.io/SwiftLint/implicit_getter.html
 2022-06-06 14:00:15 +00:00
Igor Solomennikov
db0c4e7c73 Fix crash when opening media flow with message pre-populated. 
Steps to reproduce:
• open group chat and type a message containing "@" but don't send it.
• tap on + and select last photo/video from the strip.
• observe app crashing.

Cause of crash:
Attempting to access a child view controller of UIPageViewController
while using force unwrap when UIPageViewController's view is not yet loaded.

The fix:
• Remove force unwrapping (linter was complaining about that too).
• Add "isViewLoaded" check to the method that was causing the crash.
 2022-05-25 11:42:04 -07:00
Evan Hahn
29c0ddf60e Fix violations of SwiftLint's attributes rule 
_I recommend reviewing this with whitespace changes disabled._

Most of these were `@objc` being on the same line, which I fixed with [a
silly script][1]—probably could've used `sed` if I were wiser. The rest
were manual fixes.

See [the SwiftLint documentation for this rule][0].

[0]: https://realm.github.io/SwiftLint/attributes.html
[1]: https://gist.github.com/EvanHahn-Signal/d353c93fa269c82b96baca0a1086521f
 2022-05-14 09:07:42 -05:00
Evan Hahn
df8592fa23 Fix SwiftLint switch_case_alignment violations 
_I recommend reviewing this with whitespace changes disabled._

Bad:

```swift
switch foo {
    case .one: return 1
    case .two: return 2
}
```

Good:

```swift
switch foo {
case .one: return 1
case .two: return 2
}
```

See [the rule's documentation][0] for more.

[0]: https://realm.github.io/SwiftLint/switch_case_alignment.html
 2022-05-03 12:15:05 -05:00
igor-signal
4a6473b448
Localize user-visible file sizes. 
Use ByteCountFormatter with default settings to localize any download sizes that user might see.
 2022-04-29 09:57:56 -05:00
Martin Böttcher
54b743de2d
moved older stringsdict changes into new branch; minor changes (#4205) 
moved older stringsdict changes into new branch
 2022-04-28 17:41:43 +02:00
Igor Solomennikov
dc19eb835f Fix "the the" in comments. 2022-04-27 20:16:45 -07:00
Igor Solomennikov
8fe9963f16 Address PR feedback. 2022-04-22 11:15:21 -07:00
Igor Solomennikov
9349af7fa5 Fix incorrect (old) media editor layout in landscape on non-plus size devices. 2022-04-22 11:15:21 -07:00
Michelle Linington
37fe097812 Lint 2022-04-13 20:23:22 -07:00
Michelle Linington
d54d654cfc PR Feedback: Remove notImplemented altogether 2022-04-13 20:21:47 -07:00
Michelle Linington
6b2f8d31d6 Lint 2022-04-13 20:21:46 -07:00
Michelle Linington
cca09295e6 Adopt notImplemented() where it's unadopted 
notImplemented() ends up forwarding to fatalError() anyway, but before
it does so it flushes our logs. That's probably good to have. I think
most of these come from the default implementations Xcode provides for
you with a fix-it.
 2022-04-13 20:21:46 -07:00
Evan Hahn
8b072620a6 Add "Donation Receipts" view 2022-04-11 16:21:12 -05:00
Michelle Linington
dd0a7f6b80 Require transaction to check blocked address state 2022-04-08 19:01:43 -07:00
Michelle Linington
739af9372a Require transaction to check blocked thread state 2022-04-08 19:01:43 -07:00
Igor Solomennikov
95d6a96824 Update checkmark in chat picker from media sharing flow to match other views. 
ConversationPicker shared checkmark asset with media editor toolbar. The
checkmark was a little bit too small, also checked and unchecked indicators
had different size.

This commit updates ConversationPicker to use the same checkmark styling
that group UI has.
 2022-03-29 10:12:29 -07:00
Igor Solomennikov
d9acd69963 [MediaEditor] Fix typo that caused broken layout when in landscape mode. 2022-03-22 14:24:13 -07:00
Igor Solomennikov
007415832e Disable Send/Proceed button if no chats are selected. 2022-03-22 10:56:46 -07:00
Dimitris Apostolou
62724cf0be Fix typos 2022-03-18 11:31:06 -07:00
Martin Böttcher
000c4c282b Merge branch 'master' into martin/IOS-2234 2022-03-17 09:09:37 +01:00
Nora Trapp
52a3182f13 Render story rings on avatars 2022-03-16 17:52:43 -07:00
Martin Böttcher
8f9be31ba3 replaced NSLocalizedStringFromAppBundle with OWSLocalizedString 2022-03-08 10:17:25 +01:00
Martin Böttcher
c0adfbfb32 NSLocalizedString is replaced by NSLocalizedStringFromAppBundle (reading strings from the bundle of the main app) for all source files called by an app extension and the localizable files are removed for the app extension targets. 2022-03-07 13:29:06 +01:00
Chris Eager
d92eaf97d5 lint fixes 2022-03-04 15:41:21 -08:00
Chris Eager
fa8e829115 Move CaptchaView to its own file 2022-03-04 15:41:21 -08:00
Chris Eager
b33a623e28 Add support for staging captcha URLs 2022-03-04 15:41:21 -08:00
Igor Solomennikov
96c7b802de Slightly tweak position of photos/videos in media editor. 
In order to minimize amount of moving elements when transitioning from
in-app camera to media editor.
 2022-03-02 17:58:40 -08:00
Igor Solomennikov
f8824905c9 Remove OWSNavigationController.ows_preferredStatusBarStyle. 
Turns out it is not really necessary: a subclassed UINavigationController
is presented and `preferredStatusBarStyle` override works just fine.
 2022-03-02 17:56:40 -08:00
Igor Solomennikov
a48c40b2ba Make status bar visible when media sharing UI is presented. 
Media sharing UI is implemented in dark-only style which means
status bar needs to be updated to be visible if the rest of application UI
is in light mode.
 2022-03-02 17:56:39 -08:00
Jordan Rose
058a0213b7 Check whether you're blocked in a thread without a write transaction 
In most cases when working with a ConversationItem we already have a
write transaction, but sometimes we don't. In this case, we know you
can only be blocked in a conversation if there's history in it (at
least as far as the local device knows), and so we can ignore any
threads that don't exist.
 2022-02-18 14:00:27 -08:00
Igor Solomennikov
6c037a84af Fix typo in a comment. 2022-01-31 17:57:15 -08:00
Igor Solomennikov
d1a726f467 Do not use UIVC.automaticallyAdjustsScrollViewInsets - deprecated. 
Use UIScrollView.contentInsetAdjustmentBehavior instead.
 2022-01-31 15:41:18 -08:00
Igor Solomennikov
6848210a4c Remove UIScrollView workaround that was only used in iOS 11.0-11.2 
Not needed anymore since min supported iOS version is now 12.2
 2022-01-31 15:15:18 -08:00
Igor Solomennikov
ec96c7a1c6 Do not use UIVC.topLayoutGuide and UIVC.bottomLayoutGuide. 
Both are deprecated in iOS 12.
 2022-01-31 15:15:18 -08:00
Michelle Linington
f29d37f381 Merge branch 'release/5.27.0' 2022-01-26 12:21:38 -08:00
Martin Böttcher
fcbd352462 renamed some properties and arguments; removed orphaned protocol 2022-01-26 10:46:08 +01:00
Martin Böttcher
777c9785a2 refactored background color handling (part of cell configuration), fixed colors searching on iPad, changed handling of theme change during multi-selection 2022-01-26 10:46:08 +01:00
Martin Böttcher
625fc41416 cell background and context menu react to Theme changes 2022-01-26 10:46:08 +01:00
Martin Böttcher
738cb3c198 home view cells and toolbar reacts to Theme change 2022-01-26 10:46:08 +01:00
Nora Trapp
a2f51dc4a3 Cleanup old feature flags 2022-01-24 10:53:55 -08:00
Martin Böttcher
d5d688f0c7 background and selected background of HomeViewCells got broken if reused 2022-01-21 10:29:47 +01:00