Commit Graph

355 Commits

Author SHA1 Message Date
Matthew Chen
6ee74eaffc Respond to CR. 2018-04-10 15:56:13 -04:00
Matthew Chen
6a07599e00 Respond to CR. 2018-04-10 15:54:46 -04:00
Matthew Chen
f2b416d800 Respond to CR. 2018-04-10 15:54:46 -04:00
Matthew Chen
180cbbcdb3 Don't use scaledFontForFont. 2018-04-10 09:55:25 -04:00
Matthew Chen
8c1362b807 Fix small text usage. 2018-04-09 16:15:24 -04:00
Matthew Chen
ade2ee7216 Use dynamic type everywhere in conversation view. 2018-04-09 14:25:53 -04:00
Michael Kirk
81b2b57703 CR: add comments, make atomic
// FREEBIE
2018-04-09 12:47:57 -04:00
Michael Kirk
90486aa49c Inline method with one caller, fix formatting
// FREEBIE
2018-04-09 12:47:57 -04:00
Michael Kirk
c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
1d4c0624be Clarify variable names
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
253435b27f extract QuotedReplyDraft model 2018-04-09 12:47:56 -04:00
Michael Kirk
53af41fcc6 Reusable UploadOperation based on extracted OWSOperation
// FREEBIE
2018-04-09 12:47:56 -04:00
Matthew Chen
6830d4e8cb Apply message bubble view to message details view. 2018-04-06 12:35:46 -04:00
Matthew Chen
71c5c3a4b7 Refine appearance of quoted reply message cells. 2018-04-05 10:39:07 -04:00
Matthew Chen
822aa64b14 Respond to CR. 2018-04-05 10:35:57 -04:00
Matthew Chen
6171505657 Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
10b4ade55a Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
9085609087 Fix interaction initializers and tests. 2018-04-05 09:36:52 -04:00
Michael Kirk
b6409dd514 CR: formatting changes
// FREEBIE
2018-04-04 10:59:06 -04:00
Michael Kirk
bf401bad90 Send quoted messages
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk
6874a9e28e Convert to swift
// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk
5f8b3ff285 Object lifecycle disposes SystemSound
// FREEBIE
2018-04-03 16:28:33 -04:00
Michael Kirk
2580c690cb CR: Use LRU Cache for storing system sounds
// FREEBIE
2018-04-03 16:28:33 -04:00
Michael Kirk
3cb53f5f44 Respect system alert volume for notifications while in app
// FREEBIE
2018-04-03 16:28:33 -04:00
Michael Kirk
86553b62f9 keyboard pinning vs iPhoneX 2018-04-02 17:38:13 -04:00
Michael Kirk
af5f549e49 Fix TableView layout for iPhoneX
// FREEBIE
2018-04-02 17:02:32 -04:00
Michael Kirk
f441c6211d Format
// FREEBIE
2018-04-02 17:02:32 -04:00
Michael Kirk
6f1608f44b Conventional naming for out custom PureLayout methods.
This moves methods more in line with PureLayout conventions.

- Methods always specify if they pin to an edge vs margin

- `margin` is a reserved word which should only refer to layout margins.
  i.e. do not use it to refer to "inset" and "offset".

// FREEBIE
2018-04-02 17:02:32 -04:00
Matthew Chen
4240b517d0 Respond to CR. 2018-04-02 16:17:46 -04:00
Matthew Chen
8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
2018-04-02 16:17:46 -04:00
Matthew Chen
f98c45603c Respond to CR. 2018-04-02 11:13:11 -04:00
Matthew Chen
31f062ed11 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
c8012d3891 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
e0e8eafb5d Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
11819d9b8a Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
75177ef00f Bubble collapse. 2018-04-02 10:07:15 -04:00
Michael Kirk
d7cccd1e87 Fix: Audio stops when leaving MessageDetails VC
// FREEBIE
2018-03-30 10:48:36 -04:00
Michael Kirk
9adf79c546 Always remove metadata
// FREEBIE
2018-03-27 11:24:18 -04:00
Michael Kirk
1d95cd6977 Improve video scrubbing UX in PageView
// FREEBIE
2018-03-27 10:16:18 -04:00
Matthew Chen
9962bf56b1 Fix 'invalid auth can hang on launch' issue. 2018-03-26 17:07:20 -04:00
Matthew Chen
ef34cd5d58 Fix 'invalid auth can hang on launch' issue. 2018-03-26 17:07:20 -04:00
Michael Kirk
394cc6637c Backport comments from translations
// FREEBIE
2018-03-26 10:12:04 -04:00
Matthew Chen
bb596dba98 Add screen lock feature. 2018-03-22 15:49:57 -04:00
Matthew Chen
847a0269cb Properly cleanup content. 2018-03-22 09:34:47 -04:00
Matthew Chen
8d689ec090 Properly cleanup content. 2018-03-22 09:34:47 -04:00
Michael Kirk
0025661a8d Extract GradientView
// FREEBIE
2018-03-20 17:29:35 -04:00
Michael Kirk
7754d3d94f Real assets
// FREEBIE
2018-03-20 17:27:07 -04:00
Michael Kirk
352f5c1059 Prefer back button over dismiss
In some context this makes more sense, and it will never be confusing.

// FREEBIE
2018-03-20 11:12:11 -04:00
Michael Kirk
2412ab092e Avoid occasional audio crash
// FREEBIE
2018-03-19 20:24:47 -04:00