signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
7,272 Commits 1 Branch 2,246 Tags 1.8 GiB
5ed22ada7b
Commit Graph

319 Commits

Author SHA1 Message Date
Matthew Chen
5ed22ada7b Respond to CR. 2018-06-01 12:01:20 -04:00
Matthew Chen
e4f7995e4d Ensure conversation view is first responder before presenting another view. 2018-06-01 11:59:26 -04:00
Matthew Chen
9ee572fb24 Respond to CR. 2018-05-31 16:36:16 -04:00
Matthew Chen
fefc9843b1 Modify views to observe changes when active, not just foreground. 2018-05-31 16:31:51 -04:00
Matthew Chen
812210a63c Modify views to observe changes when active, not just foreground. 2018-05-31 16:31:51 -04:00
Michael Kirk
97324eaae1 Load less messages initially 
// FREEBIE
 2018-05-31 16:20:15 -04:00
Matthew Chen
4f520646cc Avoid double layout in conversation view; but carefully. 2018-05-30 17:46:24 -04:00
Michael Kirk
273063e0aa ConversationView first load avoids redundant layout 
We are laying out the collection view, invalidating the layout, and then
laying out the collection view again on first appearance of the
conversation view. This is quite expensive - removing it shaves off
about 30% of load time.

// FREEBIE
 2018-05-30 17:46:24 -04:00
Matthew Chen
5f593bd736 Revert "Add temporary verbose logging around message creation." 
This reverts commit f26ad5cd34.
 2018-05-29 14:01:11 -04:00
Matthew Chen
0aa8306036 Revert "Add temporary verbose logging around message creation." 
This reverts commit 5b0d806a6d.
 2018-05-29 14:01:04 -04:00
Matthew Chen
5b0d806a6d Add temporary verbose logging around message creation. 2018-05-29 13:42:49 -04:00
Matthew Chen
f26ad5cd34 Add temporary verbose logging around message creation. 2018-05-29 11:49:42 -04:00
Michael Kirk
2709a91b5e Fixup attachment approval vis-a-vis call banner 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
1b60716759 Stop worrying about notification order by using delegate pattern 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
29d08545e2 Use OWSNavigationController instead of UINavigationController 
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
33eb4c38cd Centralize translucency configuration 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
a2b1793262 initial render is wrong, but settles somewhere nice 
-[x] fix initial placement
-[x] add additional top safe area?

// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
3a9391f4fb notes on what didn't work 2018-05-24 12:28:20 -04:00
Michael Kirk
4dbd14ac41 WIP navbar resize 
-[ ] CallScreen
  -[x] functional button
  -[ ] needs design
  -[x] disable conversation view call buttons while in call
-[ ] iOS11
  -[x] resize nav content
  -[ ] background showing at top of all vc's
  -[] iPhoneX
    -[x] use differently sized banner for now
    -[] mimic X system design
-[ ] iOS10
  -[x] resize nav content
  -[ ] animation glitch while push/pop
-[ ] iOS9

// FREEBIE
 2018-05-24 12:28:20 -04:00
Matthew Chen
e2d9c1187a Fix "group avatar doesn't update after local change." 2018-05-18 15:37:38 -04:00
Matthew Chen
692d0a7579 Don't mark messages as read if conversation view isn't 100% visible. 2018-05-17 16:07:23 -04:00
Matthew Chen
78de7a10f7 Don't mark messages as read if conversation view isn't 100% visible. 2018-05-17 16:07:23 -04:00
Matthew Chen
f436fc19c2 Make contact share "bubble/card" reflect share contents. 2018-05-16 17:19:05 -04:00
Matthew Chen
f6106512db Only mark messages read in conversation view if visible. 2018-05-16 16:30:01 -04:00
Michael Kirk
30cef1f084 start readtimer whenever we become active 
// FREEBIE
 2018-05-15 12:56:47 -04:00
Michael Kirk
117d7319d2 Add contact modally and restore navbar style when dismssing contacts 
// FREEBIE
 2018-05-14 18:40:56 -04:00
Michael Kirk
2cc3eabdb8 quote reply to contact share (no avatar) 
// FREEBIE
 2018-05-10 14:34:19 -04:00
Matthew Chen
acdc51ba3d Respond to CR. 2018-05-10 13:17:34 -04:00
Matthew Chen
37b8b368a6 Show "share contact" flow in single presented navigation controller. 2018-05-10 13:17:01 -04:00
Michael Kirk
c15fea4eca merge avatar with existing 
// FREEBIE
 2018-05-10 11:31:22 -04:00
Michael Kirk
0c469764f1 re-use contact picker for "add to existing" 
Required refactor of contact picker to be presented non-modally.

TODO: merge emails, address, display names

// FREEBIE
 2018-05-10 11:31:22 -04:00
Michael Kirk
609746abec clarify naming 
// FREEBIE
 2018-05-10 11:31:22 -04:00
Matthew Chen
4079cdb600 Apply more contact share assets. 2018-05-09 17:51:27 -04:00
Michael Kirk
42109593af Remove fromViewController state from ContactShareViewHelper 
// FREEBIE
 2018-05-09 10:21:00 -04:00
Michael Kirk
77bbbad70c Remove contactShare state from ContactShareViewHelper 
// FREEBIE
 2018-05-09 10:21:00 -04:00
Matthew Chen
c2adf624ea Respond to CR. 2018-05-08 17:22:34 -04:00
Matthew Chen
44ceee5849 Add contact share actions to conversation view and improve phone number parsing. 2018-05-08 17:22:34 -04:00
Michael Kirk
7e22d9e900 Prevent input toolbar from appearing over camera view, contact view or actionsheet 
// FREEBIE
 2018-05-08 17:07:15 -04:00
Michael Kirk
41aa7eafe3 makeKeyAndVisible restores first responder, so no need to track it 
ourselves.

This isn't *quite* as nice for the case when we want to restore a
textfield that was active before, but it much more simply covers the
more important case that we restore input accessory views after
backgrounding/foregrounding.

// FREEBIE
 2018-05-08 17:07:15 -04:00
Matthew Chen
bd116f8938 Share contacts from share extension. 2018-05-07 17:04:55 -04:00
Matthew Chen
5f1941f6aa Apply design changes from Myles. 2018-05-07 16:17:16 -04:00
Michael Kirk
a10ae1835e respond to code review 
// FREEBIE
 2018-05-07 12:51:55 -04:00
Michael Kirk
77fc5571fb Implement avatar sending 
// FREEBIE
 2018-05-07 12:08:41 -04:00
Michael Kirk
5ba5e98260 Show downloaded contact avatar in thread 
// FREEBIE
 2018-05-07 12:08:41 -04:00
Matthew Chen
fd93bf677e Clean up ahead of PR. 2018-05-04 18:13:22 -04:00
Matthew Chen
6e18d84a10 Add contact share approval view. 2018-05-04 18:13:22 -04:00
Matthew Chen
0c745dd989 Add contact share approval view. 2018-05-04 18:13:22 -04:00
Matthew Chen
459101c20e Add feature flag for contact sharing. 2018-05-04 09:35:47 -04:00
Matthew Chen
ff6b45abee Respond to CR. 2018-05-03 14:31:11 -04:00
Matthew Chen
91d54360ba Add contact view. 2018-05-03 14:09:54 -04:00