signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
22,799 Commits 1 Branch 2,246 Tags 1.8 GiB
5bf94de2a6
Commit Graph

199 Commits

Author SHA1 Message Date
Michael Kirk
eef1368ad3 Timestamp audit step1: change signature 
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
 2018-09-26 09:52:33 -06:00
Michael Kirk
6c5fbc6de5 Update existing contact offers in place 
WIP: migration / autoincrement logic

TODO:

-[x] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?

fixup contact offers
 2018-09-26 09:52:33 -06:00
Michael Kirk
a60d8eb161 WIP: migration / autoincrement logic 
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
 2018-09-26 09:52:33 -06:00
Michael Kirk
920a82564f Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
Michael Kirk
df67e883f3 BlockList vs. "zero length" group names 2018-09-14 11:32:39 -05:00
Michael Kirk
c1b88b5f48 copy cleanup: remove redundant body 2018-09-14 10:52:01 -05:00
Michael Kirk
b6eb1476cb Leave group when blocking it 2018-09-12 19:16:14 -05:00
Michael Kirk
eadb04efcc WIP: ContactViewHelper incorporates group blocking 
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
 2018-09-12 19:16:14 -05:00
Michael Kirk
c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics 
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
 2018-09-07 10:00:48 -06:00
Matthew Chen
fac7f6932f Rename TSGroupMetaMessage enum values. 2018-09-04 09:30:01 -04:00
Matthew Chen
f473f60111 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
c0d486b1f1 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Michael Kirk
8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 2018-08-10 16:55:54 -06:00
Michael Kirk
c05700fd98 Log in OWSFail 
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
 2018-08-09 15:30:19 -06:00
Michael Kirk
d591fb7f2c Fix some compiler warnings 2018-07-17 19:22:58 -06:00
Matthew Chen
376e2cc1db Respond to CR. 2018-07-11 16:54:44 -04:00
Matthew Chen
35f058c46a Rework unread indicators. 2018-07-11 16:43:39 -04:00
Matthew Chen
ecafe546b6 Rework unread indicators. 2018-07-11 16:43:39 -04:00
Matthew Chen
8d72bb032e Rework unread indicators. 2018-07-11 16:43:39 -04:00
Matthew Chen
776b5abed1 Handle edge cases around unread indicator & contact offers. 2018-06-20 17:38:27 -04:00
Matthew Chen
999e8c8e31 Respond to CR. 2018-06-12 12:44:32 -04:00
Matthew Chen
13e9f11b4e Open message search results. 2018-06-12 12:44:32 -04:00
Matthew Chen
390c0bc201 Send fake contact shares. 2018-05-04 09:37:04 -04:00
Matthew Chen
0316a98eb8 Undo renaming of contactShare property of TSMessage. 2018-05-01 11:26:01 -04:00
Matthew Chen
0d8cfc5403 Rename contact share class to contact. 2018-05-01 11:03:25 -04:00
Matthew Chen
4b8a2fa8a3 Sketch out "contact share" model. 2018-05-01 11:03:25 -04:00
Michael Kirk
eec7678979 Group's meta message defaults to "Delivery" 
// FREEBIE
 2018-04-19 14:57:42 -04:00
Matthew Chen
6ee74eaffc Respond to CR. 2018-04-10 15:56:13 -04:00
Matthew Chen
6a07599e00 Respond to CR. 2018-04-10 15:54:46 -04:00
Matthew Chen
f2b416d800 Respond to CR. 2018-04-10 15:54:46 -04:00
Michael Kirk
90486aa49c Inline method with one caller, fix formatting 
// FREEBIE
 2018-04-09 12:47:57 -04:00
Michael Kirk
c56e8acc51 QuotedReplyModel from SSK->SignalMessaging 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
1d4c0624be Clarify variable names 
// FREEBIE
 2018-04-09 12:47:56 -04:00
Michael Kirk
253435b27f extract QuotedReplyDraft model 2018-04-09 12:47:56 -04:00
Matthew Chen
9085609087 Fix interaction initializers and tests. 2018-04-05 09:36:52 -04:00
Michael Kirk
b6409dd514 CR: formatting changes 
// FREEBIE
 2018-04-04 10:59:06 -04:00
Michael Kirk
bf401bad90 Send quoted messages 
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
 2018-04-04 10:59:04 -04:00
Matthew Chen
4240b517d0 Respond to CR. 2018-04-02 16:17:46 -04:00
Matthew Chen
8e4f2ca0ed Rework proto schema changes for quoted replies. 
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
 2018-04-02 16:17:46 -04:00
Matthew Chen
847a0269cb Properly cleanup content. 2018-03-22 09:34:47 -04:00
Matthew Chen
8d689ec090 Properly cleanup content. 2018-03-22 09:34:47 -04:00
sdkjfhsdkjhfsdlkjhfsdf
b87079d4b4 Sharing attachment shows progress / retry dialog 
// FREEBIE
 2017-12-20 20:57:17 -06:00
Michael Kirk
e20f44024c WIP: Support sending attachment captions 
Looks fine on other clients, but locally we don't display the caption.

// FREEBIE
 2017-12-20 14:26:53 -06:00
Matthew Chen
9a990b58e8 Respond to CR. 2017-12-19 11:38:25 -05:00
Michael Kirk
16448e2a0b Merge tag '2.19.3.0' 2017-12-14 11:42:57 -05:00
Michael Kirk
a58f1f385c Share a photo from photos app 
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
 2017-12-07 10:13:06 -05:00