Commit Graph

25 Commits

Author SHA1 Message Date
Matthew Chen
7c5d769f8b Design tweaks. 2021-01-14 22:27:01 -03:00
Michelle Linington
4af5c2dbcc Rebase and lint 2021-01-12 15:06:41 -08:00
Michelle Linington
34dd4f8e73 Remove minimum activity timer 2021-01-12 15:06:41 -08:00
Michelle Linington
56caf0e361 Cleanup and bug fixing
- Better comments
- Fix issues around how cancelled promises propogate
- Opportunistic bug fixing with alert presentation
2021-01-12 15:06:41 -08:00
Michelle Linington
e5573a6f30 IOS-1014: Fail to send video attachment after scrubbing and trimming
Fixes an issue where scrubbing and trimming a video attachment will
cause the send to fail.

This was caused by an issue with how we prerender trimmed video during a
scrub gesture. This fixes this by only performing the render when
necessary.

Additionally, this changes up some of the lifecycle around rendering
trimmed videos. Replaces the NSOperation with a promise chain to avoid
unnecessary queue hopping.
2021-01-12 15:06:41 -08:00
Matthew Chen
587b8f2c36 Resumable attachment download. 2020-08-01 12:18:13 -03:00
Matthew Chen
6b4f192b1b Remove usage of retainUntilComplete. 2020-05-22 09:51:12 -03:00
Matthew Chen
1ad4a5b9ae Retain all promises until complete. 2020-05-15 18:13:12 -03:00
Matthew Chen
c7df10eb36 Apply CGSize(square:). 2020-04-06 11:34:21 -03:00
Matthew Chen
e097239dcd Sketch out revised "new group" view. 2020-03-17 10:31:20 -03:00
Michael Kirk
e91526e855 make OWSErrorMakeAssertionError variadic, objc only. Swift doesn't need vargs for formatting and can use the more concise OWSAssertionError 2020-03-04 10:08:29 -07:00
Michael Kirk
a49b4d7413 avoid redundantly cleaning up datasource 2019-11-21 11:14:05 -07:00
Matthew Chen
5a12373c4d Video trimming edge cases. 2019-11-14 17:17:08 -08:00
Matthew Chen
2abc07a4d2 Fix divide-by-zero crash. 2019-11-11 10:59:51 -03:00
Matthew Chen
bdd3b0710e Respond to CR. 2019-11-07 15:17:50 -03:00
Matthew Chen
5197f6b41a Respond to CR. 2019-11-07 15:17:50 -03:00
Matthew Chen
9a7a03af02 Improve trim video perf. 2019-11-07 15:14:22 -03:00
Matthew Chen
9e00253a9f Fix video editor save button. 2019-11-07 14:55:15 -03:00
Matthew Chen
a605522259 Fix trim rect for small snippets. 2019-11-05 10:01:56 -03:00
Matthew Chen
ba9007529b Apply design tweaks to video trimming experience. 2019-11-05 10:01:56 -03:00
Matthew Chen
219d38bb56 Add support for video trimming. 2019-10-31 17:26:38 -03:00
Matthew Chen
01e61c410a Respond to CR. 2019-10-31 17:26:38 -03:00
Matthew Chen
8b97e52a78 Respond to CR. 2019-10-31 17:26:38 -03:00
Matthew Chen
bf3958b2b7 Add support for video trimming. 2019-10-31 17:26:38 -03:00
Matthew Chen
75f7cf6960 Add support for video trimming. 2019-10-31 17:26:38 -03:00