Michelle Linington
4af5c2dbcc
Rebase and lint
2021-01-12 15:06:41 -08:00
Michelle Linington
56caf0e361
Cleanup and bug fixing
...
- Better comments
- Fix issues around how cancelled promises propogate
- Opportunistic bug fixing with alert presentation
2021-01-12 15:06:41 -08:00
Michelle Linington
e5573a6f30
IOS-1014: Fail to send video attachment after scrubbing and trimming
...
Fixes an issue where scrubbing and trimming a video attachment will
cause the send to fail.
This was caused by an issue with how we prerender trimmed video during a
scrub gesture. This fixes this by only performing the render when
necessary.
Additionally, this changes up some of the lifecycle around rendering
trimmed videos. Replaces the NSOperation with a promise chain to avoid
unnecessary queue hopping.
2021-01-12 15:06:41 -08:00
Matthew Chen
3480af38e4
Fix build warnings.
2020-09-25 15:16:19 -03:00
Matthew Chen
587b8f2c36
Resumable attachment download.
2020-08-01 12:18:13 -03:00
Matthew Chen
6b4f192b1b
Remove usage of retainUntilComplete.
2020-05-22 09:51:12 -03:00
Michael Kirk
d9aea733af
avoid spurious assert
2019-11-21 13:39:21 -07:00
Michael Kirk
a49b4d7413
avoid redundantly cleaning up datasource
2019-11-21 11:14:05 -07:00
Matthew Chen
743901b182
Remove obsolete assert.
2019-11-20 13:08:16 -03:00
Matthew Chen
5a12373c4d
Video trimming edge cases.
2019-11-14 17:17:08 -08:00
Matthew Chen
bdd3b0710e
Respond to CR.
2019-11-07 15:17:50 -03:00
Matthew Chen
5197f6b41a
Respond to CR.
2019-11-07 15:17:50 -03:00
Matthew Chen
b2b90deebe
Cancel video export session.
2019-11-07 15:14:22 -03:00
Matthew Chen
9a7a03af02
Improve trim video perf.
2019-11-07 15:14:22 -03:00
Matthew Chen
8b97e52a78
Respond to CR.
2019-10-31 17:26:38 -03:00
Matthew Chen
75f7cf6960
Add support for video trimming.
2019-10-31 17:26:38 -03:00
