Commit Graph

828 Commits

Author SHA1 Message Date
Matthew Chen
fc77b0fa2d Merge remote-tracking branch 'private/release/2.44.0' 2019-09-27 11:31:22 -03:00
Michael Kirk
f6747076df View Once Video 2019-09-26 12:39:26 -07:00
Michael Kirk
95f2d511e1 font updates 2019-09-26 12:20:42 -07:00
Michael Kirk
54812451f4 Update and apply palette. Consolidate dupes. 2019-09-24 15:12:51 -07:00
Michael Kirk
f63a64243a convert colors to Swift 2019-09-24 15:12:50 -07:00
Nora Trapp
ab2ff4db32 Rewrite audio progress view in swift, add play/pause animation 2019-09-23 17:03:03 -07:00
Matthew Chen
8e4cd299be Merge tag '2.43.0.17' 2019-09-23 12:19:18 -03:00
Nora Trapp
1f256ef9e8 Don't render find by phone number view under navbar on iOS 10 2019-09-19 11:50:01 -07:00
Matthew Chen
7e72a12ad7 Merge remote-tracking branch 'private/release/2.43.0' 2019-09-18 09:44:21 -03:00
Matthew Chen
eded6d4521 Consistent button height. 2019-09-18 08:58:41 -03:00
Matthew Chen
f56aae7ac9 Merge remote-tracking branch 'private/release/2.43.0'
# Conflicts:
#	SignalServiceKit/src/Util/FeatureFlags.swift
#	SignalServiceKit/tests/Storage/SDSDatabaseStorageObservationTest.swift
2019-09-16 14:41:22 -03:00
Nora Trapp
d16689fa04 Handle theme change in more views 2019-09-16 10:26:00 -07:00
Nora Trapp
c595a99ac7 Better support dark mode in share extension 2019-09-16 10:26:00 -07:00
Nora Trapp
33d2331d02 Allow things to keep building in Xcode 10 for now 2019-09-16 10:26:00 -07:00
Nora Trapp
c697630ab2 Fix share sheet for iOS 13 2019-09-16 10:26:00 -07:00
Nora Trapp
a7b8060c53 Add appearance menu with system theme option 2019-09-16 10:26:00 -07:00
Nora Trapp
618dea7e9f Ensure ui styling is correct regardless of system theme 2019-09-16 10:26:00 -07:00
Nora Trapp
9625bb9959 Support iOS 13 style modal presentation where appropriate. 2019-09-16 10:26:00 -07:00
Matthew Chen
6a529e792d Rework message configuration. Simplify change detection, ensure continuity for deleted threads. 2019-09-13 20:40:06 -03:00
Michael Kirk
bb316f711b Merge tag '2.42.1.1' into release/2.43.0 2019-09-05 14:52:59 -06:00
Michael Kirk
400f7f443d Fix empty progress bar 2019-09-05 11:54:47 -06:00
Matthew Chen
28008a424e Avoid deadlocks in TSAccountManager. 2019-08-30 14:39:45 -03:00
Matthew Chen
a5efaf8d16 Merge remote-tracking branch 'private/release/2.42.0' 2019-08-28 11:33:26 -03:00
Michael Kirk
45c4066a80 Fix deadlock with thread.name
For contact threads, thread.name opened a sneaky transaction, which would
sometimes cause a deadlock.

This commit moves the name method to the contact manager and offers an explicit
transaction flavor. There is still a sneaky transaction flavor used in some
places where it's deemed dangerous to plumb through a transaction without
further scrutiny.
2019-08-23 18:45:23 -06:00
Michael Kirk
4bbd020bf5 further fix release build 2019-08-22 11:30:42 -06:00
Michael Kirk
64214ed982 fix release build 2019-08-22 11:24:27 -06:00
Nora Trapp
07ed67f943 Cleanup some unused classes 2019-08-22 09:27:36 -07:00
Nora Trapp
285357ff84 Allow adding usernames to block list 2019-08-22 09:27:36 -07:00
Matthew Chen
85756b0fe9 Merge remote-tracking branch 'private/release/2.42.0' 2019-08-16 13:21:38 -03:00
Nora Trapp
0c1de9c103 Merge remote-tracking branch 'origin/release/2.41.1' into release/2.42.0 2019-08-15 19:23:21 -07:00
Matthew Chen
d308c566af Address deadlocks in profile manager. 2019-08-15 16:10:14 -03:00
Matthew Chen
73cbf76b2e Handle "loading" and "load failed" cases in sticker pack view. 2019-08-15 10:12:54 -03:00
Nora Trapp
97b26a44fa Fix an issue where registration lock PINs were truncated to 16 characters. 2019-08-14 18:03:36 -03:00
Matthew Chen
2c616f4f3e Remove YDB & primary storage usage. 2019-08-14 09:10:48 -03:00
Michael Kirk
980d7e905f use "ask" helper when saving media
This required moving the ask helpers to SignalMessaging
2019-08-13 16:47:50 -06:00
Michael Kirk
683b056a20 save from camera first 2019-08-13 15:55:12 -06:00
Matthew Chen
75b3c358a6 Merge branch 'release/2.42.0' 2019-08-13 13:10:39 -03:00
Matthew Chen
6d465e14f0 Respond to CR. 2019-08-13 10:33:52 -03:00
Matthew Chen
e11ea90c78 Handle sticker pack manifest download failures. 2019-08-13 10:29:01 -03:00
Michael Kirk
82c99c4003 CR: rename for clarity 2019-08-12 15:11:40 -06:00
Michael Kirk
f3793f0f2a Consolidate OutgoingMessage preparation 2019-08-12 15:11:40 -06:00
Matthew Chen
081a62793d Fix attachment send button. 2019-08-09 21:37:54 -03:00
Nora Trapp
6c64e94006 Only auto-share profile with empty threads. 2019-08-09 12:59:15 -07:00
Nora Trapp
14fca4b7e3 Fix sticker keyboard paging 2019-08-09 12:58:34 -07:00
Matthew Chen
6ed12aa9fe Respond to CR. 2019-08-09 15:29:47 -03:00
Matthew Chen
f53bc36c4c Hide the 'View once photo' indicator. 2019-08-09 14:43:50 -03:00
Michael Kirk
4dc75aed3d fix warnings 2019-08-09 09:41:59 -06:00
Matthew Chen
a48ccccdd1 Remove more usage of primary storage. 2019-08-07 17:41:11 -03:00
Nora Trapp
f9bfbedfc2 Updated input toolbar styling 2019-08-06 11:00:07 -07:00
Nora Trapp
868e49f1ff Match StickerKeyboard to system keyboard size, set scaffolding for other custom keyboards. 2019-08-06 10:53:31 -07:00
Nora Trapp
939bbcde51 Fix install button placement on non-notch devices 2019-08-06 10:26:44 -07:00
Nora Trapp
5a0e422403 Fix long packs getting clipped by install button 2019-08-06 10:26:44 -07:00
Nora Trapp
099d0cba0d Fix small sticker button scaling 2019-08-06 10:26:44 -07:00
Matthew Chen
eccfad0f46 Merge remote-tracking branch 'private/release/2.41.0' 2019-08-06 12:12:39 -03:00
Michael Kirk
eea9e064ce new send buttons 2019-08-02 09:26:24 -06:00
Michael Kirk
afd9d7781a Camera First flow 2019-08-02 09:26:23 -06:00
Matthew Chen
4f03f969fc Rework "view once" messages. 2019-08-01 16:13:37 -03:00
Michael Kirk
d71ab52ecf Merge tag '2.41.0.18' 2019-07-31 11:09:00 -06:00
Matthew Chen
e9410d9098 Fix broken layout in 'no stickers' case. 2019-07-30 18:44:00 -06:00
Matthew Chen
19e3643f75 Remove usage of primary storage. 2019-07-29 17:25:59 -03:00
Matthew Chen
de56fec16b Remove usage of primary storage. 2019-07-29 17:25:58 -03:00
Nora Trapp
96bf655727 Profile name renders at same level as system contact name 2019-07-29 12:50:54 -07:00
Nora Trapp
2cfa9f68ca Add the thread to the profile whitelist anytime we send a message. 2019-07-29 12:40:09 -07:00
Michael Kirk
3e193f6b83 FIX: dismissed VC shouldnt determine status bar style 2019-07-24 13:25:37 -06:00
Michael Kirk
9e704be729 Merge tag '2.41.0.12' 2019-07-22 14:33:01 -06:00
Nora Trapp
4c118f3964 Fix a bug when clicking between sticker packs where the wrong pack would render 2019-07-22 14:09:38 -06:00
Matthew Chen
27efb2a1b0 Fix 'image editor vs. per-message expiration' bug. 2019-07-22 13:37:57 -06:00
Michael Kirk
a8dd11d231 simplify 2019-07-22 12:35:08 -06:00
Michael Kirk
d3e3be90b6 remove isModalState, isAddMoreVisible block instead of copying around state 2019-07-22 12:35:08 -06:00
Matthew Chen
a95182edc8 Fix modal attachment approval. 2019-07-22 12:35:08 -06:00
Michael Kirk
0c6e6787ed update flag name for clarity 2019-07-22 09:12:09 -06:00
Nora Trapp
3d1dd3dfe4 Remove rtlSafeAppend 2019-07-19 12:33:17 -07:00
Michael Kirk
c36d691d11 Fix: selecting last message from tileView doesn't focus
The mostRecentAttachment is a separate and redundant instance with whats in the
media gallery item cache.

Alternatively, we could double down on the one-instance-per-value paradigm by
creating a way to manually add existing instances to the cache, but the value
semantics proposed here seemed more natural.

I wish we could have just made RailViewItem: Equatable, but alas "protocol can
only be used as a generic constraint because it has Self or associated type
requirements"
2019-07-17 14:54:51 -06:00
Michael Kirk
61949dda9d Merge branch 'release/2.41.0-with-uuid-address-unreverted' into mkirk/ri-2.41.0 2019-07-16 18:00:24 -06:00
Nora Trapp
ef4a612fcf No more transitional_signalServiceAddress 2019-07-11 10:53:33 -07:00
Nora Trapp
a323ff4ddf No more transitional_phoneNumber 2019-07-11 10:52:13 -07:00
Nora Trapp
077febc757 Update some misc stuff to use SignalServiceAddress 2019-07-10 13:31:03 -07:00
Nora Trapp
b9bb444276 Add UUID support to groups 2019-07-10 13:27:36 -07:00
Matthew Chen
a68ff90b16 Allow multi-send from camera; allow per-message expiration from camera roll. 2019-07-10 13:39:26 -03:00
Nora Trapp
c186755c66 Migrate IdentityManager and associated models to support UUIDs 2019-07-08 11:44:40 -07:00
Matthew Chen
d5e7ed61d8 Add accessibility ids to sticker keyboard. 2019-06-28 09:58:37 -04:00
Matthew Chen
9c249a61e8 Add accessibility ids to sticker pack view. 2019-06-28 09:58:37 -04:00
Matthew Chen
f1129cb563 Add accessibility ids to sticker keyboard. 2019-06-28 09:39:19 -04:00
Matthew Chen
ed0ae4e2ce Add accessibility ids to sticker pack view. 2019-06-28 09:39:19 -04:00
Nora Trapp
7d94af3287 Migrate TSContactThread to support UUIDs 2019-06-27 13:12:52 -07:00
Matthew Chen
c8359fc932 Convert message sending to use any transactions. 2019-06-25 16:00:58 -04:00
Matthew Chen
b86ab9f611 Migrate OWSDisappearingMessagesConfiguration to any. 2019-06-25 15:48:37 -04:00
Nora Trapp
34e8a7e4a0 PR Feedback 2019-06-25 10:31:23 -07:00
Nora Trapp
92f817d7fd Update callsites to use new contacts manager address interface 2019-06-25 10:30:52 -07:00
Matthew Chen
e26a8e1bd4 Convert attachments to be any-only. 2019-06-24 15:34:02 -04:00
Matthew Chen
cde2cfbdd1 Respond to CR. 2019-06-17 11:17:52 -04:00
Matthew Chen
8c31562b0c Fix edge cases in attachment approval toolbar layout. 2019-06-17 11:17:52 -04:00
Matthew Chen
87cea17e85 Fix edge cases in attachment approval toolbar layout. 2019-06-17 11:17:52 -04:00
Matthew Chen
a62376b3f9 Remove sendingMediaWithOversizeText feature flag. 2019-06-17 11:17:52 -04:00
Matthew Chen
97cfb32d29 Rework camera flow for one-off disappearing messages. 2019-06-17 11:17:52 -04:00
Nora Trapp
13a80ef8aa Accept autocorrect suggestions in all the textViews that can be dismissed without the keyboard 2019-06-13 09:24:03 -07:00
Nora Trapp
2165ae1051 Don't change sticker packs when orientation is changing. 2019-06-13 08:02:05 -07:00
Matthew Chen
54527f6870 Merge remote-tracking branch 'private/release/2.40.0' 2019-06-10 13:21:59 -04:00
Matthew Chen
8b134ec284 Filter sticker pack strings for display. 2019-06-10 12:32:16 -04:00
Matthew Chen
6b8a602799 Filter sticker pack strings for display. 2019-06-10 12:32:16 -04:00
Matthew Chen
421d568bee Merge tag '2.40.0.20' 2019-06-10 11:32:26 -04:00
Matthew Chen
0e87a11145 Tweak sticker share feature flag check. 2019-06-10 10:17:12 -04:00
Nora Trapp
73816b25df Disable sticker pack sharing. 2019-06-10 10:07:06 -04:00
Nora Trapp
ca22869f7d Also cleanup borders on link previews in dark mode 2019-05-31 14:13:40 -07:00
Nora Trapp
3125cc3580 Slightly bump up the border width of the input tool bar to improve anti-aliasing. 2019-05-31 12:00:41 -07:00
Matthew Chen
7901bcc123 Merge remote-tracking branch 'private/release/2.40.0' 2019-05-31 13:19:36 -04:00
Matthew Chen
e43c0e2316 Notify input toolbar when stickers become enabled. 2019-05-31 09:36:02 -04:00
Matthew Chen
72d646d983 Respond to CR. 2019-05-31 09:34:01 -04:00
Matthew Chen
82e5d46cb2 Respond to CR. 2019-05-31 09:20:02 -04:00
Matthew Chen
a61081c0a7 Lazy download known sticker packs. 2019-05-31 09:20:02 -04:00
Matthew Chen
d462b5d94b Lazy download known sticker packs. 2019-05-31 09:20:02 -04:00
Matthew Chen
0dfa29137f Lazy download known sticker packs. 2019-05-31 09:20:02 -04:00
Matthew Chen
243da966f7 Lazy download known sticker packs. 2019-05-31 09:20:02 -04:00
Nora Trapp
4e15814252 Fix sticker preview so it's not masked by your thumb 2019-05-30 14:12:46 -07:00
Matthew Chen
4eed2bba2f Respond to CR. 2019-05-30 09:09:08 -04:00
Matthew Chen
abce36b687 Never show the empty sticker keyboard. 2019-05-30 09:06:39 -04:00
Matthew Chen
faef70e8c6 Fix dark theme selection in sticker keyboard pack list. 2019-05-30 09:05:44 -04:00
Michael Kirk
49ae6ad50d show "Back" text on button 2019-05-29 17:13:41 -06:00
Michael Kirk
2502b54cd5 Don't show "Add More" for gif picker 2019-05-29 17:13:41 -06:00
Michael Kirk
fd13a58557 Allow repicking from giphy approval 2019-05-29 17:13:41 -06:00
Nora Trapp
86eac88b73 PR Feedback 2019-05-29 10:43:18 -07:00
Nora Trapp
9292d402a0 Sticker Keyboard paging. 2019-05-29 10:43:18 -07:00
Matthew Chen
fc25251dd8 Merge remote-tracking branch 'private/release/2.40.0' 2019-05-29 10:56:24 -04:00
Matthew Chen
ff73b3bef4 Tweak sticker keyboard height. 2019-05-29 09:02:29 -04:00
Michael Kirk
a837c75764 Simple send sans Yap 2019-05-28 17:31:53 -04:00
Matthew Chen
879fa69076 Revert "Protocol stores use strongly typed signatures"
This reverts commit 6ac9933019.
2019-05-24 14:51:33 -04:00
Matthew Chen
ac9fba611e Merge remote-tracking branch 'private/release/2.40.0' 2019-05-24 14:50:55 -04:00
Matthew Chen
ef15f3e134 Fix sticker sync issues. 2019-05-24 14:07:51 -04:00
Matthew Chen
0b4728ba3f Merge remote-tracking branch 'private/release/2.40.0' 2019-05-24 11:17:02 -04:00
Matthew Chen
07d7f5e9eb Tweak background of sticker pack view. 2019-05-24 09:49:42 -04:00
Matthew Chen
4cd7ab3da7 Respond to CR. 2019-05-23 12:30:15 -04:00
Matthew Chen
1a371a184d More sticker design tweaks. 2019-05-23 12:30:15 -04:00
Matthew Chen
0313a0ce2a Respond to CR. 2019-05-23 10:21:09 -04:00
Matthew Chen
829cdd1ad6 Add selected state to sticker keyboard. 2019-05-23 10:19:04 -04:00
Matthew Chen
69ca57608a Move "recent stickers" button into sticker pack list. 2019-05-23 10:19:04 -04:00
Matthew Chen
b07e004815 Sticker design tweaks. 2019-05-23 10:19:04 -04:00
Matthew Chen
600dd2eb93 Sticker design tweaks. 2019-05-23 10:19:04 -04:00
Michael Kirk
40c1503d07 fix compiler warning: never mutated 2019-05-22 16:03:07 -04:00
Michael Kirk
e1258156de use modern Hashable function 2019-05-22 16:03:07 -04:00
Matthew Chen
afeb56476e Merge remote-tracking branch 'private/release/2.40.0' 2019-05-21 17:15:01 -04:00
Michael Kirk
691209e25e Decrypt Messages with AnyTransaction
- Migrate protocol stores to KVStores
- Introduce AnyDatabaseQueue
- Move messaging pipeline to AnyTransactions
- Migrate specialized PushDecrypt job to generic JobQueue
2019-05-21 16:20:22 -04:00
Matthew Chen
3207a33f21 Respond to CR. 2019-05-20 14:22:40 -04:00
Michael Kirk
6ac9933019 Protocol stores use strongly typed signatures 2019-05-17 09:45:20 -07:00
Matthew Chen
24c8c0e501 Update feature flags for release branch. 2019-05-16 17:54:55 -04:00
Matthew Chen
bc6a99ad21 Sketch out the stickers splash. 2019-05-16 17:32:32 -04:00
Matthew Chen
27c5278e54 Add more accessibility ids to search bars and navbar items. 2019-05-14 15:04:13 -04:00
Matthew Chen
cea3b40a85 Update sticker-related copy. 2019-05-14 14:50:31 -04:00
Matthew Chen
562289a55a Always send a link preview for shared sticker packs. 2019-05-14 14:37:11 -04:00
Matthew Chen
a1c77bab63 Handle 'no installed stickers' case. 2019-05-14 14:19:01 -04:00
Matthew Chen
370a760e31 Respond to CR. 2019-05-14 14:17:58 -04:00
Matthew Chen
396abeffb1 Refine design of manage stickers view. 2019-05-14 14:00:02 -04:00
Matthew Chen
c87eb4df5c Clean up ahead of PR. 2019-05-14 13:55:50 -04:00
Matthew Chen
f03eece812 Share sticker pack flow. 2019-05-14 13:55:50 -04:00
Matthew Chen
51944236bf Sketch out sticker previews. 2019-05-13 16:20:13 -04:00
Matthew Chen
77f3701bcc Sketch out sticker previews. 2019-05-13 16:20:13 -04:00
Matthew Chen
105593c8ad Always check sticker validity before rendering. 2019-05-13 16:14:48 -04:00
Matthew Chen
1a60b4bc9c Surface an error to the user if sticker packs fail to install. 2019-05-13 12:54:49 -04:00
Matthew Chen
01b5e21290 Respond to CR. 2019-05-13 12:49:23 -04:00
Matthew Chen
75d4159f3f Rework sticker pack view. 2019-05-13 12:49:23 -04:00
Matthew Chen
5aeb9e205a Rework sticker pack view. 2019-05-13 12:49:23 -04:00
Matthew Chen
61bb5870da Respond to CR. 2019-05-09 13:18:16 -04:00
Matthew Chen
16b0b8cb21 Fix more sticker leaks. 2019-05-09 13:03:17 -04:00
Matthew Chen
bd980c294f Open sticker URLs. 2019-05-09 12:47:54 -04:00
Matthew Chen
ca349ace28 Respond to CR. 2019-05-08 09:38:31 -04:00
Matthew Chen
bfa40b84a3 Sticker refinements. 2019-05-08 09:26:39 -04:00
Matthew Chen
fe966e1f73 Sort sticker packs in keyboard header. 2019-05-08 09:24:08 -04:00
Matthew Chen
bc7afb7719 If there are no recents, default to showing the first sticker pack in sticker keyboard. 2019-05-08 09:02:42 -04:00
Matthew Chen
e11f33e6c5 Hide packs without available covers. 2019-05-06 14:22:08 -04:00
Matthew Chen
9fdcf6b0c1 Respond to CR. 2019-05-06 13:56:38 -04:00
Matthew Chen
a04b9595fa Sort sticker packs in sticker management view. 2019-05-06 13:44:38 -04:00
Matthew Chen
55ef7bd02f Sort sticker packs in sticker management view. 2019-05-06 13:44:38 -04:00
Michael Kirk
116241df3f renames for clarity, fail hard on db error 2019-05-03 09:53:37 -06:00
Matthew Chen
87f8314902 Pull out StickerHorizontalListView. 2019-05-03 09:24:12 -04:00
Matthew Chen
7ce0a0173c Pull out StickerHorizontalListView. 2019-05-03 09:24:12 -04:00
Matthew Chen
721c57ce08 Pull out StickerHorizontalListView. 2019-05-03 09:24:12 -04:00
Matthew Chen
7c56aefeae Pull out StickerHorizontalListView. 2019-05-03 09:23:15 -04:00
Matthew Chen
794a392f40 Fix bug in sticker operations. 2019-05-02 15:02:05 -04:00
Michael Kirk
36370980d1 Merge tag '2.39.0.9' 2019-05-01 15:14:47 -06:00
Michael Kirk
dafa3f12be Merge tag '2.39.0.8' 2019-05-01 14:34:15 -06:00
Michael Kirk
c6d7bc057f Rename SignalAttachmentItem -> AttachmentApprovalItem
No change in functionality, just trying to clarify what this "item" is for now
that it's being used more broadly.
2019-05-01 09:58:00 -06:00
Michael Kirk
0f12088cc6 Maintain image editor state when "adding more" 2019-05-01 09:50:09 -06:00
Matthew Chen
06b85e4c24 Respond to CR. 2019-05-01 10:04:09 -04:00
Matthew Chen
1ee8f71d1c More sticker-related navigation. 2019-05-01 09:56:07 -04:00
Matthew Chen
fb3bdf2ac2 Respond to CR. 2019-05-01 09:50:14 -04:00
Matthew Chen
bc4f35f5e2 Add the sticker pack view. 2019-04-30 16:41:14 -04:00
Matthew Chen
f0339ee1fe Fix edge cases around sticker interactions. 2019-04-30 09:40:48 -04:00
Matthew Chen
783858ea52 Remove extra semicolons. 2019-04-30 09:39:04 -04:00
Matthew Chen
77014b2d37 Fix issues around cell reuse, nested transactions. 2019-04-30 09:22:13 -04:00
Matthew Chen
f4a90edef5 Recent stickers. 2019-04-30 09:22:13 -04:00
Matthew Chen
60de1adff2 Improve sticker manager retry. 2019-04-30 09:15:08 -04:00
Michael Kirk
1b8bcfeb30 more padding for custom back button 2019-04-26 17:12:23 -07:00
Michael Kirk
e0a4ca10a3 Fix: cancelled back-navigation shows wrong buttons 2019-04-26 16:28:03 -07:00
Michael Kirk
6f66e12141 Avoid thumbnail flicker when loading approval view
Though it might in theory be a bit slower, it's not measurably slower, and the
flicker brought on by making this async is worse than a tiny delay.
2019-04-26 15:03:43 -07:00
Matthew Chen
6e38c29cd7 Respond to CR. 2019-04-26 12:19:14 -04:00
Matthew Chen
48df37519f Fix sticker keyboard layout. 2019-04-26 12:15:11 -04:00
Matthew Chen
4708963ebd Fix sticker keyboard layout. 2019-04-26 12:15:11 -04:00
Matthew Chen
93f0991597 Sketch out sticker keyboard. 2019-04-26 12:15:11 -04:00
Matthew Chen
fab8688ec6 Sketch out sticker keyboard. 2019-04-26 12:15:11 -04:00
Matthew Chen
342b662d17 Sketch out sticker keyboard. 2019-04-26 12:15:11 -04:00
Matthew Chen
5b4520f06a Sketch out sticker keyboard. 2019-04-26 12:15:11 -04:00
Michael Kirk
0f1cac16f0 only show caption if there is more than 1 attachment 2019-04-25 09:02:22 -07:00
Michael Kirk
1c5233aaa3 Use correct icon for "Add Caption" vs. "Has Caption" 2019-04-25 09:02:22 -07:00
Michael Kirk
920609adf0 remove landscape feature flag 2019-04-25 07:46:14 -07:00
Matthew Chen
1454773d99 Respond to CR. 2019-04-25 09:54:49 -04:00
Matthew Chen
b18d93e7c8 Refine sticker management. 2019-04-25 09:54:49 -04:00
Matthew Chen
cbbe4f2272 Sketch out sticker management views. 2019-04-25 09:54:49 -04:00
Matthew Chen
bef5a53b25 Sketch out sticker management views. 2019-04-25 09:54:49 -04:00
Matthew Chen
02b0a6f4b0 Sketch out sticker management views. 2019-04-25 09:54:13 -04:00
Matthew Chen
344f036ee5 Sketch out sticker management views. 2019-04-25 09:54:13 -04:00
Matthew Chen
785b91b01c Sketch out sticker management views. 2019-04-25 09:54:13 -04:00
Matthew Chen
10eefd2a98 Sketch out sticker management views. 2019-04-25 09:54:13 -04:00
Michael Kirk
38dbe6c913 Fix "content behind call banner" when status bar is hidden
The height of the call banner includes the height of the status bar,
even if the status bar is hidden.
2019-04-23 08:52:45 -07:00
Michael Kirk
19002a13b1 Cannot delete last item in rail 2019-04-22 13:44:48 -07:00
Michael Kirk
4af9fa6789 "add more" as rail cell 2019-04-22 13:44:48 -07:00
Michael Kirk
cfebb53719 more concise constants post translation 2019-04-04 13:44:42 -06:00
Michael Kirk
57b1aaa3dc inline enum converters 2019-04-04 13:44:42 -06:00
Michael Kirk
30266bf65e autoformatted 2019-04-04 13:44:42 -06:00
Michael Kirk
64a0c4bfaa auto-migrate to Swift5 2019-04-04 13:44:42 -06:00
Michael Kirk
07e88009e4 Merge tag '2.38.0.11' 2019-04-01 14:04:43 -06:00
Matthew Chen
a3efb58d15 Respond to CR. 2019-03-28 18:29:19 -04:00
Matthew Chen
517a550593 Further improve "first responder" behavior in the image editor. 2019-03-28 18:06:35 -04:00
Matthew Chen
eb5cf3978c Fix first responder issue in image editor. 2019-03-28 18:05:46 -04:00
Michael Kirk
fa2d5b422b maintain body text navigating to/from approval view 2019-03-28 11:58:43 -06:00
Michael Kirk
7dbb9517af Centralize attachment state in nav controller 2019-03-28 10:30:47 -06:00
Matthew Chen
db958f4a01 Preserve caption text of edited images. 2019-03-26 21:24:25 -06:00
Michael Kirk
f8244eeefe Fix SAE crash for iOS9 2019-03-26 17:08:36 -06:00
Matthew Chen
4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 2019-03-25 09:31:19 -04:00
Matthew Chen
558b5f5816 Tap to dismiss caption editor. 2019-03-21 15:21:36 -04:00
Matthew Chen
908fe1d0c9 Apply presentAlert() throughout codebase. 2019-03-21 10:58:49 -04:00
Matthew Chen
b48e204b90 Add accessibility identifiers to notification settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen
931d249677 Modify OWSFlatButton to propagate the accessibility identifier to wrapper button. 2019-03-21 10:08:25 -04:00
Matthew Chen
41a3c95831 Add missing accessibility ids in block list view. 2019-03-21 10:08:25 -04:00
Matthew Chen
8bcc19e36c Add missing accessibility ids in block list view. 2019-03-21 10:08:25 -04:00
Matthew Chen
050a9676f6 Add accessibility identifiers to select recipient views. 2019-03-18 14:11:37 -04:00
Matthew Chen
c3857e5dff Add accessibility identifiers to select recipient views. 2019-03-18 14:11:37 -04:00
Matthew Chen
79d6384bc9 Add accessibility identifiers to privacy settings view. 2019-03-18 14:11:37 -04:00
Matthew Chen
3795fd1381 Enable image editor in production. 2019-03-14 16:42:25 -04:00
Matthew Chen
684cebf2df Respond to CR. 2019-03-14 13:29:40 -04:00
Matthew Chen
a48c3d8d20 Ensure attachment approval becomes first responder if app returns from background. 2019-03-14 12:54:49 -04:00
Matthew Chen
f9445359d9 Fix layout glitch related to attachment approval input accessory background. 2019-03-14 12:54:49 -04:00
Matthew Chen
a559b61056 Fix keyboard return behavior in attachment approval. 2019-03-14 12:54:49 -04:00
Matthew Chen
660f35147f Hide status bar in image editor modals. 2019-03-14 12:54:49 -04:00
Matthew Chen
d824c49c07 Respond to CR. 2019-03-14 12:53:54 -04:00
Matthew Chen
d80f086f31 Rework attachment captioning. 2019-03-14 12:40:29 -04:00
Matthew Chen
625656deb9 Pull out attachment text toolbar and text view classes. 2019-03-14 12:40:29 -04:00
Matthew Chen
581d0a7bff Respond to CR. 2019-03-13 12:43:30 -04:00
Matthew Chen
4fd16a7614 Remove top gradient from attachment approval. 2019-03-13 12:25:02 -04:00
Matthew Chen
745ec2adb8 Remove top gradient from attachment approval. 2019-03-13 12:10:56 -04:00
Matthew Chen
0826864525 Decompose attachment approval into multiple source files. 2019-03-13 11:45:42 -04:00
Matthew Chen
337e32a909 Fix a shadow. 2019-03-12 17:34:31 -04:00
Matthew Chen
66efcb4639 Update rail icons. 2019-03-12 17:34:31 -04:00
Matthew Chen
7521b3a145 Update "attachment has caption" indicator. 2019-03-12 17:22:46 -04:00
Matthew Chen
e63b1169a3 Hide controls while moving text items. 2019-03-12 17:22:46 -04:00
Matthew Chen
fb6631df5f Remove cancel button from attachment caption view. 2019-03-12 17:22:46 -04:00
Matthew Chen
e2d54d082e Modify attachment approval back button to not have "back" text. 2019-03-12 17:22:46 -04:00
Matthew Chen
7a67a7b6b5 Hide the status bar in the image picker / attachment approval. 2019-03-12 17:22:46 -04:00
Matthew Chen
ff08919206 Respond to CR. 2019-03-11 23:25:13 -04:00
Matthew Chen
6fe3ce6d87 Deconflict "bottom view" layout and keyboard animations. 2019-03-11 23:23:08 -04:00
Matthew Chen
6e7c135348 Ensure onboarding views never reclaim layout space from dismissed keyboard. 2019-03-11 23:23:08 -04:00
Matthew Chen
d72c26796d Ensure onboarding views never reclaim layout space from dismissed keyboard. 2019-03-11 23:23:08 -04:00
Matthew Chen
53802d1a48 Deconflict "bottom view" layout and keyboard animations. 2019-03-11 23:23:08 -04:00
Matthew Chen
97603e64cc Deconflict "bottom view" layout and keyboard animations. 2019-03-11 23:23:07 -04:00
Michael Kirk
be523d5fe9 Merge branch 'release/2.37.0' 2019-03-04 14:43:48 -07:00
Matthew Chen
6cae61bf18 Revert "Temporarily enable image editor."
This reverts commit 1078756bc6.
2019-03-02 15:40:38 -05:00
Matthew Chen
49685c52bb Temporarily enable image editor. 2019-03-02 15:40:24 -05:00
Matthew Chen
22626bdffd Revert "Temporarily enable image editor."
This reverts commit 1078756bc6.
2019-03-01 16:49:35 -05:00
Matthew Chen
1078756bc6 Temporarily enable image editor. 2019-03-01 16:49:10 -05:00
Matthew Chen
371c12bd40 Show caption indicators in attachment approval media rail. 2019-03-01 15:42:22 -05:00
Matthew Chen
9be84fc912 Respond to CR. 2019-03-01 09:44:52 -05:00
Matthew Chen
d15f5b581f Tweak how image editor overlays are presented. 2019-03-01 09:36:12 -05:00
Matthew Chen
7ee38f808d Show "add attachment caption" button for non-media attachments; only show if more than one attachment. 2019-03-01 09:36:05 -05:00
Matthew Chen
82f18d8e4e Respond to CR. 2019-03-01 09:28:40 -05:00
Matthew Chen
63637af240 Clean up ahead of PR. 2019-03-01 09:07:03 -05:00
Matthew Chen
7c486d9093 Clean up image editor. 2019-03-01 09:07:03 -05:00
Matthew Chen
bc31c8fcf4 Add brush view controller. 2019-03-01 09:07:03 -05:00
Matthew Chen
e47ceab41c Use navigation bar for image editor buttons. 2019-03-01 09:06:36 -05:00
Matthew Chen
a630974e76 Use navigation bar for image editor buttons. 2019-03-01 09:06:36 -05:00
Matthew Chen
87646b1798 Replace old caption view with new caption view. 2019-03-01 09:06:36 -05:00
Michael Kirk
71dd4eb151 in-conversation search
- use MediaTime for computing benchmarks
2019-02-28 16:19:16 -07:00
Matthew Chen
be26c135e1 Rework image editor buttons, modes, etc. 2019-02-28 16:20:44 -05:00
Michael Kirk
3be41e8c25 Unless you're on a call, all windows respect the orientation mask of the
primary app visible VC.

Fixes:
- Avoid flicker when forgrounding onboarding while in landscape
- Fix status bar in landscape while fingerprint is portrait, same with device linker
2019-02-26 19:52:09 -07:00
Matthew Chen
69635fafac Update crop view to reflect design. 2019-02-26 13:28:44 -05:00
Michael Kirk
5bd3cec6dc Merge tag '2.36.1.0' 2019-02-26 10:07:54 -07:00
Michael Kirk
13154fb828 allow long text with non-durable sends (SAE) 2019-02-26 10:06:52 -07:00
Matthew Chen
72082edad8 Fix a visual bug that would sometimes occur while rendering settings switches. Thanks to Gunnar C. Pope for the bug report. 2019-02-25 15:13:16 -07:00
Michael Kirk
7e5256856c render media+longText message 2019-02-25 13:27:49 -07:00
Michael Kirk
b7989e9384 feature flag approval sending 2019-02-25 13:27:49 -07:00
Michael Kirk
bc4260b444 Send long-text with other attachments 2019-02-25 13:27:49 -07:00
Michael Kirk
680b844f3c Allow all windows to do landscape, fixes:
1. Remove undesirable animation from portrait->landscape when minimizizing in
   landscape and relaunching in landscape.

2. This also seems to fix the intermittently misplaced toolbar when launching
   in landscape. I believe this is a consequence of fix #1
2019-02-21 17:38:52 -07:00
Matthew Chen
aa8fd9e69c Remove old registration views. 2019-02-20 17:35:46 -05:00
Matthew Chen
4d4b840787 Respond to CR. 2019-02-19 13:59:53 -05:00
Matthew Chen
ef5cd5344e Fix the auto-format of phone numbers in the onboarding views. 2019-02-19 13:42:47 -05:00
Matthew Chen
b658866319 Sketch out the 'onboarding phone number' view. 2019-02-14 08:55:37 -05:00
Matthew Chen
2a4b9426c3 Sketch out the 'onboarding phone number' view. 2019-02-14 08:54:27 -05:00
Matthew Chen
618a3b1d47 Sketch out crop tool. 2019-02-13 16:43:41 -05:00
Matthew Chen
73b36c5400 Respond to CR. 2019-02-12 10:03:32 -05:00
Matthew Chen
3f8ea271b4 First draft of image editor's text tool. 2019-02-12 09:34:53 -05:00
Michael Kirk
d88ffc4775 Notification titles for iOS10+ 2019-02-04 10:35:17 -07:00
Matthew Chen
39de96ac26 Re-enable landscape orientation; fix 'double activation' issue. 2019-01-28 11:48:49 -05:00
Michael Kirk
896a9f78f7 limit media message body to 2k chars 2019-01-22 13:25:07 -07:00
Michael Kirk
3c0982e0f9 Fix missing captionView when navigating via RailView 2019-01-17 09:54:10 -07:00
Matthew Chen
be714399c7 Add feature flag for landscape orientation. 2019-01-16 16:49:25 -05:00
Matthew Chen
eab3599ce9 Add feature flag for landscape orientation. 2019-01-16 16:42:11 -05:00
Matthew Chen
635a644e2f Fix safe area insets in SAE. 2019-01-16 10:04:33 -05:00
Matthew Chen
4ab0c8fe58 Landscape orientation. 2019-01-09 15:22:55 -05:00
Matthew Chen
460f160cbb Landscape orientation. 2019-01-09 15:13:48 -05:00
Michael Kirk
0ab326da92 Only show delete button on selected rail item 2019-01-09 12:27:15 -07:00
Matthew Chen
5e3de84fdc Add feature flag for image editor. 2019-01-07 08:48:18 -05:00
Matthew Chen
8aa68327e6 Add primitive color picker. 2019-01-03 18:03:47 -05:00
Matthew Chen
b24e8e4f81 Use autoreleasepool when rendering image editor output. 2019-01-03 18:01:45 -05:00
Matthew Chen
17c3ba0580 Image editor fixes. 2019-01-03 16:56:24 -05:00
Michael Kirk
df79fc9ed0 Move String+OWS into SSK
name Switcharoo String+OWS/String+SSK categories to reflect where they live.
2018-12-20 09:54:08 -07:00
Matthew Chen
03cbeb5fee Start working on crop. 2018-12-19 14:48:37 -05:00
Matthew Chen
9378ab2192 Add undo/redo buttons to image editor. 2018-12-19 14:45:20 -05:00
Matthew Chen
d1cf942f7e Respond to CR. 2018-12-18 10:53:41 -05:00
Matthew Chen
794241963e Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
da13dc1d2e Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
639dac4e26 Add stroke drawing to the image editor. 2018-12-18 10:53:41 -05:00
Matthew Chen
b0e0c6e8c2 Replace edited attachments when sending. 2018-12-18 10:53:41 -05:00
Matthew Chen
e2afe27f5e Add trivial test interaction to image editor. 2018-12-18 10:53:41 -05:00
Matthew Chen
0d81139be5 Debug scaffolding. 2018-12-18 10:53:41 -05:00
Matthew Chen
4752cb94f5 Add ImageEditorView. 2018-12-18 10:53:41 -05:00
Michael Kirk
858ba6ef37 fix missing video thumbnails in approval view 2018-12-10 10:05:28 -07:00
Michael Kirk
3e48ed105d keyboard is always dark in attachment approval 2018-12-10 10:04:01 -07:00
Michael Kirk
2f92995cd6 Add placeholder text to message input field 2018-12-10 10:04:01 -07:00
Michael Kirk
de73c220da increment version canary 2018-12-05 13:56:34 -05:00
Michael Kirk
1a5c47df2f Fix SAE, limit max attachments 2018-12-05 13:56:34 -05:00
Matthew Chen
c7f5047056 Handle iCloud status. 2018-11-29 08:57:51 -05:00
Michael Kirk
71ab5817eb fix captionview visibility 2018-11-28 21:23:31 -07:00
Michael Kirk
61758dcf05 Only show caption for multiple images 2018-11-27 15:39:45 -07:00
Michael Kirk
0ac8f13c0b remove redunant method, consolidate naming, adding array getter 2018-11-27 15:39:45 -07:00
Michael Kirk
6fdd5d1001 dont initializer pagerScrollView as sideEffect 2018-11-27 15:39:45 -07:00
Michael Kirk
9bcc6a6c57 show navbar for photo/album picker, not approval 2018-11-27 10:27:13 -07:00
Michael Kirk
26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 2018-11-26 14:11:13 -07:00
Michael Kirk
9317ee9c99 design comment 2018-11-26 12:57:50 -07:00
Michael Kirk
e3120a5b87 cleanup keyboard animation code 2018-11-26 12:52:05 -07:00
Michael Kirk
55807f9a4d iPhoneX compatible keyboard animations 2018-11-26 12:43:28 -07:00
Michael Kirk
279694e704 keyboard animation cleanup 2018-11-26 12:43:28 -07:00
Michael Kirk
0808458392 fix caption dismiss animation/placeholder for multiline message body 2018-11-26 12:43:28 -07:00
Michael Kirk
4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
2018-11-26 12:43:28 -07:00
Michael Kirk
3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 2018-11-26 12:43:28 -07:00
Michael Kirk
b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
2018-11-26 12:43:28 -07:00
Michael Kirk
838012d1ec Caption length limit and label 2018-11-26 12:43:28 -07:00
Michael Kirk
e0f7513df0 white tint for attachment approval textview cursors 2018-11-26 12:43:28 -07:00
Michael Kirk
a946ec0056 new icon assets per design 2018-11-26 12:43:28 -07:00
Michael Kirk
8776dd1909 New "add caption" and "done" assets 2018-11-26 12:43:28 -07:00
Michael Kirk
feb5a0c444 fix initial CaptionView layout glitch 2018-11-26 12:43:28 -07:00
Michael Kirk
e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 2018-11-26 12:43:28 -07:00
Michael Kirk
33750baf67 finally got dismiss-before-swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
dd82803a10 second abandoned attempt to require dismiss before page 2018-11-26 12:43:28 -07:00
Michael Kirk
b98b3d1fdd WIP: require dismiss before swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
706dd3d0c1 initial layout of keyboard is correct across pages 2018-11-26 12:43:28 -07:00
Michael Kirk
280664c763 WIP: keyboard 2018-11-26 12:43:28 -07:00
Michael Kirk
eed2558050 Avoid glitch in keyboard dismiss.
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
2018-11-26 12:43:28 -07:00
Michael Kirk
8b5d1d9e69 Only add delete button once 2018-11-26 12:43:28 -07:00
Michael Kirk
28f8fc5911 per cr, avoid unnecessary 2018-11-26 12:37:58 -07:00
Michael Kirk
fcc4b516a5 fix typo in logging 2018-11-26 12:37:58 -07:00
Michael Kirk
4f0092615a Support captions *and* independent message body 2018-11-26 12:37:58 -07:00
Michael Kirk
cd88ef2bec CaptionView text field per page 2018-11-26 12:37:58 -07:00
Michael Kirk
79995cc52c rename captioning -> messageText
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
2018-11-26 12:37:58 -07:00
Michael Kirk
47affb81c0 Move gallery rail into input accessory view
TODO

-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
2018-11-26 12:37:58 -07:00
Matthew Chen
8b24fba095 Add "add more" button to image picker. Provide caption editing continuity. 2018-11-15 14:10:19 -05:00
Michael Kirk
87bfdbb72c Sender Rail 2018-11-15 12:25:28 -06:00
Matthew Chen
ea080eda72 Sketch out the photo collection picker. 2018-11-15 13:14:55 -05:00
Michael Kirk
92135af8be Merge branch 'release/2.32.0' 2018-11-15 10:38:43 -06:00
Michael Kirk
47a7114317 Gallery pager style changes 2018-11-15 10:16:51 -06:00
Matthew Chen
3135e6f6f7 Respond to CR. 2018-11-13 13:57:46 -05:00
Matthew Chen
aeadea67e2 Send multiple attachments from the share extension. 2018-11-13 13:15:54 -05:00
Matthew Chen
860eb44edc Fix breakage in share extension. 2018-11-13 13:15:11 -05:00
Matthew Chen
dd0f642ff2 Fix build break. 2018-11-07 11:53:24 -05:00
Michael Kirk
7cef41f8e2 Multi-approval 2018-11-07 10:09:21 -06:00
Matthew Chen
ecba67b511 Add debug UI for multi-image sends. 2018-11-02 13:04:05 -04:00
Michael Kirk
77bd9b8852 Extract most Gallery functionality from the gallery NavigationController.
By not overriding the initializer for an OWSNavigationController subclass,
we can use the dynamic disaptch intialization chain.

The root difficulty here is that super.init(navBarClass:) wants to call
self.init(nibNam)
2018-11-01 12:53:59 -06:00
Michael Kirk
6d8a7ed800 things working 2018-11-01 12:53:59 -06:00
Michael Kirk
1af750363a fix media-gallery doesn't respect call banner 2018-11-01 12:53:59 -06:00
Michael Kirk
19f2d0db48 WIP: Media Landscape Mode 2018-11-01 08:43:59 -06:00
Matthew Chen
40aa78e001 Merge remote-tracking branch 'origin/release/2.31.0' 2018-10-31 11:42:41 -04:00
Michael Kirk
3560f3be5c Durable send operation
TODO
-[x] respect order of queue
-[x] replacements
  -[x] those w/o completion handler
  -[x] basic send+log operation persists
  -[x] send+ui completion
  -[x] share extension
  -[x] update state jobs
-[x] App Lifecyle
  -[x] settable
  -[x] Mark as ready on startup
  -[x] Fail appropriate jobs on startup

NICE TO HAVE
-[x] concurrent per senders
-[ ] longer retry (e.g. 24hrs)
-[ ] App Lifecyle
  -[x] retry failed jobs on startup?
  -[ ] reachability

DONE
-[x] basic passing test
-[x] datamodel
-[x] queue/classes
2018-10-25 11:54:59 -06:00
Matthew Chen
28f37a7a34 Update contacts cells' dependencies. 2018-10-25 09:48:57 -04:00
Michael Kirk
ce9ca1bdaa audio player type 2018-10-24 07:46:27 -06:00
Michael Kirk
3d022adf4e WIP: audio activities 2018-10-24 07:44:50 -06:00
Matthew Chen
f1d93d4472 Merge remote-tracking branch 'origin/release/2.30.2' 2018-10-12 16:00:42 -04:00
Matthew Chen
71da312336 Post-SMK ud changes. 2018-10-02 13:19:41 -04:00
Michael Kirk
8faf8668bd lighter sheetview handle for dark theme 2018-10-02 09:49:37 -06:00
Michael Kirk
043b0c8359 swipe to dismiss sheet view 2018-10-02 09:49:37 -06:00
Matthew Chen
0125535d4d Pull out SignalCoreKit. 2018-10-01 09:06:40 -04:00
Matthew Chen
fbeb07d2e4 Fix build break. 2018-09-27 15:40:55 -04:00
Michael Kirk
4765ed9a06 Color picker
TODO

-[x] tap to select/deselect
-[x] initially selected
-[x] integrate into conversation settings
-[x] colorPickerDelegate
-[x] translate strings
-[] reorder colors
-[x] SheetView: add top handle

Nice to have:

-[] SheetView: interactively swipe/unswipe to dismiss?
-[] preview color in bubbles
2018-09-27 13:34:23 -06:00
Michael Kirk
95a6df6496 Generic SheetViewController 2018-09-27 13:34:23 -06:00
Joshua Lund
97d0543cef String cleanup:
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
2018-09-27 15:30:58 -04:00
Matthew Chen
b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 2018-09-27 09:07:47 -04:00
Matthew Chen
87836f506b Move more singletons to SSKEnvironment. 2018-09-21 09:06:48 -04:00
Matthew Chen
8cf5f3e58f New grayscale palette. 2018-09-20 10:14:20 -04:00
Matthew Chen
e1db60c1c0 Rework creation of singletons. 2018-09-19 15:11:26 -04:00
Michael Kirk
920a82564f Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
Matthew Chen
9b94580dae Update assertions.
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
2018-09-14 14:30:06 -04:00
Michael Kirk
eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
2018-09-12 19:16:14 -05:00
Michael Kirk
236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
2018-09-12 19:16:14 -05:00
Matthew Chen
3a12446be8 Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:41 -04:00
Michael Kirk
c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
2018-09-07 10:00:48 -06:00