signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
22,799 Commits 1 Branch 2,246 Tags 1.8 GiB
5bf94de2a6
Commit Graph

828 Commits

Author SHA1 Message Date
Michael Kirk
b98b3d1fdd WIP: require dismiss before swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
706dd3d0c1 initial layout of keyboard is correct across pages 2018-11-26 12:43:28 -07:00
Michael Kirk
280664c763 WIP: keyboard 2018-11-26 12:43:28 -07:00
Michael Kirk
eed2558050 Avoid glitch in keyboard dismiss. 
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
 2018-11-26 12:43:28 -07:00
Michael Kirk
8b5d1d9e69 Only add delete button once 2018-11-26 12:43:28 -07:00
Michael Kirk
28f8fc5911 per cr, avoid unnecessary 2018-11-26 12:37:58 -07:00
Michael Kirk
fcc4b516a5 fix typo in logging 2018-11-26 12:37:58 -07:00
Michael Kirk
4f0092615a Support captions *and* independent message body 2018-11-26 12:37:58 -07:00
Michael Kirk
cd88ef2bec CaptionView text field per page 2018-11-26 12:37:58 -07:00
Michael Kirk
79995cc52c rename captioning -> messageText 
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
 2018-11-26 12:37:58 -07:00
Michael Kirk
47affb81c0 Move gallery rail into input accessory view 
TODO

-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
 2018-11-26 12:37:58 -07:00
Matthew Chen
8b24fba095 Add "add more" button to image picker. Provide caption editing continuity. 2018-11-15 14:10:19 -05:00
Michael Kirk
87bfdbb72c Sender Rail 2018-11-15 12:25:28 -06:00
Matthew Chen
ea080eda72 Sketch out the photo collection picker. 2018-11-15 13:14:55 -05:00
Michael Kirk
92135af8be Merge branch 'release/2.32.0' 2018-11-15 10:38:43 -06:00
Michael Kirk
47a7114317 Gallery pager style changes 2018-11-15 10:16:51 -06:00
Matthew Chen
3135e6f6f7 Respond to CR. 2018-11-13 13:57:46 -05:00
Matthew Chen
aeadea67e2 Send multiple attachments from the share extension. 2018-11-13 13:15:54 -05:00
Matthew Chen
860eb44edc Fix breakage in share extension. 2018-11-13 13:15:11 -05:00
Matthew Chen
dd0f642ff2 Fix build break. 2018-11-07 11:53:24 -05:00
Michael Kirk
7cef41f8e2 Multi-approval 2018-11-07 10:09:21 -06:00
Matthew Chen
ecba67b511 Add debug UI for multi-image sends. 2018-11-02 13:04:05 -04:00
Michael Kirk
77bd9b8852 Extract most Gallery functionality from the gallery NavigationController. 
By not overriding the initializer for an OWSNavigationController subclass,
we can use the dynamic disaptch intialization chain.

The root difficulty here is that super.init(navBarClass:) wants to call
self.init(nibNam)
 2018-11-01 12:53:59 -06:00
Michael Kirk
6d8a7ed800 things working 2018-11-01 12:53:59 -06:00
Michael Kirk
1af750363a fix media-gallery doesn't respect call banner 2018-11-01 12:53:59 -06:00
Michael Kirk
19f2d0db48 WIP: Media Landscape Mode 2018-11-01 08:43:59 -06:00
Matthew Chen
40aa78e001 Merge remote-tracking branch 'origin/release/2.31.0' 2018-10-31 11:42:41 -04:00
Michael Kirk
3560f3be5c Durable send operation 
TODO
-[x] respect order of queue
-[x] replacements
  -[x] those w/o completion handler
  -[x] basic send+log operation persists
  -[x] send+ui completion
  -[x] share extension
  -[x] update state jobs
-[x] App Lifecyle
  -[x] settable
  -[x] Mark as ready on startup
  -[x] Fail appropriate jobs on startup

NICE TO HAVE
-[x] concurrent per senders
-[ ] longer retry (e.g. 24hrs)
-[ ] App Lifecyle
  -[x] retry failed jobs on startup?
  -[ ] reachability

DONE
-[x] basic passing test
-[x] datamodel
-[x] queue/classes
 2018-10-25 11:54:59 -06:00
Matthew Chen
28f37a7a34 Update contacts cells' dependencies. 2018-10-25 09:48:57 -04:00
Michael Kirk
ce9ca1bdaa audio player type 2018-10-24 07:46:27 -06:00
Michael Kirk
3d022adf4e WIP: audio activities 2018-10-24 07:44:50 -06:00
Matthew Chen
f1d93d4472 Merge remote-tracking branch 'origin/release/2.30.2' 2018-10-12 16:00:42 -04:00
Matthew Chen
71da312336 Post-SMK ud changes. 2018-10-02 13:19:41 -04:00
Michael Kirk
8faf8668bd lighter sheetview handle for dark theme 2018-10-02 09:49:37 -06:00
Michael Kirk
043b0c8359 swipe to dismiss sheet view 2018-10-02 09:49:37 -06:00
Matthew Chen
0125535d4d Pull out SignalCoreKit. 2018-10-01 09:06:40 -04:00
Matthew Chen
fbeb07d2e4 Fix build break. 2018-09-27 15:40:55 -04:00
Michael Kirk
4765ed9a06 Color picker 
TODO

-[x] tap to select/deselect
-[x] initially selected
-[x] integrate into conversation settings
-[x] colorPickerDelegate
-[x] translate strings
-[] reorder colors
-[x] SheetView: add top handle

Nice to have:

-[] SheetView: interactively swipe/unswipe to dismiss?
-[] preview color in bubbles
 2018-09-27 13:34:23 -06:00
Michael Kirk
95a6df6496 Generic SheetViewController 2018-09-27 13:34:23 -06:00
Joshua Lund
97d0543cef String cleanup: 
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
 2018-09-27 15:30:58 -04:00
Matthew Chen
b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 2018-09-27 09:07:47 -04:00
Matthew Chen
87836f506b Move more singletons to SSKEnvironment. 2018-09-21 09:06:48 -04:00
Matthew Chen
8cf5f3e58f New grayscale palette. 2018-09-20 10:14:20 -04:00
Matthew Chen
e1db60c1c0 Rework creation of singletons. 2018-09-19 15:11:26 -04:00
Michael Kirk
920a82564f Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
Matthew Chen
9b94580dae Update assertions. 
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
 2018-09-14 14:30:06 -04:00
Michael Kirk
eadb04efcc WIP: ContactViewHelper incorporates group blocking 
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
 2018-09-12 19:16:14 -05:00
Michael Kirk
236c17f65e WIP: group blocking 
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
 2018-09-12 19:16:14 -05:00
Matthew Chen
3a12446be8 Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:41 -04:00
Michael Kirk
c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics 
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
 2018-09-07 10:00:48 -06:00
Matthew Chen
f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 2018-09-04 09:27:41 -04:00
Michael Kirk
e715bf9ea2 image sizing 
Validate image sizing
 2018-08-30 19:21:38 -06:00
Matthew Chen
cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
03829779cc Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
c0d486b1f1 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Matthew Chen
5b50e81b4f Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
Matthew Chen
7be8f30877 Apply -> Never. 2018-08-27 10:21:03 -04:00
Matthew Chen
cf6f3841a8 Apply new Swift logging. 2018-08-27 10:02:28 -04:00
Michael Kirk
82e559d11b Use swift macros for main thread assert 2018-08-23 10:29:49 -06:00
Matthew Chen
cb827169fb Respond to CR. 2018-08-22 16:30:12 -04:00
Michael Kirk
e435358bfd Revert "Add custom themed search bar." 
This reverts commit 8daaef22da.
 2018-08-22 12:00:44 -06:00
Michael Kirk
b80d88c824 theme attachment approval keyboard 
// FREEBIE
 2018-08-20 12:26:48 -06:00
Matthew Chen
c7ed09ed91 Fix 'can't delete formatting in phone number' issue. 2018-08-17 14:25:34 -04:00
Matthew Chen
8daaef22da Add custom themed search bar. 2018-08-17 12:43:35 -04:00
Matthew Chen
decb0c54ca Theme review. 2018-08-16 17:30:08 -04:00
Matthew Chen
4ea5d9b849 Theme review. 2018-08-16 17:30:07 -04:00
Matthew Chen
a76d488e8b Fix QA issues in theme. 2018-08-15 17:09:59 -04:00
Matthew Chen
22dda476bb Fix QA issues in theme. 2018-08-15 16:29:13 -04:00
Matthew Chen
26001e49d1 Unify log tags. 2018-08-15 10:24:29 -04:00
Michael Kirk
ebd2e6d5ac Tweak theme 2018-08-09 16:43:25 -06:00
Michael Kirk
c05700fd98 Log in OWSFail 
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
 2018-08-09 15:30:19 -06:00
Matthew Chen
3fc3425605 Theme search bars. 2018-08-09 14:02:29 -04:00
Matthew Chen
800689d9ff Configure default cells. 2018-08-09 14:00:37 -04:00
Matthew Chen
6dfe36f9b5 Respond to CR. 2018-08-08 15:49:22 -04:00
Matthew Chen
816f02fbab Fix unintentional moves. 2018-08-08 15:13:07 -04:00
Matthew Chen
9c92719ec4 Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen
5ef0b6d056 Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen
acd7d094b1 Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen
a543cd5a4e Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen
4f8dbf39b5 Refine theme. 2018-08-08 15:04:23 -04:00
Michael Kirk
78ad597e44 Merge tag '2.28.0.15' 2018-07-31 17:36:37 -06:00
Michael Kirk
def8b43daa iOS9/10 fixups 2018-07-31 15:14:09 -06:00
Michael Kirk
78b4df95a5 fixup call banner offsets 2018-07-31 11:41:08 -06:00
Matthew Chen
fa8a07abf1 Respond to CR. 2018-07-26 10:54:45 -04:00
Matthew Chen
f795b12a86 Refine theme. 2018-07-26 09:42:48 -04:00
Matthew Chen
2b1f928770 Respond to CR. 2018-07-20 15:47:37 -04:00
Matthew Chen
48975eaac8 Respond to CR. 2018-07-20 15:37:47 -04:00
Matthew Chen
8862f9a531 Refine views. 2018-07-20 15:26:46 -04:00
Matthew Chen
fcbf8d4dc2 Refine views. 2018-07-20 15:26:46 -04:00
Matthew Chen
9f9e0965d5 Refine table views. 2018-07-20 15:26:46 -04:00
Michael Kirk
d591fb7f2c Fix some compiler warnings 2018-07-17 19:22:58 -06:00
Matthew Chen
0c453c8d57 Fix content insets. 2018-07-17 14:51:10 -06:00
Michael Kirk
06b4584e02 move fix to OWSViewController 2018-07-16 12:52:50 -06:00
Matthew Chen
f6eb8dfe72 Refine app settings view. 2018-07-13 09:28:09 -04:00
Matthew Chen
20d1d11259 Refine home view. 2018-07-13 09:28:09 -04:00
Michael Kirk
28abf426f1 White status bar for call screen 
Transition to VC controlled status bar style.
 2018-07-10 11:36:40 -06:00
Michael Kirk
ee898829a1 fixup white nav 2018-06-29 16:49:24 -06:00
Matthew Chen
3f9f2abcd8 Style the search results. 2018-06-13 12:34:24 -04:00
Michael Kirk
72e4de0950 Fix unresponsive interface after swipe on root VC 
Don't start interactive pop gesture for root VC

// FREEBIE
 2018-06-12 10:43:31 -04:00
Matthew Chen
40879461b0 Suppress animations in nav bar around call window. 2018-05-30 15:44:45 -04:00
Matthew Chen
28e26e1f75 Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Michael Kirk
fc34a0643c CR: annotate device constants 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
36ee6af621 respond to CR 2018-05-24 12:28:20 -04:00
Michael Kirk
20424d9a7e remove debug code, reorder for clarity 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
4f80100234 Tapping on status bar returns to call 
We want to render the return-to-call banner behind the status bar, so
the user can see the system clock, etc.

But normally, doing so would mean we wouldn't receive touches in the top
20px of the screen.

// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
4c9808d1a1 Fix iPhoneX layout show status bar above call banner 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
3383c5e80c Fixup for iPhoneX 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
778e11c2c3 cleanup ahead of PR 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
7ad5f15448 Restore cancleable back gesture for those VC's that use it 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
1b60716759 Stop worrying about notification order by using delegate pattern 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
319a6ff765 fixup behavior on iOS10 2018-05-24 12:28:20 -04:00
Michael Kirk
29d08545e2 Use OWSNavigationController instead of UINavigationController 
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
 2018-05-24 12:28:20 -04:00
Michael Kirk
33eb4c38cd Centralize translucency configuration 
// FREEBIE
 2018-05-24 12:28:20 -04:00
Matthew Chen
edabe50678 Respond to CR. 2018-05-14 12:05:14 -04:00
Matthew Chen
a26cba3de1 Don't show screen block until app is ready. 2018-05-14 12:05:14 -04:00
Matthew Chen
9364af9b85 Make screen block view first responder. 2018-04-25 09:56:53 -04:00
Matthew Chen
08d36aa862 Add screen lock UI to SAE. 2018-04-20 16:39:35 -04:00
Matthew Chen
644e78f19d Respond to CR. 2018-04-13 14:32:42 -04:00
Michael Kirk
86553b62f9 keyboard pinning vs iPhoneX 2018-04-02 17:38:13 -04:00
Michael Kirk
af5f549e49 Fix TableView layout for iPhoneX 
// FREEBIE
 2018-04-02 17:02:32 -04:00
Matthew Chen
e12a1e984a Work on two-factor auth settings UI. 2018-03-01 15:38:59 -05:00
Matthew Chen
1f6cbd399e Sketch out 2FA feature. 2018-03-01 15:38:59 -05:00
Matthew Chen
a837c5d41b Custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen
980b3d25a7 Rework "export backup" UI. 2018-01-11 10:42:27 -05:00
Matthew Chen
9a990b58e8 Respond to CR. 2017-12-19 11:38:25 -05:00
Michael Kirk
a58f1f385c Share a photo from photos app 
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
 2017-12-07 10:13:06 -05:00