This change should have no user impact, but makes a future change
easier.
`ActionSheetController` supports string messages, but now it also
supports `NSAttributedString` messages. That lets us include styling
(like bold) and links.
This change should have no user impact.
This makes a few changes to `OWSActionSheets`:
- `OWSActionSheets` is now an enum (with an Objective-C bridge)
- Some unnecessary methods were removed
- Fixed some long lines
It also removes the payment-specific
`OWSActionSheets.showPaymentsOutdatedClientSheetIfNeeded` extension. It
didn't add much and required passing a global object, so I removed it.
Change appearance of controls in media viewer:
• use dark chrome background for top and bottom panels.
• move "Delete" into (•••) submenu at the top.
Appearance tweaks for media album strip at the bottom of media viewer.
• update design to latest spec.
• make media strip view configurable (border color and width, size, corner rounding).
* Go to chat list view after registration
* sync system contacts during registration
* Use explicit local credentials for storage service operations during registration
* fix tests
* Quick hack to get through double pin confirmation
* Finishing touches
* lint
* fix build
* reload phone number discoverability after storage service sync
* fix tests again
* Take chat auth on account and contact record initializers
* Change around branches for clarity in OWSUserProfile
* pr comments
* Split ChatServiceAuth into the same and AuthedAccount
* fix tests
* merge woes
Since it's not possible to set different radius for different corners of a CALayer I had to use a masking layer instead.
Assignment of CALayer.mask cannot be animated so I had to animate path of CSShapeLayer that serves as a mask layer. CAShapeLayer.path isn't implicitly animatable and workaround for that is copying bounds.size animation and attaching that to the masking layer.
* Hook up RegistrationPhoneNumberViewController
* Fix existing tests
* add some new tests; fix test scaffolding bug
* Show an error before going back to phone number entry if the session is invalidated
This renames `RegistrationPhoneNumber` to
`Deprecated_RegistrationPhoneNumber`, which should have no user impact.
This will be useful for an upcoming change.
This change should have no user impact. I made sure I could go through
registration as normal after this change.
`RegistrationCountryState` was an `NSObject` and now it's a Swift-only
struct. (It still requires `Dependencies` for now, but I think this is
an improvement.)
* payment lock
* add 30 day timeout to showing the payment lock suggestion
* fix linting
* update comment
* Payment Lock: Fix project file & submodules (#4878)
* revert ringrtc changes
* revert pods changes
* fix project file
* PR Comment suggestions and fixes
* PR suggestions
* revert screen lock to previous implementation
* rename OWSPaymentLock to OWSPaymentsLock (missing plural s), remove
super-class dependency. Make OWSPaymentsLock more "swifty".
* revert changes to call-site for OWSScreenLock
* update call-sites for OWSPaymentsLock
* forgot to add PaymentOnboarding class and localization comment improvements
* change function call-site
* Remove OWSLocalAuthentication from project
* remove OWSLocalAuth from project file
* make edge-case default more secure if storage not ready
* fix project file
* lint fix
* fix linting errors
* Revert compact format style for OWSLocalizedString
* fix localization call-sites to use literals, update localization file after autogen
* Add new Payments Lock Prompt view to be shown after activating payments. Factor out the BiometryType "current biometry" into its own class with helpers to easily getting the devices current setup.
* fix linting issues, sort project file, and autogen localizations
* require payments lock to look at the recovery phrase
* fix linting issue
* fix missing localizations (caused by dynamic creation in previous commit)
* use Pods commit from signal/main
* re-run linter on latest commits
* new header comments for new branch files
* update submodule commits
* Use existing secondsInDay constant kDayInterval, use weak self guard statement instead of optional self in escaping closure.
* Revert submodule changes
* Remove duplicate copyright headers
* Revert copyright header changes
* Restore some missing translations
* Add localization for unknown LocalAuthentication error/state.
* remove Pods changes
* linting
* use submodule commits from main
* subclass the old Objc OWSViewController super-class, should fix CICD
* change capitalized Passcode to lower-case in non-title situation.
* remove early exit guard from biometryType computed function. Reason being that the type can be gathered from a policy that evaluates to false. In a case where the user has a FaceID phone but its disabled, the messaging would be incorrect. removing the early exit evaluates the biometryType which apple provides even if the policy returns false.
* inline snooze date
* inject write transaction to some convenience methods to reduce database overhead when multiple calls need to happen at the same time.
* make combined set and snooze function, update combined call-site
* rename long function
* use false instead of sender.on to avoid sneaky view issues
* add tryToUnlockPromise function to clean up call sites
* change superclass, fix Promise statement
* call super class function
* remove objc
* add unlock failed action sheet helper class and put at all relevant call-sites, still need to test though.
* add unlock failed action sheet helper class and put at all relevant call-sites, still need to test though. linting
* project file changes for new file
* re-render payments lock toggle after failure to change setting.
re-render payments lock toggle after failure to change setting.
* move around action sheet call-site to account for an action sheet already being presented. remove unecc. return
* fix merge conflicts, linting
* re-gen strings file
---------
Co-authored-by: Max Radermacher <max@signal.org>
CVTextLabel incorrectly attempts to set default .font
and .foregroundColor on the label text, removing any
existing font & color attributes. This results
in unreadable text when displaying search results.
Instead, add helper method to set default attributes on
attributed strings, but only on ranges that don't have the
attribute already defined.
