Commit Graph

33 Commits

Author SHA1 Message Date
Max Radermacher
174ee9ae86 "Bump build to 6.17.0.0." (nightly-03-08-2023) 2023-03-08 16:12:45 -08:00
Evan Hahn
b733bffa2c
Wipe debug logs from very old versions 2023-03-01 17:00:58 -06:00
Evan Hahn
41ff3c142b
Rewrite debug log scrubbing logic in Swift
Also introduces additional defense-in-depth improvements.
2023-02-28 15:55:00 -06:00
Evan Hahn
491daa3e7d
"qa" → "internal"
This change should have no user impact. It renames "qa" to "internal"
for clarity.
2022-12-12 15:54:08 -06:00
Evan Hahn
370ff654e7
Change license to AGPL
Change license to AGPL

This commit:

- Updates the `LICENSE` file

- Start every file with something like:

      // Copyright YEAR_FIRST_PUBLISHED Signal Messenger, LLC
      // SPDX-License-Identifier: AGPL-3.0-only

---

First, I removed existing license headers with this Ruby 3.1.2 script:

    require 'set'

    EXTENSIONS_TO_CHECK = Set['.h', '.hpp', '.cpp', '.m', '.mm', '.pch', '.swift']

    same = 0
    different = 0

    all_files = `git ls-files`.lines.map { |line| line.strip }
    all_files.each do |relative_path|
      if relative_path == 'Pods'
        next
      end

      unless EXTENSIONS_TO_CHECK.include? File.extname(relative_path)
        next
      end

      path = File.expand_path(relative_path)

      contents = File.read(path)
      new_contents = contents.sub(/\/\/\n\/\/  Copyright .*\n\/\/\n\n/, '')

      if contents == new_contents
        same += 1
      else
        different += 1
      end

      File.write(path, new_contents)
    end

    puts "updated #{different} file(s), left #{same} untouched"

I'm sure this script could be improved, but it worked well enough.

Then, I created `Scripts/lint/lint-license-headers` and ran it to auto-
fix a lot of files. This changed the mode of some files, but I think
that's actually desirable. For example,
`SignalServiceKit/src/Util/AppContext.m` previously had a mode of
`0755/-rwxr-xr-x`, and it's now `0644/-rw-r--r--`.

Then I fixed some stragglers and updated the precommit script.

See [a similar change in the Desktop app][0].

[0]: 8bfaf598af
2022-10-13 08:25:37 -05:00
Michelle Linington
4ada6b3a3f Derive bundle ID from an Xcode build setting
See [#5423][5423].

[5423]: https://github.com/signalapp/Signal-iOS/pull/5423
2022-09-21 18:10:42 +00:00
Harry
8ab9505d75
Ignore failures to clean up dotfiles in logs directory on simulators 2022-08-25 16:24:19 -07:00
Michelle Linington
c21b7dc6ee Update min version. Last completed version stores a 3-version 2022-04-14 18:04:16 -07:00
Michelle Linington
460bce289e PR Feedback: Use existing lastLaunchVersion key 2022-04-14 18:04:16 -07:00
Michelle Linington
c19fa8b950 Improve log cleanup on launch 2022-04-14 16:23:21 -07:00
Jordan Rose
d7ed13ec63 Fix extension log file deletion
The expression for the relative cutoff timestamp was
`-self.maximumNumberOfLogFiles * kDayInterval`, but
'maximumNumberOfLogFiles' is an unsigned integer, so this turned into
"some day very far in the future" and immediately deleted all
extension logs. The new expression, `self.maximumNumberOfLogFiles *
-kDayInterval` works because 'kDayInterval' is an NSTimeInterval, a
floating-point value.
2022-03-08 16:24:29 -08:00
Jordan Rose
c7197c8517 Clear old extension logs when rotating the main app logs
Otherwise, logs from infrequently launched extensions (like the share
extension) can stick around much longer than we intend.
2022-03-04 13:57:29 -08:00
Matthew Chen
18bc6e411e Tidy up debug logs. 2021-11-23 09:42:20 -03:00
Matthew Chen
de7b0e0a21 Disable file logging in tests. 2021-08-24 18:32:23 -03:00
Matthew Chen
734085d3d1 Improve logging around profile avatar filenames. 2021-07-08 10:28:06 -03:00
Matthew Chen
8d5e319f12 Fix production build break. 2020-10-23 14:37:28 -03:00
Matthew Chen
1e8c8980fc Rework debug log file handling. 2020-10-23 14:10:00 -03:00
Matthew Chen
819321e4ef Rename singleton accessors. 2020-09-17 21:11:09 -03:00
Matthew Chen
c017e76aab Rename singleton accessors. 2020-09-17 21:11:09 -03:00
Matthew Chen
ad6bda8a44 Rename singleton accessors. 2020-09-17 21:11:07 -03:00
Michael Kirk
c1f859f746 audible error logging is configurable, disabled by default 2019-09-13 10:31:17 -07:00
Michael Kirk
4371c696dc Audible Debug Assertions in dev-qa builds 2019-08-21 09:01:43 -06:00
Matthew Chen
0125535d4d Pull out SignalCoreKit. 2018-10-01 09:06:40 -04:00
Matthew Chen
cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Matthew Chen
4746948dfe Respond to CR. 2018-03-14 10:02:44 -03:00
Matthew Chen
864f1cc8ee Clean up ahead of PR. 2018-03-02 17:44:14 -05:00
Matthew Chen
06d16bdec5 Revert "Revert "Merge branch 'charlesmchen/debugLogs' into hotfix/2.20.1""
This reverts commit b1dd325ce8.
2018-03-02 17:44:14 -05:00
Matthew Chen
e77c3e6717 Retain changes from session database branch. 2018-01-10 12:18:23 -05:00
Michael Kirk
06f52deaf9 address some additional compiler warnings 2017-12-04 12:52:59 -05:00
Matthew Chen
98eb4613ed Enable logging in SAE; rework log file management to include multiple log directories. 2017-12-01 12:55:47 -05:00
Matthew Chen
bf21d0c0ed Enable logging in SAE; rework log file management to include multiple log directories. 2017-12-01 12:55:47 -05:00
Matthew Chen
e7b32899cb Sketch out SAE load screen; make a number of infrastructure changes. 2017-12-01 09:37:52 -05:00