Commit Graph

6427 Commits

Author SHA1 Message Date
Michelle Linington
4e34715e51 IOS-1618: Failed deserialization of sender key metadata
Setting a nil value in SDSKeyValueStore encodes "nil" to data and stores
that in the database. When we fetch, we fail to deserialize since we're
expecting a key metadata struct.

Instead, we should use removeValue(forKey:transaction:) to remove the value
2021-07-28 11:23:17 -07:00
Matthew Chen
d2a7d3e757 Merge branch 'release/5.17.0' 2021-07-28 12:29:30 -03:00
Matthew Chen
3d6a3ef21b "Feature flags for .beta." 2021-07-28 12:28:05 -03:00
Matthew Chen
3cce412c7e "Feature flags for .production." 2021-07-28 12:27:34 -03:00
Matthew Chen
3e7def58ec Refine announcement-only capability. 2021-07-28 12:02:25 -03:00
Matthew Chen
f27e260019 Refine announcement-only capability. 2021-07-28 12:00:45 -03:00
Matthew Chen
088c1e1d34 Refine announcement-only capability. 2021-07-28 11:49:07 -03:00
Nora Trapp
52397ab045 "Feature flags for .beta." 2021-07-27 19:42:38 -07:00
Nora Trapp
b905d4883d "Feature flags for .production." 2021-07-27 19:42:19 -07:00
Nora Trapp
67db085639 "Feature flags for .beta." 2021-07-27 12:17:05 -07:00
Nora Trapp
d6b7c4f263 "Feature flags for .production." 2021-07-27 12:16:53 -07:00
Nora Trapp
540df3934d Merge branch 'release/5.17.0' 2021-07-26 14:47:30 -07:00
Nora Trapp
a0b54a814c "Feature flags for .beta." 2021-07-26 14:46:02 -07:00
Nora Trapp
07ccb63f40 "Feature flags for .production." 2021-07-26 14:45:48 -07:00
Nora Trapp
f391708cdc Clear avatarBuilder megaphone if you already have an avatar 2021-07-26 14:45:34 -07:00
Nora Trapp
2743f3f90e "Feature flags for .beta." 2021-07-26 14:09:23 -07:00
Nora Trapp
c6d345d735 "Feature flags for .production." 2021-07-26 14:09:10 -07:00
Nora Trapp
edd880cbed Default sender key on for internal builds 2021-07-23 21:20:39 -07:00
Nora Trapp
7a8fbcc9f4 Don't allow sending high quality outside of the main app 2021-07-23 21:20:08 -07:00
Nora Trapp
cb4adf60f0 Fix NSE crash 2021-07-23 21:20:08 -07:00
Nora Trapp
0628f33f8d Merge branch 'release/5.17.0' 2021-07-23 15:29:28 -07:00
Nora Trapp
97fcc4613c Avatar Builder Megaphone & Onboarding Card 2021-07-23 13:28:51 -07:00
Michelle Linington
b3315bca86 Add SenderKey remote config flag 2021-07-23 12:33:20 -07:00
Nora Trapp
fdccbd71a6 Allow image quality selection 2021-07-22 13:57:25 -07:00
Nora Trapp
c4a5cd13ab "Feature flags for .qa." 2021-07-22 13:38:21 -07:00
Nora Trapp
5c96af4d43 Merge branch 'release/5.17.0' 2021-07-22 13:38:07 -07:00
Nora Trapp
78e0e55392 "Feature flags for .beta." 2021-07-22 13:35:06 -07:00
Eugene Bistolas
8b8760319d Context Menus: Implement context menu reaction picker bar / accessory view support 2021-07-22 09:04:06 -10:00
Michelle Linington
4c637e9276 Fix test compilation
The tests would fail to compile when importing public SignalServiceKit
headers. These public headers were not correctly specifying they're own
imports in a way that external dependencies would recognize.
2021-07-21 23:47:25 -07:00
Michelle Linington
2dc6a1acb2 Re-lint in preparation of merge 2021-07-21 23:01:12 -07:00
Michelle Linington
5b2312787b PR Feedback and bug fixes
- Our SQL schema generator doesn't like "=="
- Various terrible compile time issues that I had missed
- Migrated OWSOutgoingResendResponse from Swift to ObjC. Mantle doesn't
  do great with coding Swift objects. This fixed the bug that was
  preventing resend from working. Resend works correctly now!
2021-07-21 22:58:51 -07:00
Michelle Linington
c443af4d72 Additional logging. Payload expiration checks. 2021-07-21 22:58:51 -07:00
Michelle Linington
36228c6d5f Additional annotation of outgoing messages for MSL 2021-07-21 22:58:51 -07:00
Michelle Linington
fd54a0af41 Regenerate SQL, minor comment fixes 2021-07-21 22:58:51 -07:00
Michelle Linington
51f3a58a61 Message send log recording and resend responses 2021-07-21 22:58:51 -07:00
Michelle Linington
c157461e55 PR Feedback 2021-07-21 22:58:51 -07:00
Michelle Linington
023b080dc3 PR Feedback: Remove leftover SDS definitions 2021-07-21 22:58:51 -07:00
Michelle Linington
d17a78245d PR Feedback: Tweaks to how interaction replacement operates 2021-07-21 22:58:51 -07:00
Michelle Linington
9269569ed4 Bug fix around resend fulfillment 2021-07-21 22:58:51 -07:00
Michelle Linington
2eb60643b7 Sender key decryption failure handling
Most of the work for message resend requests. Includes some rudimentary
failure UI.
2021-07-21 22:58:51 -07:00
Michelle Linington
273a1d3440 PR Feedback: Add assert 2021-07-21 22:58:51 -07:00
Michelle Linington
6961143b21 Bug fixing around key persistence and SKDM tracking 2021-07-21 22:58:51 -07:00
Michelle Linington
12e8d3b675 PR Feedback: Consolidate write transactions 2021-07-21 22:58:51 -07:00
Michelle Linington
c4bbcc0243 Sender key rotation and expiration 2021-07-21 22:58:51 -07:00
Michelle Linington
05de979ece PR Feedback 2021-07-21 22:58:51 -07:00
Michelle Linington
e40c51dacb SenderKey error handling 2021-07-21 22:58:51 -07:00
Michelle Linington
fb82e07654 PR Feedback 2021-07-21 22:58:50 -07:00
Michelle Linington
2b92590908 Sender key send 2021-07-21 22:58:50 -07:00
Michelle Linington
9c8b225330 PR Feedback and lint 2021-07-21 22:58:50 -07:00
Michelle Linington
59f2015fba Add OWSOutgoingSenderKeyDistributionMessage
When preparing to send a SenderKey message, we'll need to send out an
SKDM to participants. Although these can be tacked on to any message,
we'll need an outgoing message builder for these dedicated messages.
2021-07-21 22:58:50 -07:00