signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
27,252 Commits 1 Branch 2,246 Tags 1.8 GiB
451fa08c22
Commit Graph

57 Commits

Author SHA1 Message Date
Matthew Chen
fc749b4d72 Change phone number. 2021-11-19 14:28:18 -03:00
Matthew Chen
5d780d1589 Apply script to normalize includes and imports. 2021-10-21 09:21:10 -03:00
Michelle Linington
6f4d3ea56a Remove debug log messages and lint 2021-10-04 09:53:37 -03:00
Michelle Linington
8446ab4069 Minor changes to folder selection and restoration cleanup 2021-10-04 09:53:36 -03:00
Matthew Chen
9d26b47043 Streamline prod logs. 2021-09-20 17:52:11 -03:00
Matthew Chen
b28131de13 Refine error localizedDescription. 2021-08-18 15:01:03 -03:00
Matthew Chen
37052a302a Fix build warnings around imports. 2021-06-07 11:11:30 -04:00
Matthew Chen
d9d9989807 Changes for measuring manual stack view performance. 2021-04-15 16:00:57 -03:00
Michelle Linington
d899e55873 Tiny fix for failDebug during temp cleanup 
We have a comment here explaining why this could fail. We shouldn't
fail debug if this is expected to occur occasionally
 2020-09-14 09:00:08 -07:00
Michelle Linington
56f3f3d3d8 IOS-832: Device transfer flow should handle missing folders 
A user hit an issue on an iPhone 5s. Device transfer would fail because
their app group was missing the ProfileAvatars directory.

This directory is lazily created as a post-launch job at background QoS.
It's not too big of a deal and it'll be created on demand if necessary.
The 5s was probably CPU constrained enough to never have a chance to run
any background jobs.

The fix is to just have our recursive filesystem traversal ignore any
unknown directory errors. This is only used in a couple places and the
behavior makes sense in each place.
 2020-09-10 15:27:10 -07:00
Matthew Chen
7fe869de41 Fix race in "protect temporary file" logic. 2020-09-04 15:56:07 -03:00
Matthew Chen
aa6b269269 Resumable attachment download. 2020-08-01 12:18:13 -03:00
Matthew Chen
587b8f2c36 Resumable attachment download. 2020-08-01 12:18:13 -03:00
Michael Kirk
61f7a66c21 perf updates: spending 2% of our time finding the cache directory 2019-11-19 11:01:31 -07:00
Michael Kirk
12b786fe9d convert DataSource to protocol, double down on URLs vs filepaths 2019-08-12 15:11:40 -06:00
Matthew Chen
eccfad0f46 Merge remote-tracking branch 'private/release/2.41.0' 2019-08-06 12:12:39 -03:00
Matthew Chen
4f03f969fc Rework "view once" messages. 2019-08-01 16:13:37 -03:00
Matthew Chen
4d05761980 Remove YDB connections. 2019-07-25 10:35:19 -03:00
Matthew Chen
b57ebb05d4 Clean up orphans. 2019-05-21 15:55:28 -04:00
Michael Kirk
a7bd372147 Fix tests by removing side effect in getter 
While setting up the test CurrentAppContect, we use OWSTemporaryDirectory which in turn
recursively references CurrentAppContext, which crashes.

Clearing temp directories on every activation is sufficient.
 2019-04-01 14:05:58 -06:00
Matthew Chen
dd54b40bed Respond to CR. 2019-03-27 13:15:26 -04:00
Matthew Chen
987726df6c Temp files. 2019-03-27 12:37:22 -04:00
Michael Kirk
f243914fe5 NSTemporaryDirectory -> OWSTemporaryDirectory/AccessibleAfterFirstAuth 
Remove redundant move - AFNetworking alread moves the CFNetwork tmp file for
us.
 2018-10-03 14:01:36 -06:00
Michael Kirk
6560358375 Fix failed attachment downloads in beta 2018-10-02 14:38:05 -06:00
Matthew Chen
399dd13cee Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 2018-09-07 15:37:40 -04:00
Michael Kirk
c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics 
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
 2018-09-07 10:00:48 -06:00
Matthew Chen
f473f60111 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Michael Kirk
c05700fd98 Log in OWSFail 
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
 2018-08-09 15:30:19 -06:00
Matthew Chen
d0c691bb7f Lazy attachment restores. 2018-04-02 09:27:34 -04:00
Matthew Chen
08ba7c85ed Clean up ahead of PR. 2018-03-20 11:23:56 -04:00
Matthew Chen
4746948dfe Respond to CR. 2018-03-14 10:02:44 -03:00
Michael Kirk
e020b0ff99 Persist default sound so we can use it for fallback notifications 
// FREEBIE
 2018-02-26 15:41:35 -05:00
Matthew Chen
706006539f Improve the robustness of the migration logic. 2018-02-20 20:16:12 -05:00
Matthew Chen
d91507d897 Improve the robustness of the migration logic. 2018-02-20 17:37:14 -05:00
Michael Kirk
033505afd7 Remove slow file protection updates from launch path 
To avoid blocking launch, file protection is now updated async for most
moved files. Out of paranoia, the database files are also update
redundantly on a sync code path.

It's still critical that we update permissions recursively for two
reasons:

1. Updating a containing directories FileProtection does not affect
   existing files in that directory.

2. Because we've changed the containers default file protection level
   (from unspecified to NSFileProtectionComplete), some existing files
   will have there file protection updated upon launching Signal 2.20.
   It's not clear to me which files this affects, and I haven't found
   any relevant documentation, but from observation, it seems to affect
   any top-level files in the container. Regardless, we're now doing the
   right thing: after launching 2.20, ensure all file permissions are
   what we expect.

Also removed no-op file protection on legacy db files. They've already
been moved by the time this method runs in AppSetup.

// FREEBIE
 2018-02-18 16:24:29 -05:00
matthew chen
47aa29db25 Fix build breakage. 2018-02-15 09:38:00 -05:00
Michael Kirk
da15f245cf CR: fix early return, assert on error 
inline functions which were only used once

// FREEBIE
 2018-02-15 06:23:47 -08:00
Michael Kirk
b4359b33dd Fix "lose messages received while in background" 
A moved legacy DB has the NSFileProtectionClassComplete, meaning it's
never accessible while the device is locked.

// FREEBIE
 2018-02-15 06:23:47 -08:00
Matthew Chen
5cf89a0f3d Register all database views asynchronously. 2018-01-30 10:30:28 -05:00
Matthew Chen
6f7f1b3b08 Improve pre-migration testing tools. 2018-01-30 10:06:46 -05:00
Matthew Chen
9d909025c9 Handle UIImage shares. 2018-01-25 15:17:51 -05:00
Matthew Chen
5770a18b08 Handle text shares like URLs. 2018-01-25 13:26:10 -05:00
Matthew Chen
6a81d8e5c2 Respond to CR. 2018-01-25 13:16:35 -05:00
Matthew Chen
0cc7f3e00e Clean up ahead of PR. 2018-01-25 11:00:38 -05:00
Matthew Chen
16f7317579 Complete backup restore/import. 2018-01-11 10:44:03 -05:00
Matthew Chen
272a90d269 Add import back up UI. Begin work on import backup logic. 2018-01-11 10:42:57 -05:00
Matthew Chen
9ac2383a2c Retain changes from session database branch. 2018-01-10 12:18:29 -05:00