Michael Kirk
29315febee
Merge tag '2.42.4.0' into release/2.43.0
2019-09-12 18:55:41 -07:00
Michael Kirk
75f3339c26
soft delete contact threads
2019-09-12 12:24:13 -06:00
Michael Kirk
bb316f711b
Merge tag '2.42.1.1' into release/2.43.0
2019-09-05 14:52:59 -06:00
Nora Trapp
ccaa4e0e90
Fix avatar contact name when is disabled
2019-09-03 12:12:13 -07:00
Nora Trapp
7d4e486db1
Allow tapping collection view to dismiss the keyboard.
2019-09-03 10:35:01 -07:00
Nora Trapp
7e0e1b7ae9
Preserve the content offset when the keyboard size changes (for example, when dismissing a quoted reply)
2019-09-03 10:35:01 -07:00
Nora Trapp
3444a7fbd6
Preserve scroll position when presenting message actions.
2019-09-03 10:35:01 -07:00
Nora Trapp
f9b2c2eec7
Ensure the desired keyboard state is updated after interactive dismissal
2019-09-03 10:35:01 -07:00
Nora Trapp
eb9b0313ef
Ensure the desired keyboard state is updated after interactive dismissal
2019-08-30 12:46:35 -07:00
Matthew Chen
3570cf77bb
Merge remote-tracking branch 'private/release/2.42.0'
2019-08-30 14:58:21 -03:00
Matthew Chen
f738e666a1
Review GRDB TODOs.
2019-08-30 14:45:14 -03:00
Matthew Chen
8f739ede7e
Review GRDB TODOs.
2019-08-30 14:45:14 -03:00
Nora Trapp
b71a499ec6
Fix peek interactions with keyboard measurement.
2019-08-29 22:28:01 -07:00
Nora Trapp
129535f2d7
Merge branch 'release/2.42.0'
2019-08-29 15:21:40 -07:00
Nora Trapp
b45516839f
Restore old ~profile display
2019-08-29 10:18:12 -07:00
Nora Trapp
686e439106
Restore contact offer
2019-08-29 10:15:30 -07:00
Matthew Chen
098d1dfb1b
Remove YDB header usage.
2019-08-29 10:24:27 -03:00
Matthew Chen
6da987eb3a
Remove YDB header usage.
2019-08-29 10:24:27 -03:00
Matthew Chen
a5efaf8d16
Merge remote-tracking branch 'private/release/2.42.0'
2019-08-28 11:33:26 -03:00
Matthew Chen
79b1d31f20
Don't load YDB unless necessary.
...
Don't load YDB unless necessary.
Don't load YDB unless necessary.
Don't load YDB unless necessary.
2019-08-26 13:18:30 -03:00
Michael Kirk
45c4066a80
Fix deadlock with thread.name
...
For contact threads, thread.name opened a sneaky transaction, which would
sometimes cause a deadlock.
This commit moves the name method to the contact manager and offers an explicit
transaction flavor. There is still a sneaky transaction flavor used in some
places where it's deemed dangerous to plumb through a transaction without
further scrutiny.
2019-08-23 18:45:23 -06:00
Matthew Chen
91f60dd064
Merge remote-tracking branch 'private/release/2.42.0'
2019-08-22 16:33:03 -03:00
Matthew Chen
4343efaadb
Fix stale transaction in conversation view.
2019-08-22 14:53:04 -03:00
Michael Kirk
7926b915cb
cache thread on viewItem
2019-08-22 11:22:03 -06:00
Michael Kirk
8e73133ffe
reload ThreadDetails ViewItem whenever its present
2019-08-22 11:22:03 -06:00
Michael Kirk
952fa2823f
perf: Avoid repeated re-fetching of interactions
...
Previously:
- ConversationMapping determines which uniqueIds are in the conversation window
- ConversationViewModel fetched (and frequently refetched) interactions from those ids
Now:
- ConversationMapping determines which interactions are in the conversation window
- ConversationViewModel grabs the already fetched interactions from the conversation mapping
2019-08-22 11:22:03 -06:00
Matthew Chen
189b20e2af
Remove YDB usage.
2019-08-22 09:32:00 -03:00
Matthew Chen
47b000ec09
Remove YDB usage.
2019-08-22 09:32:00 -03:00
Nora Trapp
6759961c33
Fix duplicated thread name
2019-08-21 20:40:21 -07:00
Michael Kirk
4f5c61646c
CR: moved cached color getter to contacts manager
2019-08-21 09:06:35 -06:00
Michael Kirk
822d5f9708
cache conversation color names
...
Repeatedly fetching threads is a perf hit when rendering interactions.
2019-08-21 09:06:35 -06:00
Michael Kirk
6deaead851
less likely to show review
...
Potentially showing the review request immediately after the user has sent a
message, may be too soon. Also, it involves some storage machinery.
Instead, we use the dumber "has shown home view controller n times", and have a
high n. This also has the benefit of requiring no persistent storage.
2019-08-21 08:44:49 -06:00
Michael Kirk
926e76270f
Merge tag '2.42.0.8'
2019-08-20 09:52:18 -06:00
Michael Kirk
85c214d0f4
synthesize ivar
2019-08-19 17:28:47 -06:00
Nora Trapp
0619d38af3
Add sticker button compensation to conversation text input
2019-08-19 16:23:38 -07:00
Nora Trapp
8c515e38eb
Always align input toolbar left-to-right
2019-08-19 13:14:30 -07:00
Michael Kirk
3699a938be
reset senderUsername when replacing a viewItem
2019-08-16 15:58:52 -06:00
Michael Kirk
d19e48da5c
"Add More" from recents selection
2019-08-16 13:51:19 -07:00
Michael Kirk
312bff8497
remove no-longer necessary hacks
2019-08-16 13:04:11 -06:00
Michael Kirk
a81ca528ea
re-use existing transaction
2019-08-16 13:04:10 -06:00
Matthew Chen
85756b0fe9
Merge remote-tracking branch 'private/release/2.42.0'
2019-08-16 13:21:38 -03:00
Nora Trapp
86c3211609
Don't show thread details in note to self
2019-08-15 14:09:01 -07:00
Nora Trapp
6da1d9d7e8
Username as a fallback option in display name
2019-08-15 12:37:51 -07:00
Matthew Chen
f5fd583e75
Reduce usage of OWSUserProfile header.
2019-08-15 16:10:14 -03:00
Matthew Chen
d308c566af
Address deadlocks in profile manager.
2019-08-15 16:10:14 -03:00
Michael Kirk
e490163896
CR: fixup nil/error handling
2019-08-15 11:04:46 -06:00
Michael Kirk
7e3f03d03f
Swift interop: throwable method for DRY composable error handling
2019-08-15 09:36:57 -06:00
Nora Trapp
5e4ff39e36
Fix an optional unwrapping issue
2019-08-14 22:20:43 -07:00
Nora Trapp
875a3adde8
PR Feedback
2019-08-14 21:44:14 -07:00
Nora Trapp
5ce5264d07
Add username creation flow.
2019-08-14 21:44:14 -07:00