This change moves `PinSetupViewController`'s `isWeakPin` method to
`OWS2FAManager`, adds tests, and adds an additional length check.
This change should have no user impact and is useful for an upcoming
task.
**I recommend reviewing this with whitespace changes disabled.**
We have some code that looks like this:
func processAll() {
while processNext() {}
}
func processNext() {
autoreleasepool {
process()
}
}
I think it's clearer to move the `autoreleasepool` "up" a level, like
this:
func processAll() {
while autoreleasepool(invoking: { processNext() }) {}
}
func processNext() {
process()
}
This change should have no user impact.
* Retry most network failures in RegistrationCoordinator
* Update the way we identify network errors to be more flexible
* Retry remaining requests
* Automatically retry registration requests if time intervals are short
* fix error types not compiling on kbs
* Add test for reg recovery password reg with retries
* fix extra t
* Interpret nil nextVerificationAttempt as a code not having been sent yet, not as no code able to be submitted
* Update request and submit verification code handlers to latest server spec
* Update CreateAccountResponse codes to match server spec
* Update ChangeNumberResponse codes to match server spec
* Rename some cases for clarity, propagate up network errors vs generic errors
* pr comments
* Move RegistrationNavigationController
* Create the most basic version of RegistrationNavController conceivable
* Hook up RegistrationCoordinator
* Add new scheme for testing registration bravo
* Finish registration in RegistrationCoordinator
* Get tests to compile again (but not pass)
* Tests passing again
* Test session happy path all the way through to completion
* Test KBS auth credential happy path all the way through to completion
* Test KBS reg recovery password happy path all the way through to completion
* PR comments
* Add ability to compute registration recovery password
* Add RegistrationCoordinator
* remove repeat nav controller that evan added
* Scaffolding for RegistrationCoodinator test
* Add first round of RegistrationCoordinator tests, some stuff I needed to get them working, and some fixes to RegistrationCoordinator itself I discovered thanks to the tests
* switch to owsFailBeta
* Add auth credential candidate flow tests, related fixes and additions to coordinator and friends
* Add tests for session based registration path and associated fixes
* PR comment nits
