Guard compilation of all DebugUI* classes with USE_DEBUG_UI instead of DEBUG and stop defining USE_DEBUG_UI whenever DEBUG is defined. Instead I defined USE_DEBUG_UI separately for Debug builds
in the project settings.
Benefits:
• can easily enable Debug UI for non-debug builds.
• allow use USE_DEBUG_UI in Swift files.
• move video playback progress bar to the bottom panel.
• vertically compact layout of video playback controls in landscape.
• hide album preview strip when in landscape.
• move Forward and Share buttons to the navigation bar when in landscape.
Change license to AGPL
This commit:
- Updates the `LICENSE` file
- Start every file with something like:
// Copyright YEAR_FIRST_PUBLISHED Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
---
First, I removed existing license headers with this Ruby 3.1.2 script:
require 'set'
EXTENSIONS_TO_CHECK = Set['.h', '.hpp', '.cpp', '.m', '.mm', '.pch', '.swift']
same = 0
different = 0
all_files = `git ls-files`.lines.map { |line| line.strip }
all_files.each do |relative_path|
if relative_path == 'Pods'
next
end
unless EXTENSIONS_TO_CHECK.include? File.extname(relative_path)
next
end
path = File.expand_path(relative_path)
contents = File.read(path)
new_contents = contents.sub(/\/\/\n\/\/ Copyright .*\n\/\/\n\n/, '')
if contents == new_contents
same += 1
else
different += 1
end
File.write(path, new_contents)
end
puts "updated #{different} file(s), left #{same} untouched"
I'm sure this script could be improved, but it worked well enough.
Then, I created `Scripts/lint/lint-license-headers` and ran it to auto-
fix a lot of files. This changed the mode of some files, but I think
that's actually desirable. For example,
`SignalServiceKit/src/Util/AppContext.m` previously had a mode of
`0755/-rwxr-xr-x`, and it's now `0644/-rw-r--r--`.
Then I fixed some stragglers and updated the precommit script.
See [a similar change in the Desktop app][0].
[0]: 8bfaf598af
* Consolidate context menu actions into one class used by Stories list and my stories
* add context menu to story viewer
* change hidden stories header into a regular cell
* generate context menu at tap time to properly reload hidden state
* some cleanup
* pr feedback
* Add DelegatingContextMenuButton to maintain desired hooks without deviating ContextMenuButton's API from that of UIButton
* Start muted, unmute when pressing volume buttons
* move ringer switch observation into its own class
* observe ringer switch in stories
* add foreground time to AppContext; use to drive mute foregrounding behavior
* dont double observe
* mix story volume with others, show volume controls
