signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix retain cycles with ApplePayButton usage

Browse Source 
I introduced retain cycles in 1a253bbf86.
This fixes them!
This commit is contained in:
Evan Hahn 2022-05-27 16:05:30 -05:00 committed by Evan Hahn
parent fa99be971d
commit fa099f6e96
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Signal/src/ViewControllers/AppSettings/Donations/BoostViewController.swift
View File

@ -467,7 +467,9 @@ extension BoostViewController: PKPaymentAuthorizationControllerDelegate {
guard let self = self else { return UITableViewCell() }
let cell = self.newCell()
let applePayButton = ApplePayButton(actionBlock: self.requestApplePayDonation)
let applePayButton = ApplePayButton { [weak self] in
self?.requestApplePayDonation()
}
cell.contentView.addSubview(applePayButton)
applePayButton.autoPinEdgesToSuperviewMargins()
applePayButton.autoSetDimension(.height, toSize: 48, relation: .greaterThanOrEqual)

4
Signal/src/ViewControllers/AppSettings/Donations/SubscriptionViewController.swift
View File

@ -433,7 +433,9 @@ class SubscriptionViewController: OWSTableViewController2 {
selectedSubscriptionLevel: selectedSubscriptionLevel,
currentSubscription: currentSubscription)
let applePayButton = ApplePayButton(actionBlock: self.requestApplePayDonation)
let applePayButton = ApplePayButton { [weak self] in
self?.requestApplePayDonation()
}
self.applePayButton = applePayButton
applePayButton.isEnabled = state.isApplePayButtonEnabled