From ee2f39d3d17fb906942672e9e1aa1c39503d48ba Mon Sep 17 00:00:00 2001 From: Igor Solomennikov Date: Wed, 3 Aug 2022 17:59:53 -0700 Subject: [PATCH] Fix an issue where buttons in text overlay toolbar could be too small. The cause of this issue was that ImageEditorViewController's view was created with zero dimensions. Those dimensions were then used to pre-calculate size of the toolbar which ended up being incorrect. The fix is to let UIKit create the root view and move everything we did in `loadView` to `viewDidLoad`. --- .../Views/ImageEditor/ImageEditorViewController.swift | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/SignalUI/Views/ImageEditor/ImageEditorViewController.swift b/SignalUI/Views/ImageEditor/ImageEditorViewController.swift index 0afc5bac4c..d61b947a37 100644 --- a/SignalUI/Views/ImageEditor/ImageEditorViewController.swift +++ b/SignalUI/Views/ImageEditor/ImageEditorViewController.swift @@ -234,10 +234,8 @@ class ImageEditorViewController: OWSViewController { model.add(observer: self) } - override func loadView() { - view = UIView() + override func viewDidLoad() { view.backgroundColor = .black - view.isOpaque = true imageEditorView.configureSubviews() view.addSubview(imageEditorView) @@ -268,10 +266,6 @@ class ImageEditorViewController: OWSViewController { strokeWidthSliderPosition = strokeWidthSliderContainer.centerXAnchor.constraint(equalTo: view.leadingAnchor) strokeWidthSliderPosition?.autoInstall() strokeWidthSliderContainer.addGestureRecognizer(UITapGestureRecognizer(target: self, action: #selector(handleSliderContainerTap(_:)))) - } - - override func viewDidLoad() { - super.viewDidLoad() updateUIForCurrentMode() }