signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix UI delay when sending a reply in chat.

Browse Source 
The UI updates (including adding a new message to conversation) were
being blocked for 1 second because of the animated dismissal of message
quote panel attached to the input field.
The fix is to block UI updates just for the duration of keyboard animations.
This commit is contained in:
Igor Solomennikov 2022-02-01 09:24:10 -08:00
parent e6e09c83e7
commit e6552c79ec
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Signal/src/ViewControllers/ConversationView/ConversationViewController+Delegates.swift
View File

@ -1,5 +1,5 @@
//
// Copyright (c) 2021 Open Whisper Systems. All rights reserved.
// Copyright (c) 2022 Open Whisper Systems. All rights reserved.
//
import Foundation
@ -377,8 +377,7 @@ extension ConversationViewController: InputAccessoryViewPlaceholderDelegate {
// loads from landing during the keyboard animation.
// It isn't safe to block loads for long, so we cap
// how long they will be blocked for.
let keyboardAnimationBlockLoadInterval: TimeInterval = kSecondInterval * 1.0
let animationCompletionDate = Date().addingTimeInterval(keyboardAnimationBlockLoadInterval)
let animationCompletionDate = Date().addingTimeInterval(duration)
let lastKeyboardAnimationDate = Date().addingTimeInterval(-1.0)
if viewState.lastKeyboardAnimationDate == nil ||
viewState.lastKeyboardAnimationDate?.isBefore(lastKeyboardAnimationDate) == true {