signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix outage detector error when there’s no network

Browse Source 
If DNS resolution fails, then it’s expected that there won’t be any
addresses. Fail gracefully in this case.

If DNS resolution succeeds and provides a non-nil but empty list of
addresses, report an error. This shouldn’t happen.
This commit is contained in:
Max Radermacher 2022-07-18 16:32:41 -07:00
parent 29507343ff
commit e4e21cab8c
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
SignalServiceKit/src/Network/OutageDetection.swift
View File

@ -52,16 +52,22 @@ public class OutageDetection: NSObject {
// DNS lookup failures, etc. are not considered an outage.
private func checkForOutageSync() -> Bool {
let host = CFHostCreateWithName(nil, "uptime.signal.org" as CFString).takeRetainedValue()
CFHostStartInfoResolution(host, .addresses, nil)
var resolutionError = CFStreamError()
guard CFHostStartInfoResolution(host, .addresses, &resolutionError) else {
Logger.warn("CFHostStartInfoResolution failed: \(resolutionError)")
return false
}
var success: DarwinBoolean = false
guard let addresses = CFHostGetAddressing(host, &success)?.takeUnretainedValue() as NSArray? else {
owsFailDebug("CFHostGetAddressing failed: no addresses.")
owsFailDebug("CFHostGetAddressing failed: nil addresses")
return false
}
guard success.boolValue else {
owsFailDebug("CFHostGetAddressing failed.")
return false
}
owsAssertDebug(addresses.count > 0, "CFHostGetAddressing: empty addresses")
var isOutageDetected = false
for case let address as NSData in addresses {
var hostname = [CChar](repeating: 0, count: Int(NI_MAXHOST))