Small changes suggested by Jordan

This commit is contained in:
Michelle Linington 2021-10-07 14:37:01 -07:00
parent ec2152e015
commit d8233ca364
2 changed files with 2 additions and 2 deletions

View File

@ -1250,7 +1250,7 @@ extension MessageSender {
messageType = .unidentifiedSenderMessageType
} else {
serializedMessage = Data(plaintext.body)
serializedMessage = Data(plaintext.serialize())
messageType = .plaintextMessageType
}

View File

@ -56,7 +56,7 @@ NS_ASSUME_NONNULL_BEGIN
/// We have to return NO since our preferred style is Plaintext. If we returned YES, a future resend response would
/// encrypt since MessageSender only deals with plaintext as Data. This is fine since its contentHint is `default`
/// anyway.
/// TODO: Maybe we should explore having a first class type to represent the plaintex message content mid-send?
/// TODO: Maybe we should explore having a first class type to represent the plaintext message content mid-send?
/// That way we don't need to call back to the original TSOutgoingMessage for questions about the plaintext. This
/// makes sense in a world where the TSOutgoingMessage is divorced from the constructed plaintext because of the
/// MessageSendLog and OWSOutgoingResendResponse