Call markAsOnboarded if we're already registered

Signal/src/AppDelegate.swift

@@ -269,7 +269,8 @@ extension AppDelegate {
         switch launchInterface {
         case .registration, .deprecatedOnboarding:
             hasInProgressRegistration = true
-        case .chatList:
+        case .chatList(let onboardingController):
+            onboardingController.markAsOnboarded()
             hasInProgressRegistration = false
         }
 

Signal/src/ViewControllers/Registration/Onboarding/Deprecated_OnboardingController.swift

@@ -161,7 +161,7 @@ public class Deprecated_OnboardingController: NSObject {
     @objc
     public func markAsOnboarded() {
         guard !tsAccountManager.isOnboarded else { return }
-        self.databaseStorage.asyncWrite {
+        self.databaseStorage.write {
             Logger.info("completed onboarding")
             self.tsAccountManager.setIsOnboarded(true, transaction: $0)
         }

Signal/src/environment/SignalApp.swift

@@ -66,8 +66,7 @@ extension SignalApp {
         case .deprecatedOnboarding(let onboardingController):
             showDeprecatedOnboardingView(onboardingController)
             AppReadiness.setUIIsReady()
-        case .chatList(let onboardingController):
-            onboardingController.markAsOnboarded()
+        case .chatList:
             showConversationSplitView()
         }