signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Feature flags for internal

Browse Source 
This reverts commit 1580ad7951.
This commit is contained in:
Nora Trapp 2020-05-21 13:50:36 -07:00
parent 235385b186
commit c53ff97ca6
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
SignalServiceKit/src/Account/TSAccountManager.m
View File

@ -491,12 +491,10 @@ NSString *const TSAccountManager_DeviceId = @"TSAccountManager_DeviceId";
}
- (void)storeLocalNumber:(NSString *)localNumber
uuid:(nullable NSUUID *)localUuid
uuid:(NSUUID *)localUuid
transaction:(SDSAnyWriteTransaction *)transaction
{
// TODO UUID: make uuid non-nullable when enabling SSKFeatureFlags.allowUUIDOnlyContacts in production
// canary assert for this TODO.
OWSAssertDebug(!TSConstants.isUsingProductionService || !SSKFeatureFlags.allowUUIDOnlyContacts);
OWSAssertDebug(localUuid);
@synchronized (self) {
[self.keyValueStore setString:localNumber key:TSAccountManager_RegisteredNumberKey transaction:transaction];

10
SignalServiceKit/src/Util/FeatureFlags.swift
View File

@ -18,7 +18,7 @@ extension FeatureBuild {
}
}
let build: FeatureBuild = OWSIsDebugBuild() ? .dev : .beta
let build: FeatureBuild = .qa
// MARK: -
@ -113,7 +113,7 @@ public class FeatureFlags: NSObject {
}
@objc
public static let uuidCapabilities = allowUUIDOnlyContacts && useOnlyModernContactDiscovery
public static let uuidCapabilities = true
@objc
public static var storageModeDescription: String {
@ -135,7 +135,7 @@ public class FeatureFlags: NSObject {
public static let strictYDBExtensions = build.includes(.beta)
@objc
public static var allowUUIDOnlyContacts = useOnlyModernContactDiscovery
public static var allowUUIDOnlyContacts = true
@objc
public static var uuidSafetyNumbers = allowUUIDOnlyContacts
@ -179,7 +179,7 @@ public class FeatureFlags: NSObject {
public static let answerCallsOnSecondaryDevice: Bool = build.includes(.beta)
@objc
public static let groupsV2 = build.includes(.qa) && !isUsingProductionService
public static let groupsV2 = true
// Don't consult this feature flag directly; instead
// consult RemoteConfig.groupsV2CreateGroups.
@ -278,7 +278,7 @@ public class DebugFlags: NSObject {
public static let groupsV2dontSendUpdates = false
@objc
public static let groupsV2showV2Indicator = FeatureFlags.groupsV2 && build.includes(.qa)
public static let groupsV2showV2Indicator = true
// If set, v2 groups will be created and updated with invalid avatars
// so that we can test clients' robustness to this case.