signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Use proper strings for PayPal confirmation sheet

Browse Source
This commit is contained in:
Evan Hahn 2022-12-02 15:44:30 -06:00 committed by Evan Hahn
parent 5a2e15039b
commit be30df543c
2 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Signal/src/ViewControllers/Donations/PaypalConfirmationViewController.swift
View File

@ -79,12 +79,11 @@ private extension PaypalConfirmationViewController {
headerSection.hasBackground = false
headerSection.shouldDisableCellSelection = true
// TODO: [PayPal] We should change this string. We're only using an old value because we have translations for it.
// let text = NSLocalizedStringX(
// "DONATION_CONFIRMATION_PAYMENT_METHOD",
// comment: "Users can donate to Signal. They may be asked to confirm their donation after entering payment information. This text will show the payment method, such as PayPal, next to it."
// )
let text = NSLocalizedString("ATTACHMENT_KEYBOARD_PAYMENT", comment: "A button to select a payment from the Attachment Keyboard")
let text = NSLocalizedString(
"DONATION_CONFIRMATION_PAYMENT_METHOD",
value: "Payment Method",
comment: "Users can donate to Signal. They may be asked to confirm their donation after entering payment information. This text will show the payment method, such as PayPal, next to it."
)
let paymentMethodSection = OWSTableSection(items: [OWSTableItem.actionItem(
name: text,
accessoryImage: Theme.isDarkThemeEnabled
@ -108,15 +107,11 @@ private extension PaypalConfirmationViewController {
func updateBottom() {
let confirmButton: UIButton = {
// TODO: [PayPal] We should change this string. We're only using an old value because we have translations for it.
// let title = NSLocalizedStringX(
// "DONATION_CONFIRMATION_BUTTON_CONFIRM",
// comment: "Users can donate to Signal. They may be asked to confirm their donation after entering payment information. If the user clicks this button, their payment will be confirmed."
// )
let title = NSLocalizedString(
"DONATION_SCREEN_DONATE_BUTTON",
comment: "On the donation settings screen, tapping this button will take the user to a screen where they can donate."
)
let title = NSLocalizedString(
"DONATION_CONFIRMATION_BUTTON_CONFIRM",
value: "Complete Donation",
comment: "Users can donate to Signal. They may be asked to confirm their donation after entering payment information. If the user clicks this button, their payment will be confirmed."
)
let button = OWSButton(title: title) { [weak self] in
guard let self else { return }
self.complete(withResult: .approved)

6
Signal/translations/en.lproj/Localizable.strings
View File

@ -1840,6 +1840,12 @@
/* On the donation screen, if you already have a subscription, you'll see a button to update your subscription. This is the text on that button. */
"DONATE_SCREEN_UPDATE_MONTHLY_SUBSCRIPTION_BUTTON" = "Update Subscription";
/* Users can donate to Signal. They may be asked to confirm their donation after entering payment information. If the user clicks this button, their payment will be confirmed. */
"DONATION_CONFIRMATION_BUTTON_CONFIRM" = "Complete Donation";
/* Users can donate to Signal. They may be asked to confirm their donation after entering payment information. This text will show the payment method, such as PayPal, next to it. */
"DONATION_CONFIRMATION_PAYMENT_METHOD" = "Payment Method";
/* Donation payment error for decline failures where authentication is required. */
"DONATION_PAYMENT_ERROR_AUTHENTICATION_REQUIRED" = "Try another payment method or contact your bank for more information.";