signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix an issue where message context menu would appear unexpectedly.

Browse Source 
Delete the code that would allow "long tap to show context menu" gesture to be
recognized simultaneously with scroll view's pan gesture. That would cause
message context menu to appear whenever user would stop inertia scrolling with
a tap and keep the finger on the screen.
This commit is contained in:
Igor Solomennikov 2023-01-10 14:58:31 -08:00
parent a283045058
commit bcdb996993
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Signal/src/ViewControllers/ConversationView/ConversationViewController+GestureRecognizers.swift
View File

@ -83,12 +83,6 @@ extension ConversationViewController: UIGestureRecognizerDelegate {
}
public func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRecognizeSimultaneouslyWith otherGestureRecognizer: UIGestureRecognizer) -> Bool {
// Allow the context menu gesture recognizer to recognize simultaneously with scroll
if gestureRecognizer == collectionViewContextMenuGestureRecognizer && otherGestureRecognizer == collectionView.panGestureRecognizer {
return true
}
// Support standard long press recognizing for body text cases, and context menu long press recognizing for everything else
let currentIsLongPressOrTap = (gestureRecognizer == collectionViewLongPressGestureRecognizer || gestureRecognizer == collectionViewContextMenuGestureRecognizer || gestureRecognizer == collectionViewTapGestureRecognizer)
let otherIsLongPressOrTap = (otherGestureRecognizer == collectionViewLongPressGestureRecognizer || otherGestureRecognizer == collectionViewContextMenuGestureRecognizer || otherGestureRecognizer == collectionViewTapGestureRecognizer)