signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Limit the scope of the 'incomplete contacts fetch' fix.

Browse Source
This commit is contained in:
Matthew Chen 2018-05-30 10:52:53 -04:00
parent 1466852329
commit bbf7ee451d
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
SignalMessaging/contacts/OWSContactsManager.m
View File

@ -140,7 +140,16 @@ NSString *const OWSContactsManagerSignalAccountsDidChangeNotification
updatedContacts:(NSArray<Contact *> *)contacts
isUserRequested:(BOOL)isUserRequested
{
[self updateWithContacts:contacts shouldClearStaleCache:isUserRequested];
BOOL shouldClearStaleCache;
// On iOS 11.2, only clear the contacts cache if the fetch was initiated by the user.
// iOS 11.2 rarely returns partial fetches and we use the cache to prevent contacts from
// periodically disappearing from the UI.
if (SYSTEM_VERSION_GREATER_THAN_OR_EQUAL_TO(11, 2) && !SYSTEM_VERSION_GREATER_THAN_OR_EQUAL_TO(11, 3)) {
shouldClearStaleCache = isUserRequested;
} else {
shouldClearStaleCache = YES;
}
[self updateWithContacts:contacts shouldClearStaleCache:shouldClearStaleCache];
}
#pragma mark - Intersection