From a91efa97186b42c42761d4be02f97c597da5fbc4 Mon Sep 17 00:00:00 2001 From: Jordan Rose Date: Wed, 25 May 2022 15:59:47 -0700 Subject: [PATCH] set_release_notes: support EDITOR with arguments And conversely, quote the base directory in case it has spaces in the path. The script is now Shellcheck-clean. --- Scripts/set_release_notes | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Scripts/set_release_notes b/Scripts/set_release_notes index 63c879576e..3c9f89bdb3 100755 --- a/Scripts/set_release_notes +++ b/Scripts/set_release_notes @@ -7,7 +7,7 @@ BASE_DIR=$(git rev-parse --show-toplevel) METADATA_ROOT="$BASE_DIR/fastlane/metadata" # Open the editor for entering the changelog -"${VISUAL:-"${EDITOR:-vi}"}" "${METADATA_ROOT}/en-US/release_notes.txt" +${VISUAL:-${EDITOR:-vi}} "${METADATA_ROOT}/en-US/release_notes.txt" -${BASE_DIR}/Scripts/translation/push-metadata-source -${BASE_DIR}/Scripts/translation/pull-metadata-translations +"${BASE_DIR}"/Scripts/translation/push-metadata-source +"${BASE_DIR}"/Scripts/translation/pull-metadata-translations