signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Enable isPointerInteractionEnabled on some glass buttons.

Browse Source 
Round buttons in chat input bar and media viewer.

With this property enabled iPadOS will highlight the button what trackpad cursor is over it.
This commit is contained in:
Igor Solomennikov 2026-05-21 11:19:01 -07:00 committed by GitHub
parent 153efb2d45
commit a7eb78f46c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Signal/ConversationView/ConversationInputToolbar.swift
View File

@ -249,6 +249,7 @@ public class ConversationInputToolbar: UIView, QuotedReplyPreviewDelegate {
button.configuration?.baseForegroundColor = Style.buttonTintColor
button.accessibilityLabel = accessibilityLabel
button.accessibilityIdentifier = accessibilityIdentifier
button.isPointerInteractionEnabled = true
button.translatesAutoresizingMaskIntoConstraints = false
button.addConstraints([
button.widthAnchor.constraint(equalToConstant: LayoutMetrics.initialTextBoxHeight),
@ -345,6 +346,7 @@ public class ConversationInputToolbar: UIView, QuotedReplyPreviewDelegate {
button.configuration?.cornerStyle = .capsule
button.accessibilityLabel = MessageStrings.sendButton
button.accessibilityIdentifier = accessibilityIdentifier
button.isPointerInteractionEnabled = true
button.translatesAutoresizingMaskIntoConstraints = false
button.addConstraints([
button.widthAnchor.constraint(equalToConstant: buttonSize),
@ -378,6 +380,7 @@ public class ConversationInputToolbar: UIView, QuotedReplyPreviewDelegate {
comment: "Accessibility hint describing what you can do with the attachment button",
)
button.accessibilityIdentifier = accessibilityIdentifier
button.isPointerInteractionEnabled = true
button.translatesAutoresizingMaskIntoConstraints = false
button.addConstraints([
button.widthAnchor.constraint(equalToConstant: buttonSize),
@ -403,6 +406,7 @@ public class ConversationInputToolbar: UIView, QuotedReplyPreviewDelegate {
button.configuration?.baseForegroundColor = .white
button.configuration?.cornerStyle = .capsule
button.accessibilityIdentifier = accessibilityIdentifier
button.isPointerInteractionEnabled = true
button.translatesAutoresizingMaskIntoConstraints = false
button.addConstraints([
button.widthAnchor.constraint(equalToConstant: buttonSize),
@ -1216,6 +1220,7 @@ public class ConversationInputToolbar: UIView, QuotedReplyPreviewDelegate {
let button = UIButton(type: .system)
button.accessibilityLabel = MessageStrings.sendButton
button.ows_adjustsImageWhenDisabled = true
button.isPointerInteractionEnabled = true
button.accessibilityIdentifier = UIView.accessibilityIdentifier(in: self, name: "sendButton")
button.setImage(UIImage(imageLiteralResourceName: "send-blue-28"), for: .normal)
button.bounds.size = CGSize(width: 48, height: LayoutMetrics.initialToolbarHeight)
@ -1225,6 +1230,7 @@ public class ConversationInputToolbar: UIView, QuotedReplyPreviewDelegate {
lazy var cameraButton: UIButton = {
let button = UIButton(type: .system)
button.tintColor = Style.buttonTintColor
button.isPointerInteractionEnabled = true
button.accessibilityLabel = OWSLocalizedString(
"CAMERA_BUTTON_LABEL",
comment: "Accessibility label for camera button.",
@ -1242,6 +1248,7 @@ public class ConversationInputToolbar: UIView, QuotedReplyPreviewDelegate {
lazy var voiceMemoButton: UIButton = {
let button = UIButton(type: .system)
button.tintColor = Style.buttonTintColor
button.isPointerInteractionEnabled = true
button.accessibilityLabel = OWSLocalizedString(
"INPUT_TOOLBAR_VOICE_MEMO_BUTTON_ACCESSIBILITY_LABEL",
comment: "accessibility label for the button which records voice memos",
@ -1367,6 +1374,8 @@ public class ConversationInputToolbar: UIView, QuotedReplyPreviewDelegate {
override private init(frame: CGRect) {
super.init(frame: frame)
isPointerInteractionEnabled = true
addSubview(roundedCornersBackground)
roundedCornersBackground.autoCenterInSuperview()
roundedCornersBackground.autoSetDimensions(to: CGSize(square: 28))

1
Signal/src/ViewControllers/HomeView/Stories/Context View/StoryContextOnboardingOverlayView.swift
View File

@ -194,6 +194,7 @@ class StoryContextOnboardingOverlayView: UIView {
self.delegate?.storyContextOnboardingOverlayWantsToExitStoryViewer(self)
},
)
closeButton.isPointerInteractionEnabled = true
closeButton.translatesAutoresizingMaskIntoConstraints = false
blurView.contentView.addSubview(closeButton)

2
Signal/src/ViewControllers/HomeView/Stories/Context View/StoryContextViewController.swift
View File

@ -297,6 +297,7 @@ class StoryContextViewController: OWSViewController, DatabaseChangeDelegate,
spinner.autoCenterInSuperview()
spinner.startAnimating()
closeButton.isPointerInteractionEnabled = true
view.addSubview(closeButton)
closeButton.translatesAutoresizingMaskIntoConstraints = false
if #available(iOS 26, *) {
@ -462,6 +463,7 @@ class StoryContextViewController: OWSViewController, DatabaseChangeDelegate,
)
}
contextButton.setActions(actions: actions)
contextButton.isPointerInteractionEnabled = true
return contextButton
}()

1
Signal/src/ViewControllers/HomeView/Stories/Replies & Views Sheets/StoryReplyInputToolbar.swift
View File

@ -303,6 +303,7 @@ class StoryReplyInputToolbar: UIView, BodyRangesTextViewDelegate {
directionalLayoutMargins.trailing -= SendButtonWrapper.legacySendButtonInnerHMargin
}
sendButton.isPointerInteractionEnabled = true
sendButton.setContentHuggingHorizontalHigh()
sendButton.setCompressionResistanceHorizontalHigh()
addSubview(sendButton)