signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix concurrency in contacts updater.

Browse Source
This commit is contained in:
Matthew Chen 2018-07-23 09:30:04 -04:00
parent 492debce41
commit 9904443fcf
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
SignalServiceKit/src/Contacts/ContactsUpdater.m
View File

@ -53,19 +53,27 @@ NS_ASSUME_NONNULL_BEGIN
{
if (identifiers.count < 1) {
OWSFail(@"%@ Cannot lookup zero identifiers", self.logTag);
failure(OWSErrorWithCodeDescription(OWSErrorCodeInvalidMethodParameters, @"Cannot lookup zero identifiers"));
dispatch_async(dispatch_get_main_queue(), ^{
failure(
OWSErrorWithCodeDescription(OWSErrorCodeInvalidMethodParameters, @"Cannot lookup zero identifiers"));
});
return;
}
[self contactIntersectionWithSet:[NSSet setWithArray:identifiers]
success:^(NSSet<SignalRecipient *> *recipients) {
if (recipients.count == 0) {
DDLogInfo(
@"%@ in %s no contacts are Signal users", self.logTag, __PRETTY_FUNCTION__);
}
success(recipients.allObjects);
}
failure:failure];
success:^(NSSet<SignalRecipient *> *recipients) {
if (recipients.count == 0) {
DDLogInfo(@"%@ in %s no contacts are Signal users", self.logTag, __PRETTY_FUNCTION__);
}
dispatch_async(dispatch_get_main_queue(), ^{
success(recipients.allObjects);
});
}
failure:^(NSError *error) {
dispatch_async(dispatch_get_main_queue(), ^{
failure(error);
});
}];
}
- (void)contactIntersectionWithSet:(NSSet<NSString *> *)recipientIdsToLookup