signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix crashes while deallocating PeerConnectionClient.

Browse Source
This commit is contained in:
Matthew Chen 2018-05-29 09:52:51 -04:00
parent 8d9c811566
commit 86e038436b
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Signal/src/call/PeerConnectionClient.swift
View File

@ -80,6 +80,13 @@ protocol PeerConnectionClientDelegate: class {
// [PeerConnectionClient terminate] when it is done with a PeerConnectionClient
// instance, so terminate is a reliable place where we can break the retain cycle.
//
// Note that we use the proxy in two ways:
//
// * As a delegate for the peer connection and the data channel,
// safely forwarding delegate method invocations to the PCC.
// * To safely obtain references to the PCC within the PCC's
// async blocks.
//
// This should be fixed in Swift 4, but it isn't.
//
// To test using the following scenarios: