signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Send profile key to call link members

Browse Source
This commit is contained in:
Marissa Le Coz 2024-10-09 13:46:41 -04:00 committed by GitHub
parent ad61ebb494
commit 77c81ab0ea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 131 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Signal.xcodeproj/project.pbxproj
View File

@ -2689,6 +2689,7 @@
E18C4A7729EF2ECC007534D4 /* SignalAccountTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = E18C4A7629EF2ECC007534D4 /* SignalAccountTest.swift */; };
E1A090382A4B909B00F2BE8B /* RecipientHidingManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1A090372A4B909B00F2BE8B /* RecipientHidingManager.swift */; };
E1B32F842CA6162A002141F4 /* LinkPreviewCallLink.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1CFAAA22C9DD2B1003145C3 /* LinkPreviewCallLink.swift */; };
E1B32F892CAB63E0002141F4 /* CallLinkProfileKeySharingManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1B32F852CAB5923002141F4 /* CallLinkProfileKeySharingManager.swift */; };
E1C2A54B2A8FCB0D00AEC4DA /* DeleteSystemContactViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1C2A54A2A8FCB0D00AEC4DA /* DeleteSystemContactViewController.swift */; };
E1D827D52BD9B6E50022C1AF /* ReactionsBurstView.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1D827D42BD9B6E50022C1AF /* ReactionsBurstView.swift */; };
E1D827D72BD9DA4D0022C1AF /* ReactionsSink.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1D827D62BD9DA4D0022C1AF /* ReactionsSink.swift */; };
@ -6330,6 +6331,7 @@
E18C4A7629EF2ECC007534D4 /* SignalAccountTest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SignalAccountTest.swift; sourceTree = "<group>"; };
E1A090372A4B909B00F2BE8B /* RecipientHidingManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RecipientHidingManager.swift; sourceTree = "<group>"; };
E1A0AD8B16E13FDD0071E604 /* CoreFoundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreFoundation.framework; path = System/Library/Frameworks/CoreFoundation.framework; sourceTree = SDKROOT; };
E1B32F852CAB5923002141F4 /* CallLinkProfileKeySharingManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CallLinkProfileKeySharingManager.swift; sourceTree = "<group>"; };
E1C2A54A2A8FCB0D00AEC4DA /* DeleteSystemContactViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DeleteSystemContactViewController.swift; sourceTree = "<group>"; };
E1CFAAA22C9DD2B1003145C3 /* LinkPreviewCallLink.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LinkPreviewCallLink.swift; sourceTree = "<group>"; };
E1D827D42BD9B6E50022C1AF /* ReactionsBurstView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReactionsBurstView.swift; sourceTree = "<group>"; };
@ -10597,6 +10599,7 @@
B9C0A96C2C6D3F63001FD0AA /* CallLinkApprovalRequestView.swift */,
B93E4B2B2C9A3298005989B6 /* CallLinkApprovalViewModel.swift */,
B9DFDAD62C99F68A00588AD1 /* CallLinkBulkApprovalSheet.swift */,
E1B32F852CAB5923002141F4 /* CallLinkProfileKeySharingManager.swift */,
505A254B2CAE7BA700CF4C26 /* CallLinkViewController.swift */,
E1E78CAE2B573BD100B6FC2D /* CallMemberCameraOffView.swift */,
E1E78CAC2B573B5800B6FC2D /* CallMemberChromeOverlayView.swift */,
@ -15836,6 +15839,7 @@
50A7830E2C0128D70008030E /* CallLinkCall.swift in Sources */,
500504AE2CA32969003D27ED /* CallLinkFetchJobRunner.swift in Sources */,
50733B1E2BAD038D00CEEC1F /* CallLinkManager.swift in Sources */,
E1B32F892CAB63E0002141F4 /* CallLinkProfileKeySharingManager.swift in Sources */,
50462B2E2C9E441F00FC5920 /* CallLinkStateUpdater.swift in Sources */,
505A254C2CAE7BA700CF4C26 /* CallLinkViewController.swift in Sources */,
E1E78CAF2B573BD100B6FC2D /* CallMemberCameraOffView.swift in Sources */,

7
Signal/AppLaunch/AppEnvironment.swift
View File

@ -36,6 +36,8 @@ public class AppEnvironment: NSObject {
let windowManagerRef = WindowManager()
private(set) var callLinkProfileKeySharingManager: CallLinkProfileKeySharingManager!
private(set) var appIconBadgeUpdater: AppIconBadgeUpdater!
private(set) var badgeManager: BadgeManager!
private var usernameValidationObserverRef: UsernameValidationObserver?
@ -65,6 +67,11 @@ public class AppEnvironment: NSObject {
database: DependenciesBridge.shared.db
)
self.callLinkProfileKeySharingManager = CallLinkProfileKeySharingManager(
db: DependenciesBridge.shared.db,
accountManager: DependenciesBridge.shared.tsAccountManager
)
appReadiness.runNowOrWhenAppWillBecomeReady {
self.badgeManager.startObservingChanges(in: self.databaseStorage)
self.appIconBadgeUpdater.startObserving()

119
Signal/Calls/UserInterface/CallLinkProfileKeySharingManager.swift Normal file
View File

@ -0,0 +1,119 @@
//
// Copyright 2024 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
//
import LibSignalClient
import SignalServiceKit
public class CallLinkProfileKeySharingManager {
private var consideredAcis = Set<Aci>()
private let db: any DB
private let accountManager: TSAccountManager
init(db: any DB, accountManager: TSAccountManager) {
self.db = db
self.accountManager = accountManager
}
@MainActor
func sendProfileKeyToCallMembers(
acis: [Aci],
blockingManager: BlockingManager
) {
var unconsideredAcis = [Aci]()
for aci in acis {
if !consideredAcis.contains(aci) {
unconsideredAcis.append(aci)
}
}
let eligibleAcisNotSentProfileKeyYet = unconsideredAcis.filter { aci in
return db.read { tx in
let isLocal = accountManager.localIdentifiers(tx: tx)?.aci == aci
let address = SignalServiceAddress(aci)
let isBlocked = blockingManager.isAddressBlocked(
address,
transaction: SDSDB.shimOnlyBridge(tx)
)
let isEligible = !isLocal && !isBlocked
if !isEligible {
consideredAcis.insert(aci)
}
return isEligible
}
}
if eligibleAcisNotSentProfileKeyYet.isEmpty { return }
self.consideredAcis.formUnion(eligibleAcisNotSentProfileKeyYet)
db.asyncWrite { tx in
for aci in eligibleAcisNotSentProfileKeyYet {
self.sendProfileKey(aci: aci, tx: tx)
}
}
}
private func sendProfileKey(aci: Aci, tx: DBWriteTransaction) {
let address = SignalServiceAddress(aci)
if
let thread = TSContactThread.getWithContactAddress(
address,
transaction: SDSDB.shimOnlyBridge(tx)
)
{
let profileKeyMessage = OWSProfileKeyMessage(
thread: thread,
transaction: SDSDB.shimOnlyBridge(tx)
)
let preparedMessage = PreparedOutgoingMessage.preprepared(
transientMessageWithoutAttachments: profileKeyMessage
)
SSKEnvironment.shared.messageSenderJobQueueRef.add(
message: preparedMessage,
transaction: SDSDB.shimOnlyBridge(tx)
)
}
}
}
extension CallLinkProfileKeySharingManager: GroupCallObserver {
func groupCallPeekChanged(_ call: GroupCall) {
sendProfileKeyIfApplicable(call: call)
}
@MainActor
private func sendProfileKeyIfApplicable(call: GroupCall) {
switch call.concreteType {
case .groupThread:
return
case .callLink(let callLinkCall):
if
callLinkCall.localUserHasConsentedToJoin(),
let acis = callLinkCall.ringRtcCall.peekInfo?.joinedMembers.map({ Aci(fromUUID: $0) })
{
sendProfileKeyToCallMembers(
acis: acis,
blockingManager: SSKEnvironment.shared.blockingManagerRef
)
}
}
}
}
private extension CallLinkCall {
func localUserHasConsentedToJoin() -> Bool {
switch self.joinState {
case .notJoined:
return false
case .joining, .pending, .joined:
return true
}
}
}

1
Signal/Calls/UserInterface/GroupCallViewController.swift
View File

@ -295,6 +295,7 @@ class GroupCallViewController: UIViewController {
super.init(nibName: nil, bundle: nil)
groupCall.addObserver(self)
groupCall.addObserver(AppEnvironment.shared.callLinkProfileKeySharingManager)
NotificationCenter.default.addObserver(
self,