signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Respond to CR.

Browse Source
This commit is contained in:
Matthew Chen 2018-04-16 12:14:09 -04:00
parent a5c7bdb987
commit 6831412e44
5 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Signal/src/ViewControllers/ConversationView/Cells/OWSBubbleStrokeView.m
View File

@ -87,7 +87,7 @@ NS_ASSUME_NONNULL_BEGIN
// Prevent the shape layer from animating changes.
[CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];
[CATransaction setDisableActions:YES];
// Don't fill the shape layer; we just want a stroke around the border.
self.shapeLayer.fillColor = [UIColor clearColor].CGColor;
@ -114,7 +114,7 @@ NS_ASSUME_NONNULL_BEGIN
// Prevent the shape layer from animating changes.
[CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];
[CATransaction setDisableActions:YES];
self.shapeLayer.strokeColor = self.strokeColor.CGColor;
self.shapeLayer.lineWidth = self.strokeThickness;

4
Signal/src/ViewControllers/ConversationView/Cells/OWSBubbleView.m
View File

@ -133,7 +133,7 @@ const CGFloat kBubbleTextVInset = 10.f;
// Prevent the shape layer from animating changes.
[CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];
[CATransaction setDisableActions:YES];
self.shapeLayer.fillColor = bubbleColor.CGColor;
@ -153,7 +153,7 @@ const CGFloat kBubbleTextVInset = 10.f;
// Prevent the shape layer from animating changes.
[CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];
[CATransaction setDisableActions:YES];
self.shapeLayer.fillColor = self.bubbleColor.CGColor;
self.shapeLayer.path = bezierPath.CGPath;

2
Signal/src/views/AudioProgressView.swift
View File

@ -75,7 +75,7 @@ import SignalServiceKit
// Prevent the shape layer from animating changes.
CATransaction.begin()
CATransaction.setValue(kCFBooleanTrue, forKey: kCATransactionDisableActions)
CATransaction.setDisableActions(true)
let horizontalBarPath = UIBezierPath()
let horizontalBarHeightFraction = CGFloat(0.25)

2
Signal/src/views/OWSBezierPathView.m
View File

@ -86,7 +86,7 @@ NS_ASSUME_NONNULL_BEGIN
// Prevent the shape layer from animating changes.
[CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];
[CATransaction setDisableActions:YES];
for (ConfigureShapeLayerBlock configureShapeLayerBlock in self.configureShapeLayerBlocks) {
CAShapeLayer *shapeLayer = [CAShapeLayer new];

4
Signal/src/views/OWSProgressView.m
View File

@ -45,7 +45,7 @@ NS_ASSUME_NONNULL_BEGIN
// Prevent the shape layer from animating changes.
[CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];
[CATransaction setDisableActions:YES];
self.borderLayer = [CAShapeLayer new];
self.borderLayer.fillColor = self.color.CGColor;
@ -87,7 +87,7 @@ NS_ASSUME_NONNULL_BEGIN
{
// Prevent the shape layer from animating changes.
[CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];
[CATransaction setDisableActions:YES];
CGFloat kBorderThickness = self.bounds.size.height * 0.1f;
CGFloat kOuterRadius = self.bounds.size.height * 0.25f;