From ce816caa71647639d20e32987c51d367da0db245 Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Fri, 20 Sep 2019 20:02:19 -0300 Subject: [PATCH] Only clean up temporary attachments when app is ready. --- .../src/Messages/Interactions/TSOutgoingMessage.m | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m b/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m index 5fc7029483..bbc91e8fad 100644 --- a/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m +++ b/SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m @@ -16,6 +16,7 @@ #import "TSQuotedMessage.h" #import #import +#import #import #import #import @@ -512,6 +513,11 @@ NSUInteger const TSOutgoingMessageSchemaVersion = 1; // Message is not transient; no need to clean up attachments. return; } + if (!AppReadiness.isAppReady) { + // We don't want or need to do this clean up while registering extensions, + // migrating, etc. + return; + } NSArray *_Nullable attachmentIds = self.attachmentIds; if (attachmentIds.count < 1) { return;