From 53f12dff8967cfead4e47024d8e62c3c48ab9c19 Mon Sep 17 00:00:00 2001 From: Jordan Rose Date: Fri, 22 Mar 2024 17:36:37 -0700 Subject: [PATCH] Don't check app expiry in OWSChatConnection, leave it to HTTPUtils This was effectively being checked three times instead of just once. --- .../src/Network/OWSChatConnection.swift | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/SignalServiceKit/src/Network/OWSChatConnection.swift b/SignalServiceKit/src/Network/OWSChatConnection.swift index 0f9581d3df..c344729333 100644 --- a/SignalServiceKit/src/Network/OWSChatConnection.swift +++ b/SignalServiceKit/src/Network/OWSChatConnection.swift @@ -462,12 +462,6 @@ public class OWSChatConnection: NSObject { ensureBackgroundKeepAlive(.receiveResponse) - // The websocket is only used to connect to the main signal - // service, so we need to check for remote deprecation. - if responseStatus == AppExpiryImpl.appExpiredStatusCode { - appExpiry.setHasAppExpiredAtCurrentVersion(db: db) - } - let headers = OWSHttpHeaders() headers.addHeaderList(message.headers, overwriteOnConflict: true) @@ -1032,13 +1026,7 @@ extension OWSChatConnection { Self.outageDetection.reportConnectionSuccess() }, - failure: { (failure: OWSHTTPErrorWrapper) in - if failure.error.responseStatusCode == AppExpiryImpl.appExpiredStatusCode { - self.appExpiry.setHasAppExpiredAtCurrentVersion(db: self.db) - } - - failureParam(failure) - }) + failure: failureParam) } }