signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Improve audio source debug log descriptions

Browse Source
This commit is contained in:
Jordan Rose 2023-03-08 16:19:20 -08:00 committed by Max Radermacher
parent 2d48da8a6d
commit 50427668a3
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Signal/src/Calls/AudioSource.swift
View File

@ -7,7 +7,7 @@ import Foundation
import AVFoundation
import SignalServiceKit
public struct AudioSource: Hashable {
public struct AudioSource: Hashable, CustomDebugStringConvertible {
public let localizedName: String
public let portDescription: AVAudioSessionPortDescription?
@ -82,4 +82,22 @@ public struct AudioSource: Hashable {
hasher.combine(portDescription.uid)
}
public var debugDescription: String {
guard let portDescription = self.portDescription else {
assert(self.isBuiltInSpeaker)
return "<built-in speaker>"
}
return portDescription.logSafeDescription
}
}
extension AVAudioSessionPortDescription {
var logSafeDescription: String {
let portName = self.portName
if portName.dropFirst(4).isEmpty {
return "<\(portType): \(portName)>"
}
return "<\(portType): \(portName.prefix(2))..\(portName.suffix(2))>"
}
}

2
Signal/src/Calls/CallAudioService.swift
View File

@ -452,7 +452,7 @@ class CallAudioService: NSObject, CallObserver {
return [AudioSource.builtInSpeaker]
}
Logger.info("availableInputs: \(availableInputs)")
Logger.info("availableInputs: \(availableInputs.map(\.logSafeDescription))")
return [AudioSource.builtInSpeaker] + availableInputs.map { portDescription in
return AudioSource(portDescription: portDescription)
}