signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Merge branch 'mkirk/rtl-caption'

Browse Source
This commit is contained in:
Michael Kirk 2018-02-12 14:01:46 -08:00
commit 4bf453da33
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
SignalMessaging/attachments/AttachmentApprovalViewController.swift
View File

@ -627,7 +627,16 @@ class CaptioningToolbar: UIView, UITextViewDelegate {
contentView.layoutMargins = UIEdgeInsets(top: kToolbarMargin, left: kToolbarMargin, bottom: kToolbarMargin, right: kToolbarMargin)
self.textViewHeightConstraint = textView.autoSetDimension(.height, toSize: kMinTextViewHeight)
textView.autoPinEdges(toSuperviewMarginsExcludingEdge: .right)
// We pin all three edges explicitly rather than doing something like:
// textView.autoPinEdges(toSuperviewMarginsExcludingEdge: .right)
// because that method uses `leading` / `trailing` rather than `left` vs. `right`.
// So it doesn't work as expected with RTL layouts when we explicitly want something
// to be on the right side for both RTL and LTR layouts, like with the send button.
// I believe this is a bug in PureLayout. Filed here: https://github.com/PureLayout/PureLayout/issues/209
textView.autoPinEdge(toSuperviewMargin: .left)
textView.autoPinEdge(toSuperviewMargin: .top)
textView.autoPinEdge(toSuperviewMargin: .bottom)
sendButton.autoPinEdge(.left, to: .right, of: textView, withOffset: kToolbarMargin)