signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix small visual bugs in group member sheet

Browse Source 
This fixes two small regressions introduced in
80e8379738:

1. There's a bit too much spacing at the top.

2. In dark mode, the grabber had the wrong background color. (As you can
   see in the code, my solution here is a temporary workaround before we
   do a larger refactor.)
This commit is contained in:
Evan Hahn 2022-06-10 11:49:51 -05:00 committed by Evan Hahn
parent 152080a93b
commit 4a05570dc2
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Signal/src/ViewControllers/ThreadSettings/MemberActionSheet.swift
View File

@ -18,7 +18,18 @@ class MemberActionSheet: InteractiveSheetViewController {
let address: SignalServiceAddress
override var interactiveScrollViews: [UIScrollView] { [tableViewController.tableView] }
override var sheetBackgroundColor: UIColor { tableViewController.tableBackgroundColor }
override var sheetBackgroundColor: UIColor {
// We can't use `tableViewController.tableBackgroundColor` directly because it changes
// depending on whether it's inside a view controller. When this variable is first used,
// `tableViewController` isn't a child yet, so the color will be different.
//
// In the long term, we should consider a larger refactor, likely by turning this sheet's
// contents into a "regular" view.
//
// See IOS-2468 for more details.
OWSTableViewController2.tableBackgroundColor(isUsingPresentedStyle: true)
}
var contentSizeHeight: CGFloat {
tableViewController.tableView.contentSize.height + tableViewController.tableView.adjustedContentInset.totalHeight
@ -128,10 +139,9 @@ class MemberActionSheet: InteractiveSheetViewController {
let contents = OWSTableContents()
defer { tableViewController.setContents(contents, shouldReload: shouldReload) }
// Leave space at the top for the handle
let handleSection = OWSTableSection()
handleSection.customHeaderHeight = 50
contents.addSection(handleSection)
let topSpacerSection = OWSTableSection()
topSpacerSection.customHeaderHeight = 12
contents.addSection(topSpacerSection)
let section = OWSTableSection()
contents.addSection(section)