signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix isRetryable for network failure SignalErrors

Browse Source
This commit is contained in:
Max Radermacher 2026-05-22 15:39:21 -05:00
parent 5b4ee2044a
commit 2ead22b6f3
3 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
SignalServiceKit/Groups/GroupV2UpdatesImpl.swift
View File

@ -952,10 +952,6 @@ public extension GroupV2UpdatesImpl {
extension GroupsV2Error: IsRetryableProvider {
public var isRetryableProvider: Bool {
if self.isNetworkFailureOrTimeout {
return true
}
switch self {
case
.conflictingChangeOnService,

3
SignalServiceKit/Network/API/OWSHTTPError.swift
View File

@ -104,9 +104,6 @@ public enum OWSHTTPError: Error, CustomDebugStringConvertible, IsRetryableProvid
// MARK: - IsRetryableProvider
public var isRetryableProvider: Bool {
if isNetworkFailureImpl || isTimeoutImpl {
return true
}
switch self {
case .wrappedFailure:
return true

8
SignalServiceKit/Util/Error+IsRetryable.swift
View File

@ -24,11 +24,11 @@ extension Error {
//
// When trying to cast an error to IsRetryableProvider,
// we need to try casting both the Error and NSError form.
if let error = self as? IsRetryableProvider {
return error.isRetryableProvider
if let error = self as? IsRetryableProvider, error.isRetryableProvider {
return true
}
if let error = (self as NSError) as? IsRetryableProvider {
return error.isRetryableProvider
if let error = (self as NSError) as? IsRetryableProvider, error.isRetryableProvider {
return true
}
if self.isNetworkFailureOrTimeout {