signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Remove option to enter recovery key from PIN entry screen.

Browse Source
This commit is contained in:
Pete Walters 2026-06-09 16:53:12 -05:00 committed by GitHub
parent f5892e0aad
commit 213cbcd9ad
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 0 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Signal/Registration/UserInterface/RegistrationNavigationController.swift
View File

@ -624,17 +624,6 @@ extension RegistrationNavigationController: RegistrationPinPresenter {
func submitWithCreateNewPinInstead() {
pushNextController(coordinator.skipAndCreateNewPINCode())
}
func enterRecoveryKey() {
pushNextController(
.value(.enterRecoveryKey(
RegistrationEnterAccountEntropyPoolState(
canShowBackButton: true,
canShowNoKeyHelpButton: false,
),
)),
)
}
}
extension RegistrationNavigationController: RegistrationPinAttemptsExhaustedAndMustCreateNewPinPresenter {

23
Signal/Registration/UserInterface/RegistrationPinViewController.swift
View File

@ -89,8 +89,6 @@ protocol RegistrationPinPresenter: AnyObject {
func submitWithCreateNewPinInstead()
func exitRegistration()
func enterRecoveryKey()
}
// MARK: - RegistrationPinViewController
@ -454,18 +452,6 @@ class RegistrationPinViewController: OWSViewController {
))
}
actions.append(
UIAction(
title: OWSLocalizedString(
"PIN_ENTER_EXISTING_USE_RECOVERY_KEY",
comment: "If the user is re-registering, they need to enter their PIN to restore all their data. If they don't remember their PIN, they may remember their Recovery Key which can be used instead of a PIN.",
),
handler: { [weak self] _ in
self?.presenter?.enterRecoveryKey()
},
),
)
if let exitAction = exitAction() {
actions.append(exitAction)
}
@ -682,15 +668,6 @@ class RegistrationPinViewController: OWSViewController {
}
}
actionSheet.addAction(.init(
title: OWSLocalizedString(
"ONBOARDING_2FA_SKIP_AND_USE_RECOVERY_KEY",
comment: "Label for action to use Recovery Key instead of PIN for registration.",
),
) { [weak self] _ in
self?.presenter?.enterRecoveryKey()
})
actionSheet.addAction(.init(title: CommonStrings.contactSupport) { [weak self] _ in
guard let self else { return }
ContactSupportActionSheet.present(

6
Signal/translations/en.lproj/Localizable.strings
View File

@ -6073,9 +6073,6 @@
/* Label for the 'skip and create new pin' button when reglock is disabled during onboarding. */
"ONBOARDING_2FA_SKIP_AND_CREATE_NEW_PIN" = "Skip and Create New PIN";
/* Label for action to use Recovery Key instead of PIN for registration. */
"ONBOARDING_2FA_SKIP_AND_USE_RECOVERY_KEY" = "Use Recovery Key";
/* Explanation for the skip pin entry action sheet during onboarding. */
"ONBOARDING_2FA_SKIP_PIN_ENTRY_MESSAGE" = "If you can’t remember your PIN, you can create a new one. You can register and use your account but you’ll lose some saved settings like your profile information.";
@ -6940,9 +6937,6 @@
/* If the user is re-registering, they need to enter their PIN to restore all their data. In some cases, they can skip this entry and lose some data. This text is shown on a button that lets them begin to do this. */
"PIN_ENTER_EXISTING_SKIP" = "Skip PIN";
/* If the user is re-registering, they need to enter their PIN to restore all their data. If they don't remember their PIN, they may remember their Recovery Key which can be used instead of a PIN. */
"PIN_ENTER_EXISTING_USE_RECOVERY_KEY" = "Use Recovery Key";
/* The explanation for the 'pin reminder' dialog. */
"PIN_REMINDER_EXPLANATION" = "To help you memorize your PIN, we’ll ask you to enter it periodically. We’ll ask less over time.";