signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix bug when Context menu in chat list only had "Settings".

Browse Source 
Cannot cache the settings button and context menu with it - the menu has to be
built every time to reflect current state of the chat list.
This commit is contained in:
Igor Solomennikov 2023-06-06 11:08:50 -07:00
parent 237319f133
commit 126b4f40f9
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Signal/src/ViewControllers/HomeView/Chat List/ChatListViewController.swift
View File

@ -360,7 +360,7 @@ public class ChatListViewController: OWSViewController {
return layerView
}()
private lazy var settingsBarButtonItem: UIBarButtonItem = {
private func settingsBarButtonItem() -> UIBarButtonItem {
let contextButton = ContextMenuButton()
contextButton.showsContextMenuAsPrimaryAction = true
contextButton.contextMenu = settingsContextMenu()
@ -378,8 +378,11 @@ public class ChatListViewController: OWSViewController {
PaymentsViewUtils.addUnreadBadge(toView: wrapper)
}
return .init(customView: wrapper)
}()
let barButtonItem = UIBarButtonItem(customView: wrapper)
barButtonItem.accessibilityLabel = CommonStrings.openSettingsButton
barButtonItem.accessibilityIdentifier = "ChatListViewController.settingsButton"
return barButtonItem
}
// MARK: Table View
@ -464,9 +467,7 @@ public class ChatListViewController: OWSViewController {
guard chatListMode == .inbox && !viewState.multiSelectState.isActive else { return }
// Settings button.
navigationItem.leftBarButtonItem = settingsBarButtonItem
settingsBarButtonItem.accessibilityLabel = CommonStrings.openSettingsButton
settingsBarButtonItem.accessibilityIdentifier = "ChatListViewController.settingsButton"
navigationItem.leftBarButtonItem = settingsBarButtonItem()
var rightBarButtonItems = [UIBarButtonItem]()