signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Ensure a stale peerConnectionClient doesn't call any methods on the CallService

Browse Source 
Nil delegates when terminating call

// FREEBIE
This commit is contained in:
Michael Kirk 2017-01-17 20:17:29 -05:00
parent 32789bd960
commit 0072ee3033
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Signal/src/call/CallService.swift
View File

@ -885,6 +885,7 @@ fileprivate let timeoutSeconds = 60
assertOnSignalingQueue()
Logger.debug("\(TAG) in \(#function)")
peerConnectionClient?.delegate = nil
peerConnectionClient?.terminate()
peerConnectionClient = nil

2
Signal/src/call/PeerConnectionClient.swift
View File

@ -53,7 +53,7 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
}
// Delegate is notified of key events in the call lifecycle.
private weak var delegate: PeerConnectionClientDelegate!
public weak var delegate: PeerConnectionClientDelegate!
// Connection