Commit Graph

180 Commits

Author SHA1 Message Date
WELCommand
555385d2b8 Fix associated object bug in UIKit extensions (#3872) 2020-01-04 19:34:04 -05:00
svoit
d6db8307d9 Merge branch 'master' into code_cleaning
* master: (61 commits)
  Update Travis config for Xcode 10.
  Add test for object posting notification
  update README.md, the old "Foundation URL Loading System" link is 404
  Change test name to correct one
  Change default teardown methods to tests
  Update tests to use new API
  Update PR feedback, add more tests
  Add test
  remove temporary method that could be doing nothing
  Update HTTPBin certificates.
  Chinese CONTRIBUTING.md translate
  Delete CONTRIBUTING_CH.md
  Chinese Contributing.md translate
  rollback method 'AFPostReachabilityStatusChange'
  Use AFNetworkReachabilityManager to compare  consistency of notification posts and gets, instead of SCNetworkReachabilityRef. And test case reference.
  Remove test that is nilling session manually as it's not possible anymore to not have valid session (correctly)
  Add tests for  verifing reachability manager consistence  for notification posting and getting
  Specify Xcode 9.4 in Travis file.
  Update AFImageDownloader.m
  Add an ability that notification-observer know which reachability its belong
  ...
2018-10-08 23:28:53 +02:00
bbeversdorf
342653f27e
Update AFImageDownloader.m 2018-07-13 10:15:08 -05:00
Brian Beversdorf
1c52c76537 Safely get mergedTasks On responseQueue
There is a race condition in -[AFImageDownloader downloadImageForURLRequest:withReceiptID:success:failure:] that can cause a crash.

#3876
#3984
2018-07-12 16:09:29 -05:00
Jeff Kelley
b15888735a
Merge pull request #4002 from LeeHongHwa/fix_coding_convention
fix space used in Objective-C method (coding style)
2018-06-07 22:56:28 -07:00
Huang-Libo
357466d102
Update AFAutoPurgingImageCache.m
NSString property should use `copy`.
2018-05-07 00:51:45 +08:00
svoit
1f70ba85bb Code cleaning 2018-04-10 23:23:46 +02:00
aduflo
f0b1149731 added test to cover image download with malformed url 2018-01-12 09:42:34 -05:00
Adam Duflo
0b35a643c6
Prevent stuck state for bad urlRequest 2018-01-10 16:17:52 -05:00
Henddher Pedroza
9b33c1699f self in block 2017-07-28 17:11:47 -05:00
Henddher Pedroza
51a80847ed Ask <AFImageRequestCache> implementor if an image should be cached. Implementors may prevent caching. 2017-07-28 11:15:44 -05:00
Henddher Pedroza
f6f64c83b3 Remove setter for defaultURLCache 2017-07-28 08:48:58 -05:00
Henddher Pedroza
8db67cdfa9 Allow initialization of AFImageDownloader using custom NSURLSessionConfiguration. 2017-07-28 08:45:02 -05:00
Henddher Pedroza
41897b19c6 Ability to set the defaultURLCache 2017-07-26 18:10:07 -05:00
leehonghwa
27c819537a Fix asterisk location in method declaration 2017-07-19 15:08:26 +09:00
leehonghwa
c18c09a75c fix space used in Objective-C method (coding style) 2017-07-19 14:29:27 +09:00
Kevin Harwood
b36f0ed444 Added a comment 2016-10-10 09:21:17 -05:00
flutechang
84d18cac75 Fix crash around customizing NSURLCache size. 2016-10-10 09:21:17 -05:00
skyline75489
0fc675e960 Use NSURLRequest to construct dataTask. Fix #3724 2016-10-09 22:00:24 +08:00
Kevin Harwood
748a410ba7 Fixed bug with webview delegate callback 2016-10-06 10:13:24 -05:00
Kevin Harwood
f51f0b8533 Merge pull request #3565 from chenxin0123/cx
Moved `[self didChangeValueForKey:@"currentState"]` into correct scope
2016-08-03 08:12:55 -05:00
Mathieu Meylan
7dc973b89c Fixed an issue where registering a UIProgessView to a task that was already completed would crash with the following error:
CRASH: Fatal exception: An instance ***** of class ******* was deallocated while key value observers were still registered with it.
2016-07-05 17:01:53 +02:00
CX
023f3505c8 move [self didChangeValueForKey:@"currentState"]; into if scope 2016-06-11 20:04:48 +08:00
Diego Chohfi
c0131a92a1 Deprecating method dataTaskWithRequest:completionHandler: from AFURLSessionManager 2016-05-03 11:53:11 -03:00
Cédric Luthi
885e0a4b4e Enable more warnings 2016-04-09 01:06:05 +02:00
Cédric Luthi
c52ff8510f Remove unnecessary #pragma clang diagnostic ignored 2016-04-09 00:41:38 +02:00
Cédric Luthi
16c09fae46 Remove all #pragma clang diagnostic ignored "-Wgnu" 2016-04-08 23:46:10 +02:00
Kevin Harwood
32cf30a245 Merge pull request #3385 from AFNetworking/bug/fix_image_downloader_crash_with_bad_url
Fixed crash if bad URL was passed into the image downloader
2016-03-14 13:10:59 -05:00
Kevin Harwood
aba212c842 Merge pull request #3332 from duanhong169/master
Fixed issue where UIButton image downloading called wrong cancel method
2016-03-14 09:06:40 -05:00
Kevin Harwood
ac6ba4580e Refactored to dispatch an error if a bad URL is passed in. 2016-03-14 09:02:48 -05:00
Christian Wen
fa2c806a39 Prevent crash when "AFImageDownloader identifier" is nil (which is cause by passing an NSURLRequest which doesn't return an absoluteString). #3343. Added a test for this behavior. 2016-03-14 08:50:28 -05:00
Kevin Harwood
326ccb170d Merge pull request #3384 from Draveness/patch-2
Added white space to URLs in code comment to allow Xcode to properly parse them
2016-03-14 08:48:06 -05:00
Draveness
c27b46c87d Add leading whitespace to urls 2016-03-14 10:17:27 +08:00
Draveness
d0b1db20d8 Add whitespace between url and ')' to prevent Xcode misunderstanding 2016-03-14 10:12:20 +08:00
Hakon Hanesand
5623891554 update documentation to match method names 2016-03-03 18:40:58 -06:00
周明宇
fac9d87340 Fixed image memory calculation 2016-02-17 10:44:52 +08:00
duanhong
49e77f198b typo and incomplete doc 2016-02-16 10:05:33 +08:00
duanhong
e457fc980d fix: wrong methods called. 2016-02-16 10:05:33 +08:00
Kevin Harwood
ed39be2a09 Improved the Unit Test
Fixed issue where test could still fail if cancelled in a certain order
2016-02-08 10:56:28 -06:00
Kevin Harwood
bfc67c9d6c Fixed image downloading cancellation race condition
Addresses #3324
2016-02-08 10:56:28 -06:00
Kevin Harwood
056a1b69d6 Merge pull request #3290 from AFNetworking/docs/copyright_bump
Bumping copyright to 2016
2016-01-14 16:23:50 -06:00
Kevin Harwood
412d903e62 Fixed crash when passing nil/null for progress in UIWebView extension 2016-01-14 08:31:45 -06:00
Kevin Harwood
5d73b00640 Bumping copyright to 2016 2016-01-05 09:22:42 -06:00
eofs
4ead780eee Button image changed instead of background image 2015-12-14 15:11:57 +02:00
Kevin Harwood
43d4847e39 Fixed race condition with image downloader when starting/cancelling/starting the same request
Alternate Solution

See https://github.com/Alamofire/AlamofireImage/issues/55 for details
2015-12-11 10:36:54 -06:00
Chris Utz
c920f3ce81 add newlines to end of .h files. 2015-12-06 11:37:27 -06:00
Kevin Harwood
2adeda5d44 Added a deprecated flag to older methods in the API 2015-12-04 11:18:22 -06:00
Kevin Harwood
210c260422 New Progress Reporting API
These changes expose a simpler, block based progress reporting API, while maintaining the ability for more advanced features using KVO on NSProgress.
2015-12-04 11:18:22 -06:00
Cédric Luthi
19097d695d Remove OS_OBJECT_HAVE_OBJC_SUPPORT conditional compilation
`OS_OBJECT_HAVE_OBJC_SUPPORT` is defined to 1 for iOS deployment target >= 6.0 and OS X deployment target >= 10.8.
2015-11-25 00:33:53 +01:00
Rick Silva
cfed41d1cf Fix AFImageDownloader stalling after number of failures reaches maximumActiveDownloads.
The active task count was only being decremented after success. Once
the number of failures reaches the maximumActiveDownloads, no more
tasks were being started.
2015-11-12 11:42:44 -05:00