This modifies the IsSStx, IsSSGen, and IsSSRtx functions to only return a bool and introduces CheckSStx, CheckSSGen, and CheckSSRtx to return the actual error as needed by consensus. This is being done because "is" functions are much nicer to use when they don't return an error and the callers that use them almost never care why they aren't of the type, they just want to determine if they are. In the few cases where the caller does care, they can use of the new check functions. While here, also update the comments to call out what the more common names for the transaction types are and to add comments to the test functions for consistency. Finally, it updates all callers in the repo accordingly. |
||
|---|---|---|
| .. | ||
| addblock | ||
| checkdevpremine | ||
| dcrctl | ||
| findcheckpoint | ||
| gencerts | ||
| promptsecret | ||