76f6906e50
The error handling in the tests for the wire package were recently updated to make use of the new errors.Is and errors.As standard library functions introduced in Go 1.13, but they were only updated mechanically as opposed to being updated to use the new capabilities of errors.Is checking for a specific error code as opposed to just the error type. Consequently, this updates the tests to remove all of the additional type checking via errors.As and instead look for the exact expected error code via errors.Is. This change is desirable since only examining the type of error doesn't prove that the test is actually hitting the specific error it intends too, rather only that it is hitting an error of the same type. It also corrects a couple of tests and error returns that were discovered to be incorrect in the process.
270 lines
7.8 KiB
Go
270 lines
7.8 KiB
Go
// Copyright (c) 2013-2016 The btcsuite developers
|
|
// Copyright (c) 2015-2020 The Decred developers
|
|
// Use of this source code is governed by an ISC
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package wire
|
|
|
|
import (
|
|
"bytes"
|
|
"errors"
|
|
"io"
|
|
"net"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/davecgh/go-spew/spew"
|
|
)
|
|
|
|
// TestAddr tests the MsgAddr API.
|
|
func TestAddr(t *testing.T) {
|
|
pver := ProtocolVersion
|
|
|
|
// Ensure the command is expected value.
|
|
wantCmd := "addr"
|
|
msg := NewMsgAddr()
|
|
if cmd := msg.Command(); cmd != wantCmd {
|
|
t.Errorf("NewMsgAddr: wrong command - got %v want %v",
|
|
cmd, wantCmd)
|
|
}
|
|
|
|
// Ensure max payload is expected value for latest protocol version.
|
|
// Num addresses (size of varInt for max address ) + max allowed addresses.
|
|
wantPayload := uint32(30003)
|
|
maxPayload := msg.MaxPayloadLength(pver)
|
|
if maxPayload != wantPayload {
|
|
t.Errorf("MaxPayloadLength: wrong max payload length for "+
|
|
"protocol version %d - got %v, want %v", pver,
|
|
maxPayload, wantPayload)
|
|
}
|
|
|
|
// Ensure max payload length is not more than MaxMessagePayload.
|
|
if maxPayload > MaxMessagePayload {
|
|
t.Fatalf("MaxPayloadLength: payload length (%v) for protocol "+
|
|
"version %d exceeds MaxMessagePayload (%v).", maxPayload, pver,
|
|
MaxMessagePayload)
|
|
}
|
|
|
|
// Ensure NetAddresses are added properly.
|
|
tcpAddr := &net.TCPAddr{IP: net.ParseIP("127.0.0.1"), Port: 8333}
|
|
na, err := NewNetAddress(tcpAddr, SFNodeNetwork)
|
|
if err != nil {
|
|
t.Errorf("NewNetAddress: %v", err)
|
|
}
|
|
err = msg.AddAddress(na)
|
|
if err != nil {
|
|
t.Errorf("AddAddress: %v", err)
|
|
}
|
|
if msg.AddrList[0] != na {
|
|
t.Errorf("AddAddress: wrong address added - got %v, want %v",
|
|
spew.Sprint(msg.AddrList[0]), spew.Sprint(na))
|
|
}
|
|
|
|
// Ensure the address list is cleared properly.
|
|
msg.ClearAddresses()
|
|
if len(msg.AddrList) != 0 {
|
|
t.Errorf("ClearAddresses: address list is not empty - "+
|
|
"got %v [%v], want %v", len(msg.AddrList),
|
|
spew.Sprint(msg.AddrList[0]), 0)
|
|
}
|
|
|
|
// Ensure adding more than the max allowed addresses per message returns
|
|
// error.
|
|
for i := 0; i < MaxAddrPerMsg+1; i++ {
|
|
err = msg.AddAddress(na)
|
|
}
|
|
if err == nil {
|
|
t.Errorf("AddAddress: expected error on too many addresses " +
|
|
"not received")
|
|
}
|
|
err = msg.AddAddresses(na)
|
|
if err == nil {
|
|
t.Errorf("AddAddresses: expected error on too many addresses " +
|
|
"not received")
|
|
}
|
|
}
|
|
|
|
// TestAddrWire tests the MsgAddr wire encode and decode for various numbers
|
|
// of addresses and protocol versions.
|
|
func TestAddrWire(t *testing.T) {
|
|
// A couple of NetAddresses to use for testing.
|
|
na := &NetAddress{
|
|
Timestamp: time.Unix(0x495fab29, 0), // 2009-01-03 12:15:05 -0600 CST
|
|
Services: SFNodeNetwork,
|
|
IP: net.ParseIP("127.0.0.1"),
|
|
Port: 8333,
|
|
}
|
|
na2 := &NetAddress{
|
|
Timestamp: time.Unix(0x495fab29, 0), // 2009-01-03 12:15:05 -0600 CST
|
|
Services: SFNodeNetwork,
|
|
IP: net.ParseIP("192.168.0.1"),
|
|
Port: 8334,
|
|
}
|
|
|
|
// Empty address message.
|
|
noAddr := NewMsgAddr()
|
|
noAddrEncoded := []byte{
|
|
0x00, // Varint for number of addresses
|
|
}
|
|
|
|
// Address message with multiple addresses.
|
|
multiAddr := NewMsgAddr()
|
|
multiAddr.AddAddresses(na, na2)
|
|
multiAddrEncoded := []byte{
|
|
0x02, // Varint for number of addresses
|
|
0x29, 0xab, 0x5f, 0x49, // Timestamp
|
|
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // SFNodeNetwork
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
|
|
0x00, 0x00, 0xff, 0xff, 0x7f, 0x00, 0x00, 0x01, // IP 127.0.0.1
|
|
0x20, 0x8d, // Port 8333 in big-endian
|
|
0x29, 0xab, 0x5f, 0x49, // Timestamp
|
|
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // SFNodeNetwork
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
|
|
0x00, 0x00, 0xff, 0xff, 0xc0, 0xa8, 0x00, 0x01, // IP 192.168.0.1
|
|
0x20, 0x8e, // Port 8334 in big-endian
|
|
|
|
}
|
|
|
|
tests := []struct {
|
|
in *MsgAddr // Message to encode
|
|
out *MsgAddr // Expected decoded message
|
|
buf []byte // Wire encoding
|
|
pver uint32 // Protocol version for wire encoding
|
|
}{
|
|
// Latest protocol version with no addresses.
|
|
{
|
|
noAddr,
|
|
noAddr,
|
|
noAddrEncoded,
|
|
ProtocolVersion,
|
|
},
|
|
|
|
// Latest protocol version with multiple addresses.
|
|
{
|
|
multiAddr,
|
|
multiAddr,
|
|
multiAddrEncoded,
|
|
ProtocolVersion,
|
|
},
|
|
}
|
|
|
|
t.Logf("Running %d tests", len(tests))
|
|
for i, test := range tests {
|
|
// Encode the message to wire format.
|
|
var buf bytes.Buffer
|
|
err := test.in.BtcEncode(&buf, test.pver)
|
|
if err != nil {
|
|
t.Errorf("BtcEncode #%d error %v", i, err)
|
|
continue
|
|
}
|
|
if !bytes.Equal(buf.Bytes(), test.buf) {
|
|
t.Errorf("BtcEncode #%d\n got: %s want: %s", i,
|
|
spew.Sdump(buf.Bytes()), spew.Sdump(test.buf))
|
|
continue
|
|
}
|
|
|
|
// Decode the message from wire format.
|
|
var msg MsgAddr
|
|
rbuf := bytes.NewReader(test.buf)
|
|
err = msg.BtcDecode(rbuf, test.pver)
|
|
if err != nil {
|
|
t.Errorf("BtcDecode #%d error %v", i, err)
|
|
continue
|
|
}
|
|
if !reflect.DeepEqual(&msg, test.out) {
|
|
t.Errorf("BtcDecode #%d\n got: %s want: %s", i,
|
|
spew.Sdump(msg), spew.Sdump(test.out))
|
|
continue
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestAddrWireErrors performs negative tests against wire encode and decode
|
|
// of MsgAddr to confirm error paths work correctly.
|
|
func TestAddrWireErrors(t *testing.T) {
|
|
pver := ProtocolVersion
|
|
|
|
// A couple of NetAddresses to use for testing.
|
|
na := &NetAddress{
|
|
Timestamp: time.Unix(0x495fab29, 0), // 2009-01-03 12:15:05 -0600 CST
|
|
Services: SFNodeNetwork,
|
|
IP: net.ParseIP("127.0.0.1"),
|
|
Port: 8333,
|
|
}
|
|
na2 := &NetAddress{
|
|
Timestamp: time.Unix(0x495fab29, 0), // 2009-01-03 12:15:05 -0600 CST
|
|
Services: SFNodeNetwork,
|
|
IP: net.ParseIP("192.168.0.1"),
|
|
Port: 8334,
|
|
}
|
|
|
|
// Address message with multiple addresses.
|
|
baseAddr := NewMsgAddr()
|
|
baseAddr.AddAddresses(na, na2)
|
|
baseAddrEncoded := []byte{
|
|
0x02, // Varint for number of addresses
|
|
0x29, 0xab, 0x5f, 0x49, // Timestamp
|
|
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // SFNodeNetwork
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
|
|
0x00, 0x00, 0xff, 0xff, 0x7f, 0x00, 0x00, 0x01, // IP 127.0.0.1
|
|
0x20, 0x8d, // Port 8333 in big-endian
|
|
0x29, 0xab, 0x5f, 0x49, // Timestamp
|
|
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // SFNodeNetwork
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
|
|
0x00, 0x00, 0xff, 0xff, 0xc0, 0xa8, 0x00, 0x01, // IP 192.168.0.1
|
|
0x20, 0x8e, // Port 8334 in big-endian
|
|
|
|
}
|
|
|
|
// Message that forces an error by having more than the max allowed
|
|
// addresses.
|
|
maxAddr := NewMsgAddr()
|
|
for i := 0; i < MaxAddrPerMsg; i++ {
|
|
maxAddr.AddAddress(na)
|
|
}
|
|
maxAddr.AddrList = append(maxAddr.AddrList, na)
|
|
maxAddrEncoded := []byte{
|
|
0xfd, 0xe9, 0x03, // Varint for number of addresses (1001)
|
|
}
|
|
|
|
tests := []struct {
|
|
in *MsgAddr // Value to encode
|
|
buf []byte // Wire encoding
|
|
pver uint32 // Protocol version for wire encoding
|
|
max int // Max size of fixed buffer to induce errors
|
|
writeErr error // Expected write error
|
|
readErr error // Expected read error
|
|
}{
|
|
// Latest protocol version with intentional read/write errors.
|
|
// Force error in addresses count
|
|
{baseAddr, baseAddrEncoded, pver, 0, io.ErrShortWrite, io.EOF},
|
|
// Force error in address list.
|
|
{baseAddr, baseAddrEncoded, pver, 1, io.ErrShortWrite, io.EOF},
|
|
// Force error with greater than max addresses.
|
|
{maxAddr, maxAddrEncoded, pver, 3, ErrTooManyAddrs, ErrTooManyAddrs},
|
|
}
|
|
|
|
t.Logf("Running %d tests", len(tests))
|
|
for i, test := range tests {
|
|
// Encode to wire format.
|
|
w := newFixedWriter(test.max)
|
|
err := test.in.BtcEncode(w, test.pver)
|
|
if !errors.Is(err, test.writeErr) {
|
|
t.Errorf("BtcEncode #%d wrong error got: %v, want: %v", i, err,
|
|
test.writeErr)
|
|
continue
|
|
}
|
|
|
|
// Decode from wire format.
|
|
var msg MsgAddr
|
|
r := newFixedReader(test.max, test.buf)
|
|
err = msg.BtcDecode(r, test.pver)
|
|
if !errors.Is(err, test.readErr) {
|
|
t.Errorf("BtcDecode #%d wrong error got: %v, want: %v", i, err,
|
|
test.readErr)
|
|
continue
|
|
}
|
|
}
|
|
}
|